From nobody Mon Feb 27 21:10:41 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PQY7W0S7Qz3t83R; Mon, 27 Feb 2023 21:10:47 +0000 (UTC) (envelope-from matthias.andree@tu-dortmund.de) Received: from unimail.uni-dortmund.de (mx1.hrz.uni-dortmund.de [129.217.128.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "unimail.tu-dortmund.de", Issuer "GEANT OV RSA CA 4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PQY7T4wPrz3CbD; Mon, 27 Feb 2023 21:10:45 +0000 (UTC) (envelope-from matthias.andree@tu-dortmund.de) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=tu-dortmund.de header.s=unimail header.b=hDX6FdMM; spf=pass (mx1.freebsd.org: domain of matthias.andree@tu-dortmund.de designates 129.217.128.51 as permitted sender) smtp.mailfrom=matthias.andree@tu-dortmund.de; dmarc=none Received: from mandree.no-ip.org (p54a03c23.dip0.t-ipconnect.de [84.160.60.35]) (authenticated bits=0) by unimail.uni-dortmund.de (8.17.1.9/8.17.1) with ESMTPSA id 31RLAgX2018989 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 27 Feb 2023 22:10:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tu-dortmund.de; s=unimail; t=1677532242; bh=MIvOgwupDQ2SJNRk0FxW3VeE3hnipq8rBfxD9vFFv+w=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=hDX6FdMMP0HPuhCViUJyZlxIiIRZh9kw9DgxHrPzubRzGZqAx2HY+9DzwGvg6lbbv VzM2gg2Osx/bQtAg56K4Fwq34hbLbPhrcz+fw3yRtGxoiF3STpKDRjVqAvPtLmGRx8 cymhV5/OWE1Qu7mTUT/E4PLUsl47hdQK55QgRNVM= Received: from [127.0.0.1] (localhost [127.0.0.1]) by ryzen.an3e.de (Postfix) with ESMTP id 307C0CEF3EB; Mon, 27 Feb 2023 22:10:42 +0100 (CET) Message-ID: <7060eb24-1692-72ad-0faa-73ee301d95d2@tu-dortmund.de> Date: Mon, 27 Feb 2023 22:10:41 +0100 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: git: c17ddfbf66e2 - main - lang/python: add bytecode trigger Content-Language: en-US To: Antoine Brodin , Charlie Li Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, portmgr References: <202302152135.31FLZxEE021962@gitrepo.freebsd.org> From: Matthias Andree In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-5.30 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; DWL_DNSWL_LOW(-1.00)[tu-dortmund.de:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.996]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; RCVD_IN_DNSWL_MED(-0.20)[129.217.128.51:from]; R_SPF_ALLOW(-0.20)[+ip4:129.217.128.0/24]; R_DKIM_ALLOW(-0.20)[tu-dortmund.de:s=unimail]; MIME_GOOD(-0.10)[text/plain]; RWL_MAILSPIKE_GOOD(-0.10)[129.217.128.51:from]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[tu-dortmund.de:+]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[dev-commits-ports-main@freebsd.org,dev-commits-ports-all@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; ASN(0.00)[asn:680, ipnet:129.217.0.0/16, country:DE]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[tu-dortmund.de]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Queue-Id: 4PQY7T4wPrz3CbD X-Spamd-Bar: ----- X-ThisMailContainsUnwantedMimeParts: N Am 18.02.23 um 08:42 schrieb Antoine Brodin: > On Wed, Feb 15, 2023 at 9:36 PM Charlie Li wrote: >> >> The branch main has been updated by vishwin: >> >> URL: https://cgit.FreeBSD.org/ports/commit/?id=c17ddfbf66e2801ec620d49979aca3d7077d7002 >> >> commit c17ddfbf66e2801ec620d49979aca3d7077d7002 >> Author: Charlie Li >> AuthorDate: 2023-02-15 20:57:06 +0000 >> Commit: Charlie Li >> CommitDate: 2023-02-15 21:35:07 +0000 >> >> lang/python: add bytecode trigger >> >> Facilitates compiling, writing and removing bytecode files (.pyc) >> in site-packages after all pkg transactions have been completed. >> >> Technical details: https://wiki.freebsd.org/Python/CompiledPackages >> >> Fixes reports of Python port builds as root failing on filesystem >> violations due to bytecode file writes where the port did not include >> them in the package. >> >> For those ports/packages that currently package bytecode, some >> checksum mismatches on those files may occur. This is harmless and >> will be rectified, in large as part of a USE_PYTHON=distutils >> overhaul to reduce churn. >> >> While here, implement a long-standing todo item of letting lang/python >> ports use python.mk bits. Not only does this obviate duplicate >> variables in each Makefile, but SUB_LIST (also added) is used for >> these triggers. >> >> Co-authored by: tcberner >> Approved by: tcberner (mentor) >> Differential Revision: https://reviews.freebsd.org/D34739 > > Hello, > > There are some errors with this trigger: > > Installing py39-sphinx-5.3.0,1... >> => Cleaning stale bytecode files... > pkg-static: Failed to execute lua trigger: [string "function > cleanup(directory)..."]:21: attempt to get length of a nil value > (local 'res') > pkg-static: lua script failed > > Installing py39-breathe-4.34.0... >> => Cleaning stale bytecode files... > pkg-static: Failed to execute lua trigger: attempt to index a nil value > pkg-static: lua script failed > > Antoine This has been unanswered in 9 days and obviously the triggers are not ready for prime-time. I have reverted this breaking change in a9d9d3a4 (and yes, PORTREVISIONS are going forward - quite a bit of an effort of getting the revert hopefully right without messing with port versions). Charlie, please go back to https://reviews.freebsd.org/D34739, fix up everything in the lua script, request an -exp run, clean up the fall-out, and then commit.