Re: git: e7b134bf62ce - main - devel/aws-sdk-cpp: Update to 1.11.25
Date: Mon, 27 Feb 2023 16:32:40 UTC
On 27/02/2023 14:30, Danilo Egea Gondolfo wrote:
> On 27/02/2023 13:28, Nuno Teixeira wrote:
>
>> The branch main has been updated by eduardo:
>>
>> URL:
>> https://cgit.FreeBSD.org/ports/commit/?id=e7b134bf62ce15bd1daf1f7fbed512262baa8eea
>>
>> commit e7b134bf62ce15bd1daf1f7fbed512262baa8eea
>> Author: Nuno Teixeira <eduardo@FreeBSD.org>
>> AuthorDate: 2023-02-27 09:00:18 +0000
>> Commit: Nuno Teixeira <eduardo@FreeBSD.org>
>> CommitDate: 2023-02-27 13:28:07 +0000
>>
>> devel/aws-sdk-cpp: Update to 1.11.25
>> - fix TEST option that was wrongly set to ON and causing
>> build failures
>> on some 32bit archs.
>> - unbreak on mentioned archs
>
> Interesting. Does that mean the build will not work on 32bit archs if
> TEST is enabled?
>
> As the former maintainer of devel/aws-sdk-cpp I'm just curious.
>
> I didn't really try but if it's building on 32bit archs now the real
> reason might be this refactoring mentioned in the changelog for
> version 1.11.0
>
> https://github.com/aws/aws-sdk-cpp/blob/main/CHANGELOG.md#1110-2022-01-24
>
> The build would fail before because they generate huge unified cpp
> files (option ENABLE_UNITY_BUILD) that were making a single instance
> of the compiler to use more than 4GB of memory (more than 6GB actually
> on 64bit).
>
> Anyway, I'm glad you fixed it for 32 bit archs. Thanks :)
>
Just test on i386. The build failed with tests because there are tests
failing, not because the compiler is consuming too much memory.
I'd say those TEST_BROKEN could all be removed.
>> ChangeLog:
>> https://github.com/aws/aws-sdk-cpp/compare/1.11.10...1.11.25
>> PR: 269837
>> Reported by: John Hein <jcfyecrayz@liamekaens.com>
>> ---
>> devel/aws-sdk-cpp/Makefile | 13 ++++++-------
>> devel/aws-sdk-cpp/distinfo | 6 +++---
>> 2 files changed, 9 insertions(+), 10 deletions(-)
>>
>> diff --git a/devel/aws-sdk-cpp/Makefile b/devel/aws-sdk-cpp/Makefile
>> index 94de9263a751..608d138e75bb 100644
>> --- a/devel/aws-sdk-cpp/Makefile
>> +++ b/devel/aws-sdk-cpp/Makefile
>> @@ -1,5 +1,5 @@
>> PORTNAME= aws-sdk-cpp
>> -DISTVERSION= 1.11.10
>> +DISTVERSION= 1.11.25
>> CATEGORIES= devel
>> MAINTAINER= eduardo@FreeBSD.org
>> @@ -9,11 +9,6 @@ WWW= https://github.com/aws/aws-sdk-cpp
>> LICENSE= APACHE20
>> LICENSE_FILE= ${WRKSRC}/LICENSE
>> -BROKEN_armv6= fails to build: runaway process
>> -BROKEN_armv7= fails to build: runaway process
>> -BROKEN_i386= fails to build: compiler runs out of memory
>> -BROKEN_powerpc= fails to build: compiler runs out of memory
>> -
>> LIB_DEPENDS= libaws-c-auth.so:security/aws-c-auth \
>> libaws-c-cal.so:security/aws-c-cal \
>> libaws-c-common.so:devel/aws-c-common \
>> @@ -58,7 +53,11 @@ BUILD_ONLY?=
>> OPTIONS_DEFINE= TEST
>> OPTIONS_SUB= yes
>> -TEST_CMAKE_BOOL_OFF= ENABLE_TESTING
>> +TEST_CMAKE_BOOL= ENABLE_TESTING
>> +TEST_BROKEN_armv6= fails to build: runaway process
>> +TEST_BROKEN_armv7= fails to build: runaway process
>> +TEST_BROKEN_i386= fails to build: compiler runs out of memory
>> +TEST_BROKEN_powerpc= fails to build: compiler runs out of memory
>> pre-everything::
>> @${ECHO_MSG}
>> diff --git a/devel/aws-sdk-cpp/distinfo b/devel/aws-sdk-cpp/distinfo
>> index df6d21d967f7..2a639227971b 100644
>> --- a/devel/aws-sdk-cpp/distinfo
>> +++ b/devel/aws-sdk-cpp/distinfo
>> @@ -1,3 +1,3 @@
>> -TIMESTAMP = 1675456421
>> -SHA256 (aws-aws-sdk-cpp-1.11.10_GH0.tar.gz) =
>> e1370a57252147df35bd8860f35ad69548bb46077adf7524c2d1dd02ee8aa643
>> -SIZE (aws-aws-sdk-cpp-1.11.10_GH0.tar.gz) = 49752262
>> +TIMESTAMP = 1677440274
>> +SHA256 (aws-aws-sdk-cpp-1.11.25_GH0.tar.gz) =
>> 1103cf18516ca70d76c062af5a2b5c2418c5162235895baf3550a9f356d69f10
>> +SIZE (aws-aws-sdk-cpp-1.11.25_GH0.tar.gz) = 49938123