From nobody Tue Feb 21 11:06:45 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PLc1Q3HFbz3sCPs; Tue, 21 Feb 2023 11:06:50 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PLc1P5H68z424c; Tue, 21 Feb 2023 11:06:49 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) Authentication-Results: mx1.freebsd.org; none Received: (Authenticated sender: daniel.engberg@pyret.net) by mail.gandi.net (Postfix) with ESMTPA id EDFD1240004; Tue, 21 Feb 2023 11:06:45 +0000 (UTC) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Date: Tue, 21 Feb 2023 12:06:45 +0100 From: Daniel Engberg To: Po-Chuan Hsieh Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 23e0e7b1c30f - main - multimedia/mediainfo: Use all-in-one tarball In-Reply-To: References: <202301301306.30UD63Np053142@gitrepo.freebsd.org> Message-ID: <8ee5d9f1fb5230cf4e0eb4a00deb6c4b@FreeBSD.org> X-Sender: diizzy@FreeBSD.org Content-Type: multipart/alternative; boundary="=_b9121bd53bd356bf789f0b9c9d82e8f3" X-Rspamd-Queue-Id: 4PLc1P5H68z424c X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29169, ipnet:217.70.176.0/20, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --=_b9121bd53bd356bf789f0b9c9d82e8f3 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi, ...but it also says: "Quite often, software being ported uses the CR/LF convention in source files. This may cause problems with further patching, compiler warnings, or script execution (like /bin/sh^M not found.) To quickly convert all files from CR/LF to just LF, add this entry to the port Makefile" Best regards, Daniel On 2023-02-20 19:33, Po-Chuan Hsieh wrote: > On Sat, Feb 11, 2023 at 3:43 PM Daniel Engberg > wrote: > >> Hi, >> >> Porters Handbook (indirectly) recommends you to sanitize sources. >> https://docs.freebsd.org/en/books/porters-handbook/book/#slow-patch-automatic-replacements > > Do you mean the removal of USES=dos2unix? > This port does not install any text file but only 1 binary executable. > Therefore USES=dos2unix is unnecessary. > > I also checked that the generated bin/mediainfo are identical. > >> Best regards, >> Daniel >> >> On 2023-01-30 14:06, Po-Chuan Hsieh wrote: >>> The branch main has been updated by sunpoet: >>> >>> URL: >>> https://cgit.FreeBSD.org/ports/commit/?id=23e0e7b1c30fc6f86957a7428e51a5ea9c594291 >>> >>> commit 23e0e7b1c30fc6f86957a7428e51a5ea9c594291 >>> Author: Po-Chuan Hsieh >>> AuthorDate: 2023-01-30 12:27:47 +0000 >>> Commit: Po-Chuan Hsieh >>> CommitDate: 2023-01-30 12:59:06 +0000 >>> >>> multimedia/mediainfo: Use all-in-one tarball >>> >>> - Update WWW >>> - Remove unnecessary USES=dos2unix >>> --- >>> multimedia/mediainfo/Makefile | 20 +++++++++----------- >>> multimedia/mediainfo/distinfo | 6 +++--- >>> 2 files changed, 12 insertions(+), 14 deletions(-) >>> >>> diff --git a/multimedia/mediainfo/Makefile >>> b/multimedia/mediainfo/Makefile >>> index 5766752579b5..9b7c3737d89f 100644 >>> --- a/multimedia/mediainfo/Makefile >>> +++ b/multimedia/mediainfo/Makefile >>> @@ -1,13 +1,14 @@ >>> PORTNAME= mediainfo >>> -DISTVERSION= 22.12 >>> +PORTVERSION= 22.12 >>> CATEGORIES= multimedia >>> -MASTER_SITES= >>> https://mediaarea.net/download/source/${PORTNAME}/${DISTVERSION}/ [1] >>> \ >>> +MASTER_SITES= >>> https://mediaarea.net/download/binary/mediainfo/${PORTVERSION}/ [2] >>> \ >>> LOCAL/sunpoet >>> -DISTNAME= ${PORTNAME}_${DISTVERSION} >>> +DISTNAME= MediaInfo_CLI_${PORTVERSION}_GNU_FromSource >>> >>> MAINTAINER= sunpoet@FreeBSD.org >>> COMMENT= Provides technical and tag information for video and >>> audio >>> files >>> -WWW= https://mediaarea.net/en/MediaInfo >>> +WWW= https://mediaarea.net/en/MediaInfo \ >>> + https://github.com/MediaArea/MediaInfo >>> >>> LICENSE= BSD2CLAUSE >>> LICENSE_FILE= ${WRKSRC}/../../../License.html >>> @@ -15,17 +16,14 @@ LICENSE_FILE= ${WRKSRC}/../../../License.html >>> LIB_DEPENDS= libmediainfo.so:multimedia/libmediainfo \ >>> libzen.so:multimedia/libzen >>> >>> -USES= autoreconf compiler:c++11-lang cpe dos2unix >>> libtool pathfix \ >>> - pkgconfig tar:xz >>> +USES= compiler:c++11-lang cpe libtool pathfix >>> pkgconfig tar:xz >>> >>> GNU_CONFIGURE= yes >>> -USE_CXXSTD= c++11 >>> USE_LDCONFIG= yes >>> -CPE_VENDOR= mediaarea >>> -DOS2UNIX_GLOB= *.c *.cpp *.h >>> -DOS2UNIX_WRKSRC= ${WRKDIR} >>> >>> PLIST_FILES= bin/mediainfo >>> -WRKSRC= ${WRKDIR}/MediaInfo/Project/GNU/CLI >>> +WRKSRC= >>> ${WRKDIR}/MediaInfo_CLI_GNU_FromSource/MediaInfo/Project/GNU/CLI >>> + >>> +CPE_VENDOR= mediaarea >>> >>> .include >>> diff --git a/multimedia/mediainfo/distinfo >>> b/multimedia/mediainfo/distinfo >>> index 0d9caebdc92b..995778948454 100644 >>> --- a/multimedia/mediainfo/distinfo >>> +++ b/multimedia/mediainfo/distinfo >>> @@ -1,3 +1,3 @@ >>> -TIMESTAMP = 1672606752 >>> -SHA256 (mediainfo_22.12.tar.xz) = >>> 932b82739f738e7db603cf5bb170720731a9e7c61d145c2a54aabb3cd0b753bc >>> -SIZE (mediainfo_22.12.tar.xz) = 2026408 >>> +TIMESTAMP = 1674589524 >>> +SHA256 (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz) = >>> e67ce7419ec6af9fb54ffbe3164a42ae1cd874a7e559bfff017868cef1106947 >>> +SIZE (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz) = 3352944 Links: ------ [1] https://mediaarea.net/download/source/$%7BPORTNAME%7D/$%7BDISTVERSION%7D/ [2] https://mediaarea.net/download/binary/mediainfo/$%7BPORTVERSION%7D/ [3] http://bsd.port.mk --=_b9121bd53bd356bf789f0b9c9d82e8f3 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8

Hi,

...but it also says:

"Quite often, software being ported uses the CR/LF convention in source = files. This may cause problems with further patching, compiler warnings, or= script execution (like /bin/sh^M not found.) To quickly conve= rt all files from CR/LF to just LF, add this entry to the port Makefile"

Best regards,

Daniel

On 2023-02-20 19:33, Po-Chuan Hsieh wrote:

On Sat, Feb 11, 2023 at 3:43 PM Daniel Engberg <diizzy@freebsd.org>= ; wrote:
Hi,

Porters Han= dbook (indirectly) recommends you to sanitize sources.
https://docs.fre= ebsd.org/en/books/porters-handbook/book/#slow-patch-automatic-replacements<= /a>
 
Do you mean the removal of USES=3Ddos2unix?
This port does not install any text file but only 1 binary executable.=
Therefore USES=3Ddos2unix is unnecessary.
 
I also checked that the generated bin/mediainfo are identical.
 

Best regards,
D= aniel

On 2023-01-30 14:06, Po-Chuan Hsieh wrote:
> The b= ranch main has been updated by sunpoet:
>
> URL:
>= https:= //cgit.FreeBSD.org/ports/commit/?id=3D23e0e7b1c30fc6f86957a7428e51a5ea9c594= 291
>
> commit 23e0e7b1c30fc6f86957a7428e51a5ea9c59429= 1
> Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.o= rg>
> AuthorDate: 2023-01-30 12:27:47 +0000
> Commit:&nb= sp;    Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> Commi= tDate: 2023-01-30 12:59:06 +0000
>
>     mu= ltimedia/mediainfo: Use all-in-one tarball
>
>   = ;  - Update WWW
>     - Remove unnecessary USES= =3Ddos2unix
> ---
>  multimedia/mediainfo/Makefile | 2= 0 +++++++++-----------
>  multimedia/mediainfo/distinfo | = ; 6 +++---
>  2 files changed, 12 insertions(+), 14 deletions(= -)
>
> diff --git a/multimedia/mediainfo/Makefile
&g= t; b/multimedia/mediainfo/Makefile
> index 5766752579b5..9b7c3737d8= 9f 100644
> --- a/multimedia/mediainfo/Makefile
> +++ b/mul= timedia/mediainfo/Makefile
> @@ -1,13 +1,14 @@
>  PORT= NAME=3D    mediainfo
> -DISTVERSION=3D 22.12
> +P= ORTVERSION=3D 22.12
>  CATEGORIES=3D  multimedia
>= ; -MASTER_SITES=3D        https://mediaarea.net/download/source/${PORTNAM= E}/${DISTVERSION}/
> \
> +MASTER_SITES=3D    =     https://me= diaarea.net/download/binary/mediainfo/${PORTVERSION}/
> \
>               LOCAL/sunpoet> -DISTNAME=3D    ${PORTNAME}_${DISTVERSION}
> +DI= STNAME=3D    MediaInfo_CLI_${PORTVERSION}_GNU_FromSource
>= ;
>  MAINTAINER=3D  sunpoet@FreeBSD.org
>  = COMMENT=3D     Provides technical and tag information for vi= deo and audio
> files
> -WWW=3D       =  https://mediaarea.net/en/MediaInfo
> += WWW=3D         https://mediaarea= =2Enet/en/MediaInfo \
> +          &nb= sp;  https://github.com/MediaArea/MediaInfo<= br />>
>  LICENSE=3D     BSD2CLAUSE
&g= t;  LICENSE_FILE=3D        ${WRKSRC}/../../../Lice= nse.html
> @@ -15,17 +16,14 @@ LICENSE_FILE=3D     $= {WRKSRC}/../../../License.html
>  LIB_DEPENDS=3D libmediainfo.= so:multimedia/libmediainfo \
>          &n= bsp;    libzen.so:multimedia/libzen
>
> -USES=3D=                 autoreconf compiler= :c++11-lang cpe dos2unix libtool pathfix \
> -      =        pkgconfig tar:xz
> +USES=3D   =             compiler:c++11-lang cpe libtool = pathfix pkgconfig tar:xz
>
>  GNU_CONFIGURE=3D  =      yes
> -USE_CXXSTD=3D  c++11
> = ; USE_LDCONFIG=3D        yes
> -CPE_VENDOR=3D&n= bsp; mediaarea
> -DOS2UNIX_GLOB=3D       *.c *.= cpp *.h
> -DOS2UNIX_WRKSRC=3D     ${WRKDIR}
>= ;
>  PLIST_FILES=3D bin/mediainfo
> -WRKSRC=3D  =             ${WRKDIR}/MediaInfo/Project/GNU/C= LI
> +WRKSRC=3D              ${W= RKDIR}/MediaInfo_CLI_GNU_FromSource/MediaInfo/Project/GNU/CLI
> +> +CPE_VENDOR=3D  mediaarea
>
>  .include= <bsd.port.mk>
> diff --git a/multimedia/mediainfo/dist= info
> b/multimedia/mediainfo/distinfo
> index 0d9caebdc92= b..995778948454 100644
> --- a/multimedia/mediainfo/distinfo
&= gt; +++ b/multimedia/mediainfo/distinfo
> @@ -1,3 +1,3 @@
>= -TIMESTAMP =3D 1672606752
> -SHA256 (mediainfo_22.12.tar.xz) =3D> 932b82739f738e7db603cf5bb170720731a9e7c61d145c2a54aabb3cd0b753bc> -SIZE (mediainfo_22.12.tar.xz) =3D 2026408
> +TIMESTAMP = =3D 1674589524
> +SHA256 (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz= ) =3D
> e67ce7419ec6af9fb54ffbe3164a42ae1cd874a7e559bfff017868cef11= 06947
> +SIZE (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz) =3D 33529= 44


--=_b9121bd53bd356bf789f0b9c9d82e8f3--