From nobody Sun Feb 19 13:07:54 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PKQp25c3bz3r6wJ; Sun, 19 Feb 2023 13:07:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PKQp24s95z4RXC; Sun, 19 Feb 2023 13:07:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676812074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=90Ku+H6R/CQmggaSCC9WlQKPQ/SSEab01tgU0N2RWZ4=; b=hn4OdX1HTTUJ4XPsnXROZHMwBXbRpgFzU1lJ7Rli9A56P4p9RmwbfT9oNI4GaqSWrePsRS Y+Y0HaZP9ixcWQM9u7NLT3O9CgmafdrbFMqFPu/0C9lasLv1tZGK9GOqhd39IjWodij8b/ 1/DcIVpK7/d1Rc3AZrdsnsUKSuonyNHy5f0a+qRcJSHUMPKQ/6gY5L4pugGiM6gSnI6Czi mSTR/OA9D18wFJGqdsBas7hhHBLOf7P8j21KU4tDvqmoa67o5U2fJub16UQpmCWTitTpCe gfbTZpMG8WAOSDWDfkTyhh1HTP/unB+q1envtDVV8I+dAfD3wL33NGWaeosUkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676812074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=90Ku+H6R/CQmggaSCC9WlQKPQ/SSEab01tgU0N2RWZ4=; b=l1MxUxBzzLDSp90X24kL7wzZwq4S2n3IoNeSgNGJ+UXLArgauzmZM0hL+DSlZ1cKohRY+x t7/R1aFHK8v+iQwU4NhIcctF/0zceTFr+FLK4fMmTf8W2ioogw/UZ2BjMTlP1Ox6a/Vxg7 FkSrr27bwA1nPk6hoiXOAJ8s4Tqsw4PAVWnHhovdqu5IeNF5vKhem/+dFZhj0hfmEuFkE6 G/Qxl/yeWaLKZqDtiC846SM6483KndkMNhMXw+lfOwUFUVlzTdPzDA73vXCDD4qmI+lJhO zEFaDPCUQ0+k+39aL2EoGPbL0V6VRgLh0hTXXcCqyZsxXvPd273H6JGvRc5FUg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676812074; a=rsa-sha256; cv=none; b=xa64fkXMLIhD/DOoSUDZxTfVYzUHhZTYNhXx1N/HKm5YfYRg26NP2nmNA74aEk4yox+7Z7 PquVBeD64jVF7AdXBpiRPLuOuc6e6Mc1+IVk07Drw7QH6/vAC9Vyk851zjNYoo/E2ZGdIR 8flHLHQ5kgupvvCqHBkKNSXTS6huRXWfalIp+wKIvvy2411MpXueIagT9NebCviZ/I87r/ CqqWQMYrF5VoUr0p/9q+Wl2sBm214VSRdOY2uCL2+PZM7UP4KWXoJAFxcKc3Ud5KCIY9gx fuZiGn/jcxqb5cr4xMCD/ecr+hE2ssYw/gf68MbkP1BJd8Lcm2vpsyxc+RPFnQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PKQp23wdJz12s9; Sun, 19 Feb 2023 13:07:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 31JD7slm024997; Sun, 19 Feb 2023 13:07:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 31JD7sgs024996; Sun, 19 Feb 2023 13:07:54 GMT (envelope-from git) Date: Sun, 19 Feb 2023 13:07:54 GMT Message-Id: <202302191307.31JD7sgs024996@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Adriaan de Groot Subject: git: a46fb43e0e75 - main - math/readstat: fix build on 14-CURRENT List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adridg X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a46fb43e0e75b4099d7ea35b7072a3c2ca9362b1 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by adridg: URL: https://cgit.FreeBSD.org/ports/commit/?id=a46fb43e0e75b4099d7ea35b7072a3c2ca9362b1 commit a46fb43e0e75b4099d7ea35b7072a3c2ca9362b1 Author: Adriaan de Groot AuthorDate: 2023-02-19 13:02:54 +0000 Commit: Adriaan de Groot CommitDate: 2023-02-19 13:07:52 +0000 math/readstat: fix build on 14-CURRENT In 14-CURRENT, the system compiler is more strict; it looks like In file included from src/readstat_bits.c:9: src/readstat_bits.h:10:29: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] int machine_is_little_endian(); Apply the stricter flags in all builds, then fix the source so that the prototypes are explicitly (void) -- this is a subtlely of C semantics where (void) means "no arguments" and () means "arguments unspecified" that rarely matters. Except now. --- math/readstat/Makefile | 3 +++ math/readstat/files/patch-src_readstat__bits.h | 11 +++++++++++ math/readstat/files/patch-src_readstat__variable.c | 11 +++++++++++ math/readstat/files/patch-src_sas_ieee.c | 11 +++++++++++ math/readstat/files/patch-src_spss_readstat__por.h | 11 +++++++++++ 5 files changed, 47 insertions(+) diff --git a/math/readstat/Makefile b/math/readstat/Makefile index b42ad343b6a1..ed2be537b797 100644 --- a/math/readstat/Makefile +++ b/math/readstat/Makefile @@ -1,5 +1,6 @@ PORTNAME= readstat DISTVERSION= 1.1.8 +PORTREVISION= 1 CATEGORIES= math kde MASTER_SITES= https://github.com/WizardMac/ReadStat/releases/download/v${DISTVERSION}/ @@ -12,4 +13,6 @@ LICENSE= MIT USES= libtool HAS_CONFIGURE= yes +CFLAGS+= -Werror -Wstrict-prototypes + .include diff --git a/math/readstat/files/patch-src_readstat__bits.h b/math/readstat/files/patch-src_readstat__bits.h new file mode 100644 index 000000000000..83dde0c07762 --- /dev/null +++ b/math/readstat/files/patch-src_readstat__bits.h @@ -0,0 +1,11 @@ +--- src/readstat_bits.h.orig 2023-02-19 12:35:46 UTC ++++ src/readstat_bits.h +@@ -7,7 +7,7 @@ + #undef READSTAT_MACHINE_IS_TWOS_COMPLEMENT + #define READSTAT_MACHINE_IS_TWOS_COMPLEMENT 0 + +-int machine_is_little_endian(); ++int machine_is_little_endian(void); + + char ones_to_twos_complement1(char num); + int16_t ones_to_twos_complement2(int16_t num); diff --git a/math/readstat/files/patch-src_readstat__variable.c b/math/readstat/files/patch-src_readstat__variable.c new file mode 100644 index 000000000000..699c88937a9e --- /dev/null +++ b/math/readstat/files/patch-src_readstat__variable.c @@ -0,0 +1,11 @@ +--- src/readstat_variable.c.orig 2023-02-19 12:39:09 UTC ++++ src/readstat_variable.c +@@ -2,7 +2,7 @@ + #include + #include "readstat.h" + +-static readstat_value_t make_blank_value(); ++static readstat_value_t make_blank_value(void); + static readstat_value_t make_double_value(double dval); + + static readstat_value_t make_blank_value() { diff --git a/math/readstat/files/patch-src_sas_ieee.c b/math/readstat/files/patch-src_sas_ieee.c new file mode 100644 index 000000000000..beab46c1713d --- /dev/null +++ b/math/readstat/files/patch-src_sas_ieee.c @@ -0,0 +1,11 @@ +--- src/sas/ieee.c.orig 2023-02-19 12:37:34 UTC ++++ src/sas/ieee.c +@@ -16,7 +16,7 @@ static void ieee2xpt(unsigned char *ieee, unsigned cha + + #ifndef FLOATREP + #define FLOATREP get_native() +-int get_native(); ++int get_native(void); + #endif + + void memreverse(void *intp_void, int l) { diff --git a/math/readstat/files/patch-src_spss_readstat__por.h b/math/readstat/files/patch-src_spss_readstat__por.h new file mode 100644 index 000000000000..7649ac223461 --- /dev/null +++ b/math/readstat/files/patch-src_spss_readstat__por.h @@ -0,0 +1,11 @@ +--- src/spss/readstat_por.h.orig 2023-02-19 12:38:04 UTC ++++ src/spss/readstat_por.h +@@ -31,7 +31,7 @@ typedef struct por_ctx_s { + ck_hash_table_t *var_dict; + } por_ctx_t; + +-por_ctx_t *por_ctx_init(); ++por_ctx_t *por_ctx_init(void); + void por_ctx_free(por_ctx_t *ctx); + ssize_t por_utf8_encode(const unsigned char *input, size_t input_len, + char *output, size_t output_len, uint16_t lookup[256]);