Re: git: 57a30ab234a9 - main - net/tcpview: Fix build with LLVM15

From: Cy Schubert <Cy.Schubert_at_cschubert.com>
Date: Wed, 15 Feb 2023 04:39:16 UTC
In message <Y+xe7dWF724URxsK@FreeBSD.org>, Alexey Dokuchaev writes:
> On Sat, Feb 11, 2023 at 07:38:39PM -0800, Cy Schubert wrote:
> > ...
> > The exact error, due to -Wint-conversion now being the default in LLVM15 --
> > https://reviews.llvm.org/D129881.
> > 
> > detail-domain.c:449:13: error: incompatible pointer to integer conversion r
> eturning 'void *' from a function with result type 'int' [-Wint-conversion]
> >             return NULL;
> >                    ^~~~
>
> So why not fix the broken code rather than suppress the useful warning?
> New strict Clang already revealed several real bugs in various ports,
> thus I encourage everyone not to silence the compiler, but examine and
> address the actual problem with the code.

This is a medium-term goal ATM. A number of nasty kerberos bugs have taken 
precidence.

>
> > Previously there would have been an exp-run prior to a new LLVM import
> > allowing for better planning and staging than the current react mode.
>
> There was an exp-run (PR 265425), but apparently dim@ concentrated on
> trying to fix relatively high-profile ports which unblock N [other]
> ports, so many affected leaf ports got under his radar.

There's a lot of stuff going on here. I may have missed that.

>
> ./danfe


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy@nwtime.org>    Web:  https://nwtime.org

			e^(i*pi)+1=0