Re: git: ce282f9818c3 - main - mail/nbsmtp: Does not build with clang 15
Date: Tue, 14 Feb 2023 09:44:17 UTC
On Tue, Feb 14, 2023 at 10:16:26AM +0100, Emanuel Haupt wrote:
> Alexey Dokuchaev <danfe@freebsd.org> wrote:
> > On Mon, Feb 13, 2023 at 02:20:35PM +0000, Emanuel Haupt wrote:
> > > commit ce282f9818c344616ad9e3df29d01dab55acf8b2
> > >
> > > mail/nbsmtp: Does not build with clang 15
> > >
> > > +.include <bsd.port.pre.mk>
> > > +
> > > +.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1400079
> > > +USE_GCC= yes
> > > +.endif
> >
> > Why not just fix the code instead of pulling whole another compiler
> > suite? Looks like it bogusly assigns (char)NULL instead of '\0' in
> > several places (unless, of course, there are other, more complicated
> > errors, but commit log does not mention anything specific).
>
> I'll have a list of ports that fail. My main priority is to unbreak the
> ports on main and have working packages again. Fixing the the code to
> build with clang 15 is a midterm priority.
Clang 15 simply revealed the problem with the code, easily fixable.
By falling back to GCC you'd rage your users and merely postpone the
solution until GCC would become more strict and start complaining
just as Clang did just now. Fixing this particular bug would take
less time than calculating the 1400079 values for OSVERSION above. :-)
./danfe