Re: git: 9ba756b0e950 - main - graphics/gdal-grass: Fix PORTVERSION going backwords

From: Po-Chuan Hsieh <sunpoet_at_freebsd.org>
Date: Sun, 05 Feb 2023 07:51:45 UTC
On Tue, Jan 31, 2023 at 8:56 PM Muhammad Moinur Rahman <bofh@freebsd.org>
wrote:

> The branch main has been updated by bofh:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=9ba756b0e950d76c63a291797407abd9972d1eb2
>
> commit 9ba756b0e950d76c63a291797407abd9972d1eb2
> Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
> AuthorDate: 2023-01-31 12:55:14 +0000
> Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
> CommitDate: 2023-01-31 12:56:47 +0000
>
>     graphics/gdal-grass: Fix PORTVERSION going backwords
>
>     This port was resurrected with an older version than it was in the tree
>     while removal. Hence it requires PORTEPOCH.
>

Thanks for your help but the fix is incorrect.
It is unreasonable to add PORTEPOCH when the previous one was removed over
7 years ago (Nov 1, 2015) [1].
No one would be affected with this version.

The PORTVERSION check is great.
It helps people to keep ports/pkg up-to-date (from one *installed* version
to another).
IMHO, the correct fix is to clean up the version db regularly.
We could expire removed ports after a period of time.

Thanks.

[1]
https://cgit.freebsd.org/ports/commit/?id=5e1001eeb3e8c92ec3453e2cee94a870ee99ed86


>     Approved by:    portmgr (just-fix-it)
> ---
>  graphics/gdal-grass/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/graphics/gdal-grass/Makefile b/graphics/gdal-grass/Makefile
> index cdb9ff57bb33..fc09da52da9c 100644
> --- a/graphics/gdal-grass/Makefile
> +++ b/graphics/gdal-grass/Makefile
> @@ -1,5 +1,6 @@
>  PORTNAME=      gdal-grass
>  PORTVERSION=   1.0.2
> +PORTEPOCH=     1
>  CATEGORIES=    graphics
>
>  MAINTAINER=    sunpoet@FreeBSD.org
>
>