Re: git: e41e27b19194 - main - www/caddy: Pin Go version to 1.19

On Fri, Feb 3, 2023 at 2:51 PM Dmitri Goutnik <dmgk@freebsd.org> wrote:

> The branch main has been updated by dmgk:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=e41e27b19194be93c1bad06a10dafc9211264960
>
> commit e41e27b19194be93c1bad06a10dafc9211264960
> Author:     Dmitri Goutnik <dmgk@FreeBSD.org>
> AuthorDate: 2023-02-03 15:55:51 +0000
> Commit:     Dmitri Goutnik <dmgk@FreeBSD.org>
> CommitDate: 2023-02-03 18:09:08 +0000
>
>     www/caddy: Pin Go version to 1.19
>
>     vendor/github.com/lucas-clemente/quic-go/internal/qtls/go120.go:5:13:
> cannot use "The version of quic-go you're using can't be built on Go 1.20
> yet.
>
>     quic-go doesn't support go1.20 yet, keep building this port with go1.19
>     for now.
>
>     PR:             269289
>     Reported by:    exp-run
> ---
>  www/caddy/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/caddy/Makefile b/www/caddy/Makefile
> index 433acbb98efa..549ce5311644 100644
> --- a/www/caddy/Makefile
> +++ b/www/caddy/Makefile
> @@ -12,7 +12,7 @@ WWW=          https://caddyserver.com
>  LICENSE=       APACHE20
>  LICENSE_FILE=  ${WRKSRC}/LICENSE
>
> -USES=          cpe go:modules
> +USES=          cpe go:1.19,modules
>  CPE_VENDOR=    caddyserver
>
>  USE_RC_SUBR=   caddy
>

Thanks for doing this! In the past I've manually recreated GH_TUPLE (> 110
modules) every time Go gets a minor bump, but pinning Go until the next
caddy release looks like a much better option.

For anyone playing at home, some subtle path-handling semantics changed in
go1.20, so it's not as simple as just bumping the quic-go dep this time.
The PR is https://github.com/caddyserver/caddy/pull/5353.

# Adam


-- 
Adam Weinberger
adamw@adamw.org
https://www.adamw.org