Re: git: 70d1f3fc4b3d - main - net-im/telegram-desktop: update 4.5.3 -> 4.6.0
Date: Sat, 04 Feb 2023 14:03:23 UTC
On Sat, Feb 04, 2023 at 02:14:03AM +0000, Sergey A. Osokin wrote: > commit 70d1f3fc4b3df639b8f7520636b836222d242399 > > net-im/telegram-desktop: update 4.5.3 -> 4.6.0 Thanks! One minor observation/question... > -.include <bsd.port.pre.mk> > +.include <bsd.port.options.mk> > > -.if ${COMPILER_VERSION} < 130 > -LLVM_VER= 13 > -BUILD_DEPENDS+= clang${LLVM_VER}:devel/llvm${LLVM_VER} > -CC= ${LOCALBASE}/bin/clang${LLVM_VER} > -CXX= ${LOCALBASE}/bin/clang++${LLVM_VER} > +.if ${OSVERSION} > 1400000 > +USES+= llvm:build > +CC= ${_LLVM_MK_PREFIX}/bin/clang > +CPP= ${_LLVM_MK_PREFIX}/bin/clang-cpp > +CXX= ${_LLVM_MK_PREFIX}/bin/clang++ Leading underscore suggests _LLVM_MK_PREFIX is private, exported version is LLVM_PREFIX, why wasn't it used here instead? ./danfe