Re: git: 8607332fb826 - main - www/gitlab-pages: Fix bulk build warning

> On Feb 3, 2023, at 10:12 AM, Mathieu Arnold <mat@FreeBSD.org> wrote:
> 
> On Thu, Feb 02, 2023 at 11:04:12PM +0000, Muhammad Moinur Rahman wrote:
>> The branch main has been updated by bofh:
>> 
>> URL: https://cgit.FreeBSD.org/ports/commit/?id=8607332fb8268becd08f7e6cfbc853bc76e2cc43
>> 
>> commit 8607332fb8268becd08f7e6cfbc853bc76e2cc43
>> Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
>> AuthorDate: 2023-02-02 23:01:36 +0000
>> Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
>> CommitDate: 2023-02-02 23:01:36 +0000
>> 
>>    www/gitlab-pages: Fix bulk build warning
>> 
>>    In the previous commit a duplicate USE_FETCH target was added similar to
>>    the one in Mk/Uses/go.mk. However this is possible using a different
>>    number and target name compared to what is already predefined as it
>>    conflicts.
> 
> I fail to see the functional difference between this target and the
> existing one in USES=go, and it feels that now, the fetch is done twice,
> once in USES=go and once here.
I didn't say that it solves the actual problem entirely but it at least fixes the
warning in the bulk build.

> Can you try to see if it still works without this target here?
I am not an expert in the gitlab stuffs done in the ports tree.

Looping in mfechner@ who made the original commit.


>>    Reported by:    bulk build
>>    Approved by:    portmgr (just-fix-it)
>> ---
>> www/gitlab-pages/Makefile | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>> 
>> diff --git a/www/gitlab-pages/Makefile b/www/gitlab-pages/Makefile
>> index 9a97306037d6..da241eeec460 100644
>> --- a/www/gitlab-pages/Makefile
>> +++ b/www/gitlab-pages/Makefile
>> @@ -1,5 +1,6 @@
>> PORTNAME=	gitlab-pages
>> PORTVERSION=	15.8.1
>> +PORTREVISION=	1
>> DISTVERSIONPREFIX=	v
>> CATEGORIES=	www
>> 
>> @@ -29,8 +30,8 @@ MASTER_SITES+=	https://gitlab.com/gitlab-org/gitlab-pages/-/raw/v${DISTVERSION}/
>> DISTFILES+=	go.mod
>> DIST_SUBDIR=	go/${PKGORIGIN:S,/,_,g}/${DISTNAME}
>> EXTRACT_ONLY+=	${DISTFILES:N*.mod\:*:N*.mod:C/:.*//}
>> -_USES_fetch+=	800:go-post-fetch
>> -go-post-fetch:
>> +_USES_fetch+=	900:go-post-fetch-gitlab
>> +go-post-fetch-gitlab:
>> 	@${ECHO_MSG} "===> Fetching ${PORTNAME} dependencies";
>> 	@(cd ${DISTDIR}/${DIST_SUBDIR}; \
>> 		[ -e go.mod ] || ${RLN} ${GO_MODFILE} go.mod; \
>> 
> 
> --
> Mathieu Arnold