Re: git: 5fa10f90532b - main - graphics/libsvgtiny: Mark MAKE_JOBS_UNSAFE

Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Sat, Dec 30, 2023 at 10:33:17AM +0000, Emanuel Haupt wrote:
> > commit 5fa10f90532b8707765e683c13de0d29ec26a3ee
> > 
> >   graphics/libsvgtiny: Mark MAKE_JOBS_UNSAFE
> > 
> >   Mark the port as MAKE_JOBS_UNSAFE due to continuous pkg-fallout
> > emails, even though build failures are not reproducible in various
> >   environments, including those with and without parallel make jobs.
> 
> It's quite obvious from the build log what's going on and easily
> reproducible, just insert "sleep 5" in the autogenerated_colors.c
> recipe.  The fix is also straightforward, you need to tell make(1)
> that svgtiny.c depends on autogenerated_colors.c (#include's it):
> 
> --- src/Makefile.orig   2023-12-27 21:45:54 UTC
> +++ src/Makefile
> @@ -3,7 +3,10 @@ DIR_SOURCES := svgtiny.c svgtiny_gradient.c
> svgtiny_li
> 
>  SOURCES := $(SOURCES)
> 
> +src/svgtiny.c: $(DIR)autogenerated_colors.c
> +
>  $(DIR)autogenerated_colors.c: src/colors.gperf
> +       sleep 5
>         $(VQ)$(ECHO) "   GPERF: $<"
>         $(Q)gperf --output-file=$@.tmp $<
> 
> ./danfe
> 

Beautiful!

Committed, thank you!