Re: git: e4b7e0154f5e - main - Mk/bsd.options.desc.mk: Expand ASLR
Date: Sat, 23 Dec 2023 07:54:41 UTC
On Fri, Dec 22, 2023 at 11:44:57PM +0000, Muhammad Moinur Rahman wrote: > diff --git a/Mk/bsd.options.desc.mk b/Mk/bsd.options.desc.mk > index d20740cc888a..f877b04dd8d4 100644 > --- a/Mk/bsd.options.desc.mk > +++ b/Mk/bsd.options.desc.mk > @@ -30,7 +30,7 @@ APE_DESC?= Monkey's Audio lossless format support > ARCHIVE_DESC?= bzip2/zip/iso9660 archive support > ARMADILLO_DESC?= TPS transform computation via Armadillo > ASIO_DESC?= Asynchronous I/O support > -ASLR_DESC?= Enable ASLR support > +ASLR_DESC?= Enable Address Space Layout Randomization support > ASM_DESC?= Use optimized assembly code > ASPELL_DESC?= Spell checking support via GNU Aspell > ASSERT_DESC?= Enable debug assertions To be a bit pedantic, it still means little to the user, does it mean it will build stuff with the random bits, or that it adds random bits to stuff when running... The option has to describe what will change if enabled, all the options that have description saying "enable foo support" are quite useless, of course enabling option foo will enable foo in some way, the important information is what it actually does. In this short diff hunk, the only options with meaningfull descriptions are ARMADILLO and ASPELL. ASM is somewhat ok even if a bit too generic. All other are almost useless, they are very generic and mean very little in any port. -- Mathieu Arnold