From nobody Thu Aug 17 10:34:52 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RRLwr6xhJz4qWDr; Thu, 17 Aug 2023 10:34:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RRLwr6KBMz4S71; Thu, 17 Aug 2023 10:34:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692268492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=m65kskGQ9EUD6JAQ0YSO+8Txwlf5x/1kmFNQwH/CePo=; b=YcV55/J/sX6zQnNo3AcPmWiETqRR/ytdjTlkgNTYtjHlcvKgeqlVlPN0/80xyuE17raw4o qW3iNCy4V6u7kHn9Q3C1k/rGWki6ATPpxD8wMD0HV6kjmKZiVR2KuwLCW2ZAiRxZwgdb7e XZYA3KTNcXbGWRSUuReW122GsP/nloXeFweMuU9ZUtdvFgl38cWUZEDLS3/5lr6W2E4omK 9i4oSP9LPGy6/O+N3Hp9NkO82NTbAU9MXbhNIYTWX4aQjDODR7WnW3PrvlMBSjXFhfkFwA IxmUNXXPs0hHGe4tqnm8y7saCy054JTiJDNl/+QTid1PGothyPqKOQQtU9B7zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692268492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=m65kskGQ9EUD6JAQ0YSO+8Txwlf5x/1kmFNQwH/CePo=; b=Tixiaiyd9ti8wg03TyzPYlvYYMyEfNDd9M7bTreJYBuGf5xxg9715gdW44m17XB4j6RW1/ UihpGG14R15PFNlLMns0LnczT5shvHotKT7sWp7UvapTVq5lVEJZahqxmwHl6ci+/Ae340 0DCUofysLEt/8PAOf9I1lWV1VMgh+eNrNPAf2Zrcz9q7IC1u5xbbLdGgbKWJ37utG2Ebaz c3dzbJsFIpTFAl3c0wmWq7i+usq661uvpHVYoJ1p8lvY1QRIFf8tb16y/aT+3fli0GqVAf PMqoIRXYni5vTeK4dzcEbQIqjWcvAZzsZH90v+LuikUaKMOyu3piRcXETsP76w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692268492; a=rsa-sha256; cv=none; b=aLfbVKKV36FiVXO+3gq1VJb/5pKpz6VAsgguVv5zYLluNOVBCFaIAkdMXLDhXsbKlRzjP2 FZqnxIxJ5gsBdWrKmGqqqAXOwTQzK5wgVtxy4Gf5jBBy/qWvKMTrQkDes35a8LwILkWXx5 vlspypBLyMHCGPlMfjCb3FWXEOXJOn0sC471djRB36bLy/HOfEPDrPs9TMrrB0FPHwPiFJ 3jffoOi26wwcmX3/EaA5c/SSGpxRjdOmWgZOtqrpGyxB6aYVT68/Lxlcbs3D/7rq3meDKi RIYh5HViqWm2P7wh0D67RulIe4Zd9gn69S792EXn2MrNH89gbBJchwf8CX7fyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RRLwr580qzWj0; Thu, 17 Aug 2023 10:34:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 37HAYq8j046310; Thu, 17 Aug 2023 10:34:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 37HAYqiB046307; Thu, 17 Aug 2023 10:34:52 GMT (envelope-from git) Date: Thu, 17 Aug 2023 10:34:52 GMT Message-Id: <202308171034.37HAYqiB046307@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-branches@FreeBSD.org From: Kai Knoblich Subject: git: 6ee34b44b28c - 2023Q3 - www/qt5-webengine: Remove unnecessary ulimit calls List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kai X-Git-Repository: ports X-Git-Refname: refs/heads/2023Q3 X-Git-Reftype: branch X-Git-Commit: 6ee34b44b28c4a593e334f5f21c1d28f372c24b6 Auto-Submitted: auto-generated The branch 2023Q3 has been updated by kai: URL: https://cgit.FreeBSD.org/ports/commit/?id=6ee34b44b28c4a593e334f5f21c1d28f372c24b6 commit 6ee34b44b28c4a593e334f5f21c1d28f372c24b6 Author: John Hein AuthorDate: 2023-08-17 10:21:16 +0000 Commit: Kai Knoblich CommitDate: 2023-08-17 10:33:35 +0000 www/qt5-webengine: Remove unnecessary ulimit calls Before linking, which is far at the end of the long building process, the ulimit is tried to be set to 4096. If this fails, it will cause the whole linking process to abort and thus lead to a failed build, which is the case when qt5-webengine is build with a non-root user in a Poudriere jail. The problem could be probably solved by substituting "&&" with ";" in the affected lines, but in the course of bug 270041 it has become apparent that an ulimit of 1024, which is poudriere's default, is sufficient. [1] This could also be successfully verified with qt5-webengine builds (with either ALSA/PULSEAUDIO/SNDIO enabled and DEBUG set/unset) in non-root poudriere jail hence remove the ulimit calls to fix the problem. PR: 270041 Reported by: Tomoaki AOKI, John Hein [1] MFH: 2023Q3 With hat: kde (cherry picked from commit 2f01d32332494380dc4971717d2757415dcbd27e) --- www/qt5-webengine/files/patch-src_core_core__module.pro | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/www/qt5-webengine/files/patch-src_core_core__module.pro b/www/qt5-webengine/files/patch-src_core_core__module.pro index 3c6330bb2323..9251779d895e 100644 --- a/www/qt5-webengine/files/patch-src_core_core__module.pro +++ b/www/qt5-webengine/files/patch-src_core_core__module.pro @@ -1,11 +1,19 @@ +No need to limit max open file descriptors. +See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270041 + --- src/core/core_module.pro.orig 2021-12-15 16:12:54 UTC +++ src/core/core_module.pro -@@ -41,7 +41,7 @@ CONFIG -= bsymbolic_functions +@@ -41,10 +41,10 @@ QMAKE_INFO_PLIST = Info_mac.plist # and doesn't let Chromium get access to libc symbols through dlsym. CONFIG -= bsymbolic_functions -linux { +unix { !ccache:!use_gold_linker:!use_lld_linker { - QMAKE_LINK="ulimit -n 4096 && $$QMAKE_LINK" - QMAKE_LINK_SHLIB="ulimit -n 4096 && $$QMAKE_LINK_SHLIB" +- QMAKE_LINK="ulimit -n 4096 && $$QMAKE_LINK" +- QMAKE_LINK_SHLIB="ulimit -n 4096 && $$QMAKE_LINK_SHLIB" ++ QMAKE_LINK="$$QMAKE_LINK" ++ QMAKE_LINK_SHLIB="$$QMAKE_LINK_SHLIB" + } + qtConfig(separate_debug_info): QMAKE_POST_LINK="cd $(DESTDIR) && $(STRIP) --strip-unneeded $(TARGET)" + }