From nobody Wed Apr 12 15:41:14 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PxRl22Q0Sz44ySs; Wed, 12 Apr 2023 15:41:18 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PxRl21vTJz3qJ7; Wed, 12 Apr 2023 15:41:18 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681314078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ntTUtk0DsI8jXBuK9dHz99fra9X3cg8W1/EgpZU4Il4=; b=tdRlS2Tn7EIL3rBfSpfQ0J4fO4hIt+d6fj/MiV162xHKIRHuQ6PklYWYdZC6BChLGjSzPY UpK/zj3ydOPePmOti6irabqELTDEzeaw4ysBh+Yt4PYJvjJ/xj1iMh+olQ6JGuFlk9bV0g g89ztzxMfdKK2o+5LV4TZmmy0ecR/LXOrdmxWIE4KDJljv9PfQGEM/6UcZlHZkTFU5nFek ++JXGWcMsCHj26NsC5xZgBBfRGGFDp+JknBkV8xHEqtvzc4n6wJT0pdyAb3GyjKYy5cuiH wBb+M/+XMy0djuDMvXrVEIpF2otyOuL1V58qznmfWWBOwo6sIEKPv4Ff808riA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681314078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ntTUtk0DsI8jXBuK9dHz99fra9X3cg8W1/EgpZU4Il4=; b=v2YY7TnEwckC5uE0/LnLF6/pdB1rD5Z8NJrJOHLrdSU11L9kg/fUS+kw542oUjHi+Pe5vH xaL3zAlImjhor4oo3QsqOtJSIRENRlfi66Ry9EQQari4nAu1FJmwHPJgudIaeB5//500gt 0B9VOMboU8J4/rROgVCNjj34s9dFQoIZQw9WVLzYS0X06Fj5G8tVHjTMlj0r7E3VWr5Z1+ VHdmC26/w5XeAOLfUtu4A3z3GxOmRGf1Ns9ZdT79GPd/BWp6cCerwh/bvhKiGYlv9NKff+ 9YDsGTBP4Bnx2pUL3jIvrbzZ8GIHDwudadj429X+1GPgPFANM79diktsVjhwRA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681314078; a=rsa-sha256; cv=none; b=rylxjeTt03B0y6FVtL31BDkbVuIDbKXJSG656FBe1jxhjHv9I2i2UNJf/Yvk0XiQDl+03l F50CXNgUKq0zG6tftgunymlM6DwXaN09B+7mk7RQmPcgcRvAjxTBjNOBYSiSQdhGiHb39l EYdGpBFU6adXZYxaxKIdgon7EcnIVyVRP7QypIZ0892dBsTvMT5O6//bIDldEECNDo/9bU aYIolM/uFQsJKf/dIS7oWGFjseEuCjEwg9hNW9x530pL/jSau8k/73zsDIOof0vP1XTy55 FxTYqQ4bDfILMm++lGB10OE+IowDvrCzljCjPIU9KLRLr5L/RSzkW7bm0rTnsA== Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.j.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PxRl208g4zGF3; Wed, 12 Apr 2023 15:41:18 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:e0a:836:f670:a10a:6fbb:f579:4c1e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 5EDB4942D80; Wed, 12 Apr 2023 15:41:15 +0000 (UTC) Date: Wed, 12 Apr 2023 17:41:14 +0200 From: Mathieu Arnold To: Alexey Dokuchaev Cc: Muhammad Moinur Rahman , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c89b6f279989 - main - lang/php8[12]: Fix build on aarch64 with ZTS Message-ID: References: <202304120539.33C5dOJA014331@gitrepo.freebsd.org> <6inj2unwo45zfdu65na77yeob7pteqy62gdrxganabcagk3pjc@tvkxg2g773o3> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xctndhbry7x5kehy" Content-Disposition: inline In-Reply-To: X-ThisMailContainsUnwantedMimeParts: N --xctndhbry7x5kehy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 12, 2023 at 02:21:40PM +0000, Alexey Dokuchaev wrote: > On Wed, Apr 12, 2023 at 03:55:00PM +0200, Mathieu Arnold wrote: > > On Wed, Apr 12, 2023 at 01:43:43PM +0000, Alexey Dokuchaev wrote: > > > On Wed, Apr 12, 2023 at 05:39:24AM +0000, Muhammad Moinur Rahman wrot= e: > > > > commit c89b6f2799891129e89d1b4fedf8e25865241060 > > > >=20 > > > > lang/php8[12]: Fix build on aarch64 with ZTS > > > >=20 > > > > - Refresh patches > > >=20 > > > What good did it bring other than cloaking the actual fix with tons > > > of needless, unrelated changes? You've poured a glass of honey into > > > a bucket of tar. :( > >=20 > > Because that is something you have to do everytime a port is updated, >=20 > No, you don't, and you shouldn't. Patches come and go all the time, > blindly following this "rule" just brings useless noise to the commit > diff, nothing else. >=20 > > refresh the patches so that the line offsets are correct wrt current > > sources, to make sure patch(1) can just apply the patches and not > > resort to guesswork. >=20 > If patch(1) cannot apply some patch, it will complain and the port > won't build, so existing patches are applicable by definition. >=20 > But we have already argued about this in the past. I prefer cleaner > commit diffs, you don't, oh well. I don't care about the commit diff of patches, really, patches of patches are mostly unreadable. On the other hand, we, as a group, care about patches that are correct, not patches that happen to apply, maybe at the correct place, by the grace of some random heuristic in patch(1). Please stop badgering committers about rules you decided on your own and that only apply for you. I would also add something along the lines of "please follow our policies" but we both know you will not. --=20 Mathieu Arnold --xctndhbry7x5kehy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmQ20RlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb5PWQv/a3xIAxkjHJntmKoOoJmytPduLUsx2O/hQ3GT67rmD+fPWuYIEwYG5cOW tJrLxppNitKMDpgSp/w3KgxoBxU2/3PiskxM/NX4QNidvjRf+eEr/KlmmNUivo0Z Lp8RWpCMDhwgi6y4fWkOmVoPx8rM123W11Gy9pKU2mZasrG9FiPOOVGXCHlPcThl rV4IVzGFvlhb1cs1PxPXSrfrHYqvxwQ9KVLWOSikhUr0Xh3tMiPczPWQbrRS4/Xl aRrPQd/v06tF11aniZOHMJxX+WZ+/pR9Uk5Fj5q3XZfzJKWCg7Qtbjd8F6gKZmFl c4VNVLfDEjmAEOxYANuADNuwvqoyOwig/E3hSuj7qRK2weI3ByuMqcrJSi1f5cmT mfyrHmlQF9jZR8ZhviHLm5T2jm2IjiD1tOuHfThHcVfGyinDYxCpe017Y2ycxBzV wRnsUU27EYKAPuZybPpK31y8SXrrdDCV2hl4vQlQZjF2y1q3EyOAf8krpyr248Lz qXGpm88l =6l/w -----END PGP SIGNATURE----- --xctndhbry7x5kehy--