Re: git: a29e9ae256a5 - main - security/picocrypt: Update i386 broken reason message

Hey Piotr,

I've opted for a 64-bit whitelist because it is shorter than blacklist.
Hope that is correct.
https://cgit.freebsd.org/ports/commit/?id=860ce9aee61aacd34f0b1c29d54f44dd86168835

Thanks for heads up!

Cheers,

Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia domingo, 25/09/2022 à(s)
23:17:

> On 22-09-25 23:11:21, Nuno Teixeira wrote:
> > Hi Piotr,
> >
> > Yes you are right.
> > Maybe only mention 64-bit archs?
> >
> > ONLY_FOR_ARCHS= amd64 arm64 mips64 powerpc64 sparc64?
> There's also powerpc64le and riscv64.
> >
> > Is there better way to mention only 32 or 64 bit?
> I don't think ports tree allows it, you can either whitelist all the
> 64-bit architectures or blacklist the 32-bit ones.
> >
> > Thanks
> >
> >
> >
> > Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia domingo, 25/09/2022
> à(s)
> > 22:15:
> >
> > > Why not disable on other 32-bit architectures?
> > >
> > > On 22-09-25 21:14:08, Nuno Teixeira wrote:
> > > > The branch main has been updated by eduardo:
> > > >
> > > > URL:
> > >
> https://cgit.FreeBSD.org/ports/commit/?id=a29e9ae256a5ce7825e798b6701a1803a6ee4e76
> > > >
> > > > commit a29e9ae256a5ce7825e798b6701a1803a6ee4e76
> > > > Author:     Nuno Teixeira <eduardo@FreeBSD.org>
> > > > AuthorDate: 2022-09-25 21:12:24 +0000
> > > > Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
> > > > CommitDate: 2022-09-25 21:12:24 +0000
> > > >
> > > >     security/picocrypt: Update i386 broken reason message
> > > > ---
> > > >  security/picocrypt/Makefile | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/security/picocrypt/Makefile
> b/security/picocrypt/Makefile
> > > > index 153ec8b94189..94881c7797bc 100644
> > > > --- a/security/picocrypt/Makefile
> > > > +++ b/security/picocrypt/Makefile
> > > > @@ -10,8 +10,8 @@ LICENSE=    GPLv3
> > > >  LICENSE_FILE=        ${WRKSRC}/../LICENSE
> > > >
> > > >  NOT_FOR_ARCHS=       i386
> > > > -NOT_FOR_ARCHS_REASON=        Picocrypt.go:53:11: cannot use 1 << 40
> > > (untyped int constant 1099511627776) as int value in variable
> declaration
> > > (overflows) \
> > > > -
> > > https://github.com/HACKERALERT/Picocrypt/issues/127
> > > > +NOT_FOR_ARCHS_REASON=        upstream only supports 64-bit
> > > > +# https://github.com/HACKERALERT/Picocrypt/issues/127
> > > >
> > > >  LIB_DEPENDS= libharfbuzz.so:print/harfbuzz
> > > >
> > >
> >
> >
> > --
> > Nuno Teixeira
> > FreeBSD Committer (ports)
>


-- 
Nuno Teixeira
FreeBSD Committer (ports)