From nobody Fri Oct 14 19:38:44 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MpxXP6mY3z4f8Dv for ; Fri, 14 Oct 2022 19:39:01 +0000 (UTC) (envelope-from adamw@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MpxXP6QDxz3WP6 for ; Fri, 14 Oct 2022 19:39:01 +0000 (UTC) (envelope-from adamw@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665776341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1TkseLD69R6cwLX8IqODo2OqHjS7leUpKpEyauHarKw=; b=M1MQKzQwR8WavRPm68Q9uiFdD7Q3DNyFnBdyAOt98IyC3gSZf+DidzUWBj4ksrAj09AcBI dbIm8q0BUx6kh3PIko+rO5FrNtrI+f7ElSkH09H+ccRG7pB4xjLolZcA66XElegqjDMqUG n/+YhQjDB2LfV0kYLDI/UopsVQO9bvDOWScHnDlmePYwrfOFa4Y9uWFh2+n+Ye7DmCZVCm vZ18qq17JEmtEHnqpsnKh9Do/OlDt08PqMSuxZhHT3WTVhUzUhdY7Q65iz4gt9GRJYSCt3 JjgbgHM2R1ZRiRJjOa0GwvkoDiZaoj1WQh9DLBmwWmF6tpynieoveH3p9S0u+Q== Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: adamw/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MpxXP4zt9z1FdD for ; Fri, 14 Oct 2022 19:39:01 +0000 (UTC) (envelope-from adamw@freebsd.org) Received: by mail-ed1-f48.google.com with SMTP id u21so8182340edi.9 for ; Fri, 14 Oct 2022 12:39:01 -0700 (PDT) X-Gm-Message-State: ACrzQf2kM/zgrEhcjnUXnY/SrJakOQgMo0xS2+fkm80R/o/SZWVo5yxg 44VYVK03U2pD1Kfg0vhj9dDN24VX8KnitDiq67B4JA== X-Google-Smtp-Source: AMsMyM5wzR94Z0udfcxghzvSSEMCdl1ZXBnnbcADoWLlR0fE8rMJbtUe8MAxJR8FleSCIPmKyap+pjS1aUJ9AjQjtm4= X-Received: by 2002:a05:6402:1b08:b0:458:d229:bcac with SMTP id by8-20020a0564021b0800b00458d229bcacmr5424203edb.118.1665776340508; Fri, 14 Oct 2022 12:39:00 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202210141707.29EH7i08013647@gitrepo.freebsd.org> In-Reply-To: From: Adam Weinberger Date: Fri, 14 Oct 2022 13:38:44 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 9d241a90370c - main - Mk: Add USES=luajit To: Piotr Kubaj Cc: Adam Weinberger , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000000d3aaf05eb03c7c6" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665776341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1TkseLD69R6cwLX8IqODo2OqHjS7leUpKpEyauHarKw=; b=EBwAMOPwreFjCQh7qbt2EkUVRNL9fegFBuEJLG9Bbd1yA6eHT2+nJIt0KMtn2beAEk68jZ UEAPFluTXT444l3JTh9qNnM1UPA00wlFXcwQxL86n5TjdIM3rM6hHLgGGNAZM09LDBz1yJ Yo4SnzHuVknMqIFqpQpRyekgig642WP+BBTcvKTXpSPEgZcPv1xMnqfLuUMG3IDjkHBSb3 jFy4h+vvL5GZ3X6GkRVa7HvkMw35j0IejYyj/acKT5FkbY4SCjlweoYevqGQAOrMdNiwdw fUsbFCBKVVvZvfboN/Lo907yJYzKsFnstmKsoz2QNHvD2MvykTQUsdTRQiWDUA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1665776341; a=rsa-sha256; cv=none; b=j8YJAyS9HZ4Vl9wgBCt1fNYGqXfIbJqRJP57jHX8/WIFtzKoDIfpCv8kVbrF4tf56ARZob GBOxEX9bCYUGkVZ1aigzyHF6W8CxCuQnMWNAEtVc/G/dMuLAwIGCIxxsinOMKWwp/kjk8J 4QJ9qcDKYAoWt459MiohBFwvLzczluUWzlHNZvuwZn67iwmOIohWWw9nVVuTXVdd+wsVJQ lisrD+PWdHc5VB5SzhybdtX9yy+mWgzT2mxbKb/DsxNQT5PUQvmRO/hs9dp+u2o8yANuKy HG6plQjsKQZeM3mNxxZQzK1ViPWaxxo3p3qpXSv09zLgSaB2KCtmWGH4NLjoaw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --0000000000000d3aaf05eb03c7c6 Content-Type: text/plain; charset="UTF-8" On Fri, Oct 14, 2022 at 1:34 PM Piotr Kubaj wrote: > On 22-10-14 13:01:25, Adam Weinberger wrote: > >On Fri, Oct 14, 2022 at 12:58 PM Piotr Kubaj wrote: > > > >> On 22-10-14 17:07:44, Adam Weinberger wrote: > >> >The branch main has been updated by adamw: > >> > > >> >URL: > >> > https://cgit.FreeBSD.org/ports/commit/?id=9d241a90370c9410d997be37db5e3a5657bdb4ca > >> > > >> >commit 9d241a90370c9410d997be37db5e3a5657bdb4ca > >> >Author: Adam Weinberger > >> >AuthorDate: 2022-10-14 16:50:39 +0000 > >> >Commit: Adam Weinberger > >> >CommitDate: 2022-10-14 17:07:39 +0000 > >> > > >> > Mk: Add USES=luajit > >> > > >> > USES=luajit centralizes luajit dependencies via > >> bsd.default-versions.mk > >> > (defaulting to luajit-devel). > >> > > >> > Ports currently depend on: > >> > lang/luajit: 42 > >> > lang/luajit-devel: 0 > >> > lang/luajit-openresty: 51 > >> > > >> > The difficulty here is that: > >> > - They all conflict with each other > >> > - Upstream is very clear about not intending for users to use the > >> > version in lang/luajit at all, and wants all luajit users to > use > >> > lang/luajit-devel > >> > - luajit-openresty is very aggressive about being drop-in > compatible > >> > with luajit-devel (though not the other direction) > >> > > >> > For the vast majority of situations, USES=luajit will be > sufficient. > >> > Ports that use openresty's API additions can specify > >> > USES=luajit:openresty. > >> > > >> > I'm adding this into head very early in the 2022Q4 cycle so that > >> there's > >> > ample time to address the default. It's a difficult decision. osa, > the > >> > maintainer of luajit and luajit-devel, prefers that the default be > >> > luajit, but I went the other direction because it's in direct > conflict > >> > with upstream's clear stated intention. It's not a simple decision; > >> see > >> > the review below for a little discussion on it. > >> > > >> > The TL;DR here is that this defaults to the one luajit version > that no > >> > port currently depends on. However, this version is what OpenBSD, > >> > Homebrew, Ubuntu, Debian, Fedora, MacPorts, and Arch default to > (and > >> > none of them even provide the stale version lang/luajit provides). > >> > This will bring FreeBSD in line with nearly every other OS package > >> > system, and with upstream's intention. > >> > > >> > See also PRs 225342, 257051. > >> > > >> > Reviewed by: bapt, tcberner > >> > Approved by: portmgr (bapt, tcberner) > >> > Differential Revision: https://reviews.freebsd.org/D36947 > >> >--- > >> > Mk/Uses/luajit.mk | 27 +++++++++++++++++++++++++++ > >> > Mk/bsd.default-versions.mk | 9 ++++++--- > >> > 2 files changed, 33 insertions(+), 3 deletions(-) > >> > > >> >diff --git a/Mk/Uses/luajit.mk b/Mk/Uses/luajit.mk > >> >new file mode 100644 > >> >index 000000000000..75e54407d484 > >> >--- /dev/null > >> >+++ b/Mk/Uses/luajit.mk > >> >@@ -0,0 +1,27 @@ > >> >+# Select your favorite luajit runtime > >> >+# Feature: luajit > >> >+# Usage: USES= luajit[:version] > >> >+# MAINTAINER: adamw@FreeBSD.org > >> >+ > >> >+.if !defined(_INCLUDE_USES_LUAJIT_MK) > >> >+_INCLUDE_USES_LUAJIT_MK=yes > >> >+ > >> >+.if !empty(luajit_ARGS) > >> >+LUAJIT_VER= ${luajit_ARGS} > >> >+.else > >> >+LUAJIT_VER= ${LUAJIT_DEFAULT} > >> >+.endif > >> >+ > >> >+# When adding a version, please keep the comment in > >> >+# Mk/bsd.default-versions.mk in sync > >> >+VALID_LUAJIT_VER= luajit luajit-devel luajit-openresty > >> >+ > >> >+.if empty(VALID_LUAJIT_VER:M${LUAJIT_DEFAULT}) > >> >+IGNORE= Invalid luajit default version ${LUAJIT_DEFAULT}: valid > >> versions are ${VALID_LUAJIT_VER} > >> >+.elif empty(VALID_LUAJIT_VER:M${LUAJIT_VER}) > >> >+IGNORE= Invalid luajit version ${LUAJIT_VER}: valid versions are > >> ${VALID_LUAJIT_VER} > >> >+.endif > >> >+ > >> >+LIB_DEPENDS= libluajit-5.1.so:lang/${LUAJIT_VER} > >> >+ > >> >+.endif > >> >diff --git a/Mk/bsd.default-versions.mk b/Mk/bsd.default-versions.mk > >> >index bbf3d5880c70..5a36e0b9c4d0 100644 > >> >--- a/Mk/bsd.default-versions.mk > >> >+++ b/Mk/bsd.default-versions.mk > >> >@@ -17,9 +17,10 @@ _INCLUDE_BSD_DEFAULT_VERSIONS_MK= yes > >> > > >> > LOCALBASE?= /usr/local > >> > > >> >-. for lang in APACHE BDB COROSYNC EMACS FIREBIRD FORTRAN FPC GCC > >> GHOSTSCRIPT GL GO \ > >> >- IMAGEMAGICK JAVA LAZARUS LIBRSVG2 LINUX LLVM LUA MONO MYSQL > NINJA > >> NODEJS PERL5 \ > >> >- PGSQL PHP PYTHON PYTHON2 PYTHON3 RUBY RUST SAMBA SSL TCLTK > VARNISH > >> >+. for lang in APACHE BDB COROSYNC EMACS FIREBIRD FORTRAN FPC GCC \ > >> >+ GHOSTSCRIPT GL GO IMAGEMAGICK JAVA LAZARUS LIBRSVG2 LINUX LLVM \ > >> >+ LUA LUAJIT MONO MYSQL NINJA NODEJS PERL5 PGSQL PHP PYTHON \ > >> >+ PYTHON2 PYTHON3 RUBY RUST SAMBA SSL TCLTK VARNISH > >> > . if defined(${lang}_DEFAULT) > >> > ERROR+= "The variable ${lang}_DEFAULT is set and it should only > be > >> defined through DEFAULT_VERSIONS+=${lang:tl}=${${lang}_DEFAULT} in > >> /etc/make.conf" > >> > . endif > >> >@@ -86,6 +87,8 @@ LLVM_DEFAULT?= 90 > >> > . endif > >> > # Possible values: 5.1, 5.2, 5.3, 5.4 > >> > LUA_DEFAULT?= 5.2 > >> >+# Possible values: luajit, luajit-devel, luajit-openresty > >> >+LUAJIT_DEFAULT?= luajit-devel > >> > # Possible values: 5.10, 5.20, 6.8 > >> > MONO_DEFAULT= 5.10 > >> > # Possible values: 5.6, 5.7, 8.0, 10.3m, 10.4m, 10.5m, 5.7p, 5.7w > >> > >> Could you make USES=luajit default to openresty on powerpc64 and > >> powerpc64le? lang/luajit and lang/luajit-devel don't support those, but > >> openresty fork does. > >> > >> I believe aarch64 is in similar situation, except that it's also > >> supported by luajit-devel. > >> > > > >Are you positive on that? luajit-devel just has IGNORE_riscv64 (which no > >luajit works on), and includes a block specifically for powerpc*. > It was originally added in > > https://cgit.freebsd.org/ports/commit/lang/luajit/Makefile?id=d2ac3fee9c894bb6f10ab489a4b165f974fc1b03 > . > The review (at https://reviews.freebsd.org/D13804) says: > Successfully built on powerpc. Does not build for powerpc64, though. > Later, that was copied to luajit-devel. > Here's the most recent build on powerpc64le: > > https://talos.anongoth.pl/data/latest-per-pkg/luajit-devel/2.1.0.20220815/powerpc64le-default.log > So that: > .if ${ARCH:Mpowerpc*} || ${ARCH:Mmips*} || ${ARCH:Msparc*} > can be replaced by just: > .if ${ARCH} == powerpc || ${ARCH} == powerpcspe > > If you wish, the mips* and sparc64 parts can be added too, but I don't > think there are any users left. > Thank you!! I'll put a test for ${ARCH:Mpowerpc64*} in bsd.default-versions.mk. # Adam > > > > ># Adam > > > > > >-- > >Adam Weinberger > >adamw@adamw.org // adamw@FreeBSD.org > >https://www.adamw.org > -- Adam Weinberger adamw@adamw.org // adamw@FreeBSD.org https://www.adamw.org --0000000000000d3aaf05eb03c7c6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


<= div dir=3D"ltr" class=3D"gmail_attr">On Fri, Oct 14, 2022 at 1:34 PM Piotr = Kubaj <pkubaj@anongoth.pl> = wrote:
On 22-10-= 14 13:01:25, Adam Weinberger wrote:
>On Fri, Oct 14, 2022 at 12:58 PM Piotr Kubaj <pkubaj@anongoth.pl> wrote:
>
>> On 22-10-14 17:07:44, Adam Weinberger wrote:
>> >The branch main has been updated by adamw:
>> >
>> >URL:
>> https:/= /cgit.FreeBSD.org/ports/commit/?id=3D9d241a90370c9410d997be37db5e3a5657bdb4= ca
>> >
>> >commit 9d241a90370c9410d997be37db5e3a5657bdb4ca
>> >Author:=C2=A0 =C2=A0 =C2=A0Adam Weinberger <adamw@FreeBSD.o= rg>
>> >AuthorDate: 2022-10-14 16:50:39 +0000
>> >Commit:=C2=A0 =C2=A0 =C2=A0Adam Weinberger <adamw@FreeBSD.o= rg>
>> >CommitDate: 2022-10-14 17:07:39 +0000
>> >
>> >=C2=A0 =C2=A0 Mk: Add USES=3Dluajit
>> >
>> >=C2=A0 =C2=A0 USES=3Dluajit centralizes luajit dependencies vi= a
>> bsd.default-versions.mk
>> >=C2=A0 =C2=A0 (defaulting to luajit-devel).
>> >
>> >=C2=A0 =C2=A0 Ports currently depend on:
>> >=C2=A0 =C2=A0 =C2=A0 lang/luajit: 42
>> >=C2=A0 =C2=A0 =C2=A0 lang/luajit-devel: 0
>> >=C2=A0 =C2=A0 =C2=A0 lang/luajit-openresty: 51
>> >
>> >=C2=A0 =C2=A0 The difficulty here is that:
>> >=C2=A0 =C2=A0 =C2=A0 - They all conflict with each other
>> >=C2=A0 =C2=A0 =C2=A0 - Upstream is very clear about not intend= ing for users to use the
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 version in lang/luajit at all, and= wants all luajit users to use
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 lang/luajit-devel
>> >=C2=A0 =C2=A0 =C2=A0 - luajit-openresty is very aggressive abo= ut being drop-in compatible
>> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 with luajit-devel (though not the = other direction)
>> >
>> >=C2=A0 =C2=A0 For the vast majority of situations, USES=3Dluaj= it will be sufficient.
>> >=C2=A0 =C2=A0 Ports that use openresty's API additions can= specify
>> >=C2=A0 =C2=A0 USES=3Dluajit:openresty.
>> >
>> >=C2=A0 =C2=A0 I'm adding this into head very early in the = 2022Q4 cycle so that
>> there's
>> >=C2=A0 =C2=A0 ample time to address the default. It's a di= fficult decision. osa, the
>> >=C2=A0 =C2=A0 maintainer of luajit and luajit-devel, prefers t= hat the default be
>> >=C2=A0 =C2=A0 luajit, but I went the other direction because i= t's in direct conflict
>> >=C2=A0 =C2=A0 with upstream's clear stated intention. It&#= 39;s not a simple decision;
>> see
>> >=C2=A0 =C2=A0 the review below for a little discussion on it.<= br> >> >
>> >=C2=A0 =C2=A0 The TL;DR here is that this defaults to the one = luajit version that no
>> >=C2=A0 =C2=A0 port currently depends on. However, this version= is what OpenBSD,
>> >=C2=A0 =C2=A0 Homebrew, Ubuntu, Debian, Fedora, MacPorts, and = Arch default to (and
>> >=C2=A0 =C2=A0 none of them even provide the stale version lang= /luajit provides).
>> >=C2=A0 =C2=A0 This will bring FreeBSD in line with nearly ever= y other OS package
>> >=C2=A0 =C2=A0 system, and with upstream's intention.
>> >
>> >=C2=A0 =C2=A0 See also PRs 225342, 257051.
>> >
>> >=C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 bapt, tcberner
>> >=C2=A0 =C2=A0 Approved by:=C2=A0 =C2=A0 portmgr (bapt, tcberne= r)
>> >=C2=A0 =C2=A0 Differential Revision:=C2=A0 https://re= views.freebsd.org/D36947
>> >---
>> > Mk/Uses/luajit.mk=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 27 +++++++++= ++++++++++++++++++
>> > Mk/bsd.default-versions.mk |=C2=A0 9 ++++++---
>> > 2 files changed, 33 insertions(+), 3 deletions(-)
>> >
>> >diff --git a/Mk/Uses/luajit.mk b/Mk/Uses/luajit.mk
>> >new file mode 100644
>> >index 000000000000..75e54407d484
>> >--- /dev/null
>> >+++ b/Mk/Uses/luajit.mk
>> >@@ -0,0 +1,27 @@
>> >+# Select your favorite luajit runtime
>> >+# Feature:=C2=A0 =C2=A0 luajit
>> >+# Usage:=C2=A0 =C2=A0 =C2=A0 USES=3D=C2=A0 luajit[:version] >> >+# MAINTAINER: adamw@FreeBSD.org
>> >+
>> >+.if !defined(_INCLUDE_USES_LUAJIT_MK)
>> >+_INCLUDE_USES_LUAJIT_MK=3Dyes
>> >+
>> >+.if !empty(luajit_ARGS)
>> >+LUAJIT_VER=3D=C2=A0 =C2=A0${luajit_ARGS}
>> >+.else
>> >+LUAJIT_VER=3D=C2=A0 =C2=A0${LUAJIT_DEFAULT}
>> >+.endif
>> >+
>> >+# When adding a version, please keep the comment in
>> >+# Mk/bsd.default-versions.mk in sync
>> >+VALID_LUAJIT_VER=3D=C2=A0 =C2=A0 =C2=A0luajit luajit-devel lu= ajit-openresty
>> >+
>> >+.if empty(VALID_LUAJIT_VER:M${LUAJIT_DEFAULT})
>> >+IGNORE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0Invalid luajit default ve= rsion ${LUAJIT_DEFAULT}: valid
>> versions are ${VALID_LUAJIT_VER}
>> >+.elif empty(VALID_LUAJIT_VER:M${LUAJIT_VER})
>> >+IGNORE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0Invalid luajit version ${= LUAJIT_VER}: valid versions are
>> ${VALID_LUAJIT_VER}
>> >+.endif
>> >+
>> >+LIB_DEPENDS=3D=C2=A0 libluajit-5.1.so:lang/${LUAJIT_VER}
>> >+
>> >+.endif
>> >diff --git a/Mk/bsd.default-versions.mk b/Mk/bs= d.default-versions.mk
>> >index bbf3d5880c70..5a36e0b9c4d0 100644
>> >--- a/Mk/bsd.default-versions.mk
>> >+++ b/Mk/bsd.default-versions.mk
>> >@@ -17,9 +17,10 @@ _INCLUDE_BSD_DEFAULT_VERSIONS_MK=3D=C2=A0 = =C2=A0yes
>> >
>> > LOCALBASE?=3D=C2=A0 =C2=A0/usr/local
>> >
>> >-.=C2=A0 for lang in APACHE BDB COROSYNC EMACS FIREBIRD FORTRA= N FPC GCC
>> GHOSTSCRIPT GL GO \
>> >-=C2=A0 =C2=A0 =C2=A0 IMAGEMAGICK JAVA LAZARUS LIBRSVG2 LINUX = LLVM LUA MONO MYSQL NINJA
>> NODEJS PERL5 \
>> >-=C2=A0 =C2=A0 =C2=A0 PGSQL PHP PYTHON PYTHON2 PYTHON3 RUBY RU= ST SAMBA SSL TCLTK VARNISH
>> >+.=C2=A0 for lang in APACHE BDB COROSYNC EMACS FIREBIRD FORTRA= N FPC GCC \
>> >+=C2=A0 =C2=A0 =C2=A0 GHOSTSCRIPT GL GO IMAGEMAGICK JAVA LAZAR= US LIBRSVG2 LINUX LLVM \
>> >+=C2=A0 =C2=A0 =C2=A0 LUA LUAJIT MONO MYSQL NINJA NODEJS PERL5= PGSQL PHP PYTHON \
>> >+=C2=A0 =C2=A0 =C2=A0 PYTHON2 PYTHON3 RUBY RUST SAMBA SSL TCLT= K VARNISH
>> > .=C2=A0 =C2=A0 if defined(${lang}_DEFAULT)
>> > ERROR+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0"The variable ${lang= }_DEFAULT is set and it should only be
>> defined through DEFAULT_VERSIONS+=3D${lang:tl}=3D${${lang}_DEFAULT= } in
>> /etc/make.conf"
>> > .=C2=A0 =C2=A0 endif
>> >@@ -86,6 +87,8 @@ LLVM_DEFAULT?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A090
>> > .=C2=A0 endif
>> > # Possible values: 5.1, 5.2, 5.3, 5.4
>> > LUA_DEFAULT?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A05.2
>> >+# Possible values: luajit, luajit-devel, luajit-openresty
>> >+LUAJIT_DEFAULT?=3D=C2=A0 =C2=A0 =C2=A0 luajit-devel
>> > # Possible values: 5.10, 5.20, 6.8
>> > MONO_DEFAULT=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A05.10
>> > # Possible values: 5.6, 5.7, 8.0, 10.3m, 10.4m, 10.5m, 5.7p, = 5.7w
>>
>> Could you make USES=3Dluajit default to openresty on powerpc64 and=
>> powerpc64le? lang/luajit and lang/luajit-devel don't support t= hose, but
>> openresty fork does.
>>
>> I believe aarch64 is in similar situation, except that it's al= so
>> supported by luajit-devel.
>>
>
>Are you positive on that? luajit-devel just has IGNORE_riscv64 (which n= o
>luajit works on), and includes a block specifically for powerpc*.
It was originally added in
https://cgit.freebsd.org/ports/commit/lang/luajit/Makefile?id=3Dd2ac3fe= e9c894bb6f10ab489a4b165f974fc1b03.
The review (at https://reviews.freebsd.org/D13804) says:
Successfully built on powerpc. Does not build for powerpc64, though.
Later, that was copied to luajit-devel.
Here's the most recent build on powerpc64le:
htt= ps://talos.anongoth.pl/data/latest-per-pkg/luajit-devel/2.1.0.20220815/powe= rpc64le-default.log
So that:
.if ${ARCH:Mpowerpc*} || ${ARCH:Mmips*} || ${ARCH:Msparc*}
can be replaced by just:
.if ${ARCH} =3D=3D powerpc || ${ARCH} =3D=3D powerpcspe

If you wish, the mips* and sparc64 parts can be added too, but I don't<= br> think there are any users left.

Thank you!!
=

I= 9;ll put a test for ${ARCH:Mpowerpc64*} in bsd.default-versions.mk.

# Adam




>
># Adam
>
>
>--
>Adam Weinberger
>adamw@adamw.org // adamw@FreeBSD.org
>= https://www.adamw.org


--
Adam Weinberger
adamw@adamw.org // adamw@FreeBSD.org
https://www.adamw.org
--0000000000000d3aaf05eb03c7c6--