From nobody Tue Nov 01 17:46:36 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N1yBR464Bz4gtJk; Tue, 1 Nov 2022 17:46:39 +0000 (UTC) (envelope-from yuri@FreeBSD.org) Received: from shell1.rawbw.com (shell1.rawbw.com [198.144.192.42]) by mx1.freebsd.org (Postfix) with ESMTP id 4N1yBR2qwnz48Gl; Tue, 1 Nov 2022 17:46:39 +0000 (UTC) (envelope-from yuri@FreeBSD.org) Received: from [192.168.5.3] (c-73-93-225-239.hsd1.ca.comcast.net [73.93.225.239]) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 2A1HkbVS029166 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 1 Nov 2022 10:46:38 -0700 (PDT) (envelope-from yuri@FreeBSD.org) X-Authentication-Warning: shell1.rawbw.com: Host c-73-93-225-239.hsd1.ca.comcast.net [73.93.225.239] claimed to be [192.168.5.3] Content-Type: multipart/alternative; boundary="------------XSAyBxNuqUKQhYdhcjgQy5kP" Message-ID: Date: Tue, 1 Nov 2022 10:46:36 -0700 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: git: a5aaa84fcc6d - main - devel/msgpack-cxx: Add missing dependency devel/boost-libs Content-Language: en-US To: Adam Weinberger Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202211011632.2A1GW36v086037@gitrepo.freebsd.org> From: Yuri In-Reply-To: X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4N1yBR2qwnz48Gl X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N This is a multi-part message in MIME format. --------------XSAyBxNuqUKQhYdhcjgQy5kP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Adam, On 11/1/22 10:28, Adam Weinberger wrote: > > This was intentional; see the CMAKE_OFF. Boost is no longer required, > and the port is using the non-boost version. > Now I see this CMAKE_OFF item. However, upon a deeper look it doesn't appear that disabling Boost is done cleanly in the installed code. For example, the installed file msgpack/v1/adaptor/cpp11/chrono.hpp includes boost/numeric/conversion/cast.hpp without being conditional on MSGPACK_USE_BOOST. I'll report this upstream. I reverted it anyways. Thanks, Yuri --------------XSAyBxNuqUKQhYdhcjgQy5kP Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi Adam,

On 11/1/22 10:28, Adam Weinberger wrote:

This was intentional; see the CMAKE_OFF. Boost is no longer required, and the port is using the non-boost version.

Now I see this CMAKE_OFF item.

However, upon a deeper look it doesn't appear that disabling Boost is done cleanly in the installed code.

For example, the installed file msgpack/v1/adaptor/cpp11/chrono.hpp includes boost/numeric/conversion/cast.hpp without being conditional on MSGPACK_USE_BOOST.

I'll report this upstream.

I reverted it anyways.

Thanks,

Yuri

--------------XSAyBxNuqUKQhYdhcjgQy5kP--