From nobody Fri May 20 16:39:53 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 619231AE9DA2; Fri, 20 May 2022 16:39:57 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L4XWd2Fvdz4XW4; Fri, 20 May 2022 16:39:57 +0000 (UTC) (envelope-from tijl@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653064797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EDuosmqJP27FTDmTCUE8T3/nsgvPEa92ZbKWE9b+TvA=; b=Rx6bt/JKMiUida3toGF9jR96B8mrUO4zwu5RjmfDwTH/Z9UTZUTUnKQYAYe41tS4g8hcJU WHyb0GNZZXZihkCBexHCF/dJa+tVkwu8yTkNcEX+otNyUcOdl05dN/G9/iO+LZBWXUO3oS bFKWOzpg+s3oJMxnOH20bDDhmfAANLeYbPtj2UtsNzCaIXKJUUB9psAE+KT0PDeGe2G9jj N7a3yDZb/iIGWZk9WeOk9HWbukMWzF2EaPO7KGXOpGaMrl7XkkSTVMQrHMfdw3pD3kIEiA 4piwAtyNBeTJCawPnF9g64XGh/T4aApwYEHKhxwLZn0lrdxV4BCAHaB60vE8mg== Received: from localhost (unknown [IPv6:2a02:a03f:894b:4700:d14a:6637:35c1:ece0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: tijl) by smtp.freebsd.org (Postfix) with ESMTPSA id 8C9D9DAE8; Fri, 20 May 2022 16:39:56 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Date: Fri, 20 May 2022 18:39:53 +0200 From: =?UTF-8?B?VMSzbA==?= Coosemans To: Baptiste Daroussin Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 03ff10027e28 - main - audio/libcanberra: split a gtk2 from non graphic port Message-ID: <20220520183953.760899fd@FreeBSD.org> In-Reply-To: <202205191234.24JCY7TN006074@gitrepo.freebsd.org> References: <202205191234.24JCY7TN006074@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653064797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EDuosmqJP27FTDmTCUE8T3/nsgvPEa92ZbKWE9b+TvA=; b=gBcRzmDkJmUa2g+NiJK1dNcCMStQRn2aY4i/GS3amYf97M6zIz07v+neMU4cWrq6BMhvVs M+KrkPmEbz/px+7ey8xRFR0KjLc9oh+uK1f3oQdeScQUoSTe04Gefw/BzxhDLkoWV1OmAd fXhnrI859NlcJfbflq/o4BlzzPoRpIJBjBORnG//QW2L593wyVfrZZg0SZVkXYAuoTbhDS 6124PqXbtZRKqi+ty3A6I4fJcDlpF4/o+QGcJAg2RWs6rgj30z5Ym1CsQCCIydcEW6mbG8 sTFJSe5xaRZNu9jzoghGamih+nXlfpUrYn89QQKKMCDMzJ5zz5lZi4rdReWwoA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1653064797; a=rsa-sha256; cv=none; b=fbr6U9dL9zLlqW6h/pyGX2+fVQb7RHP4wkXYl+NTZCTKe5tdYj7mgiNCOMplZldK6P4smh uRBp58VXq7UonC1hFJziEXkxpIRO7hBkxzZaKz8KYKczbsHzkaTH8WEljEZk4wmXuX7ldX 8yA+HJfjcUJVxfCgORRuLAfydwyoTCQy5flzch/Koj60Tb7roO78DsKR18ek0uYzjztrhq 1n/4RF+Rzv4kuY9qnvDp9sEB2TcK1KeXrnFpgWoM5lJhm2GoVkHuIxHFwQfOqWGLg8sh0x mnYJJx9q6qKSeBSkP3NgUVu5EJ/EPvcDRMtWQluOCKLDLQ22O61UA8VFMxQOfQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Thu, 19 May 2022 12:34:07 GMT Baptiste Daroussin wrote: > The branch main has been updated by bapt: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=03ff10027e28f1047a3057b5c3615a9a4d324276 > > commit 03ff10027e28f1047a3057b5c3615a9a4d324276 > Author: Baptiste Daroussin > AuthorDate: 2022-05-19 12:30:01 +0000 > Commit: Baptiste Daroussin > CommitDate: 2022-05-19 12:34:03 +0000 > > audio/libcanberra: split a gtk2 from non graphic port > > there was already a slave port for gtk3, now make a slaveport for gtk2 as > well. > > While here fix the option definition which was wrongly done making libcanberra > have no options at all while libcanberra-gtk3 had and the opposite was expected > > Use options helpers to simplify the port. > Drop the gtkdoc by default > bump revision and track no package for the 2 only port requiring the gtk2 library > Reduce the slave port to its bare minimal requirement > > This change has been made in a slaveport instead of a flavor, because flavors depending > on its own origin is not supported. this is a candidate for subpackages in the futur. > > note that this changes also removes gtk2 from the dependency path of many gtk3 only > application > --- > audio/Makefile | 1 + > audio/libcanberra-gtk2/Makefile | 7 ++++ > audio/libcanberra-gtk3/Makefile | 25 +------------- > audio/libcanberra-gtk3/pkg-plist | 6 ---- > audio/libcanberra/Makefile | 52 ++++++++++++++-------------- > audio/libcanberra/pkg-plist | 64 ++++++++++++++++------------------- > games/gnubg/Makefile | 4 +-- > mail/claws-mail-notification/Makefile | 4 +-- > 8 files changed, 67 insertions(+), 96 deletions(-) > > diff --git a/audio/libcanberra/Makefile b/audio/libcanberra/Makefile > index 76b99d7bbe9d..4f2d3d9262a9 100644 > --- a/audio/libcanberra/Makefile > +++ b/audio/libcanberra/Makefile > @@ -3,7 +3,7 @@ > > PORTNAME= libcanberra > PORTVERSION= 0.30 > -PORTREVISION= 5 > +PORTREVISION= 6 > CATEGORIES= audio devel > MASTER_SITES= http://0pointer.de/lennart/projects/libcanberra/ \ > http://pkgs.fedoraproject.org/repo/pkgs/libcanberra/libcanberra-0.30.tar.xz/34cb7e4430afaf6f447c4ebdb9b42072/ > @@ -17,47 +17,45 @@ LICENSE_FILE= ${WRKSRC}/LGPL > LIB_DEPENDS= libvorbisfile.so:audio/libvorbis \ > libltdl.so:devel/libltdl > > -USES= gmake gnome libtool pathfix pkgconfig tar:xz > +USES= gmake gnome localbase libtool pathfix pkgconfig tar:xz > USE_GNOME= gnomeprefix gtk20 Should this USE_GNOME be removed?