From nobody Wed May 04 15:16:04 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 82F071AB0E77; Wed, 4 May 2022 15:16:08 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KtgQJ3K30z3rjv; Wed, 4 May 2022 15:16:08 +0000 (UTC) (envelope-from bapt@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651677368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FRQbagOT9bCtI74YAsoxYIrMVPV41OugTQ1FBrPOAgs=; b=XtU8Xwjun7fAfFXN65GB+bz0+O2gcniuTUDuRY2Nx9/1GaOzUzZ4OUVbg7OsVTp9cdG1Ix tz+fmDE75Sbdi/Z4y0U2G8JVezSfHRFwr9pMeFMJpw67qr3eHoelib+yRK5F5sy5Mbfae8 35vA1b35tcIRIdEXFw9CYPa+yE0YPLBemE5yjaBz/hkA4qmnB83eec8i7oQTaoBapjcVgY k2IWztLurJr8JMZXJsq/4/8ohmuBPS0JIwtJxWVHD1c1S14SOsYXk8cQlz0gUWQUfNUa3Q yl4BQeHgUtEL/P5r8sZPEcmK/yfy9REqErSh7+I9DGofdR+Kh3tg7ZUOb5IzIw== Received: from aniel.nours.eu (nours.eu [176.31.115.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 363794A15; Wed, 4 May 2022 15:16:08 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id 5963011EC7D; Wed, 4 May 2022 17:16:04 +0200 (CEST) Date: Wed, 4 May 2022 17:16:04 +0200 From: Baptiste Daroussin To: Piotr Kubaj Cc: Emmanuel Vadot , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ecf09fe34600 - main - graphics/gpu-firmware*-kmod: disable amdgpu on powerpc64 Message-ID: <20220504151604.dxems72xwxhj3eig@aniel.nours.eu> References: <202205041257.244CvQYJ029723@gitrepo.freebsd.org> <20220504152200.5881461e1e927b155884fe4c@bidouilliste.com> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651677368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FRQbagOT9bCtI74YAsoxYIrMVPV41OugTQ1FBrPOAgs=; b=yBIy+fR0HG5T/eYbBTQNgX2K+AZMWAjQkbaHdqyIhzQlPVHGfks9JE36QdHrL3dPsbIs8c +FjjyoOtDPwF1VxxPC/eU/UlCduilD3rOUUXJretkGtfXH59r+lSN3zq25NcfPRGCVTqqk DZx2A3ekdAW5W16BmaVV1QoaVSz6kqLHs6xp9eMoNXSqfJwIgDvnUcabZlDDS2y7aQlTFQ wu14tBy5NlUMTzRpkJA2Tftpj+s8CZJQai5F7mMU8Cu023QcJFGH+x8Vyr1hVwPYGd3YVF sY8adVh7pppOo85LrIPWoCyLUgXp5x9uS34CVpt4pcsNljp+LQQUz9iKHvsHGw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1651677368; a=rsa-sha256; cv=none; b=O5vt6MMjbl5mfhUiA/H9NOpLwuNj6jxoj0rk+msfXvif0Mu30G/J2ArlXsPI1dHUXuvhXN sXM6XUqN9yvKqoO7NYW1wwyX+LHiK/iiC86wZptzG4a3sEtzf5aQHWVeP5ifHcSCC1zk4H ZT0/plTp/zjhKLi+ABeCDEPvjcF507KIqC73lepBIkdM/sPDrgLdIxWnqxKNTlgInOCuBe AlKdQcAvj4DLT7/HfoDJhtNA04+bmN2kPry5iD9ViNoCPRBVbn0lwAaWVbSHVAZ3daxhOG OfTwrI+kdNSAteFlfs1B7gPHdZSa9OSskRm5GEOv6iYDfVtvHxqMMa/q+s4HjA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Wed, May 04, 2022 at 04:32:59PM +0200, Piotr Kubaj wrote: > On 22-05-04 15:22:00, Emmanuel Vadot wrote: > > On Wed, 4 May 2022 12:57:26 GMT > > Piotr Kubaj wrote: > > > > > The branch main has been updated by pkubaj: > > > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=ecf09fe3460067b442ba41a6adb85897c99442b5 > > > > > > commit ecf09fe3460067b442ba41a6adb85897c99442b5 > > > Author: Piotr Kubaj > > > AuthorDate: 2022-05-04 12:54:19 +0000 > > > Commit: Piotr Kubaj > > > CommitDate: 2022-05-04 12:54:19 +0000 > > > > > > graphics/gpu-firmware*-kmod: disable amdgpu on powerpc64 > > > > > > amdgpu has known endianness issues and doesn't work on powerpc64. > > > radeonkms works, while amdgpu works on powerpc64le. > > > --- > > > graphics/gpu-firmware-amd-kmod/Makefile | 4 +- > > > graphics/gpu-firmware-kmod/Makefile | 67 +++++++++++++++++---------------- > > > 2 files changed, 37 insertions(+), 34 deletions(-) > > > > > > > Can you respect MAINTAINER and open a review next time ? > > I believe this falls under tier 2 blanket. Correct me if I'm mistaken. It somehow is and somehow isn't, basically the blanket for tier 2 is to commit trivial changes which allows a port to work (or be flagged as not working on a given architecture) exactly the same as the "just fix it blanket". Intrusive changes should anyway be discussed with the maintainer, and yes it is almost impossible to document what is intrusive from what is not, we have to rely on common sense here, and if one has a doubt, it is cheap to send a mail, open a PR, open a review to the maintainer anyway. The change here does not "fix" anything, so in my opinion, seeking for review and opening a discussion with the maintainer would have been a good idea. As for whether your change is a good idea or not, I will let you discuss that with the maintainer. Best regards, Bapt