From nobody Wed May 04 13:22:00 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id F20671AB3B02; Wed, 4 May 2022 13:22:08 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ktctl2gsfz3GPW; Wed, 4 May 2022 13:22:07 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1651670520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XxizDJIb7oMAgvC/+LIIxqsUOmextcPnM617GN7Mb5E=; b=q8wCx0HAUS3OI/qTS0Q8gkqAlbVY3NURCbH2LAI4BZ+l8V72RrJ/C3z50hDLWhV85eKgK/ AVKbdzDqZ5zwNp4RZjk3ODgTfPhy5S8Z9qLNob+LXJE9nLrVaT2MhGDOQc+GDHXKZMjarG hY2ppSpLlUeQNGWT9hI72hamdWJ2cHE= Received: from amy (lfbn-idf2-1-1209-45.w90-92.abo.wanadoo.fr [90.92.34.45]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 2d4f092b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 4 May 2022 13:22:00 +0000 (UTC) Date: Wed, 4 May 2022 15:22:00 +0200 From: Emmanuel Vadot To: Piotr Kubaj Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: ecf09fe34600 - main - graphics/gpu-firmware*-kmod: disable amdgpu on powerpc64 Message-Id: <20220504152200.5881461e1e927b155884fe4c@bidouilliste.com> In-Reply-To: <202205041257.244CvQYJ029723@gitrepo.freebsd.org> References: <202205041257.244CvQYJ029723@gitrepo.freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Ktctl2gsfz3GPW X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=q8wCx0HA; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-3.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; FREEFALL_USER(0.00)[manu]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+ip4:212.83.155.74/32]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; DKIM_TRACE(0.00)[bidouilliste.com:+]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; NEURAL_HAM_SHORT(-1.00)[-0.998]; MLMMJ_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, 4 May 2022 12:57:26 GMT Piotr Kubaj wrote: > The branch main has been updated by pkubaj: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=ecf09fe3460067b442ba41a6adb85897c99442b5 > > commit ecf09fe3460067b442ba41a6adb85897c99442b5 > Author: Piotr Kubaj > AuthorDate: 2022-05-04 12:54:19 +0000 > Commit: Piotr Kubaj > CommitDate: 2022-05-04 12:54:19 +0000 > > graphics/gpu-firmware*-kmod: disable amdgpu on powerpc64 > > amdgpu has known endianness issues and doesn't work on powerpc64. > radeonkms works, while amdgpu works on powerpc64le. > --- > graphics/gpu-firmware-amd-kmod/Makefile | 4 +- > graphics/gpu-firmware-kmod/Makefile | 67 +++++++++++++++++---------------- > 2 files changed, 37 insertions(+), 34 deletions(-) > Can you respect MAINTAINER and open a review next time ? Also why doing that at all ? Because if someone wants to work on amdgpu on powerpc64 they now need to revert your commit to have the firmware build. I really don't see a point of doing that. -- Emmanuel Vadot