From nobody Sun Mar 27 01:12:50 2022
X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8788E1A4429A;
	Sun, 27 Mar 2022 01:12:50 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4KQyVp3CP2z4sQl;
	Sun, 27 Mar 2022 01:12:50 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
	t=1648343570;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=+F624UHTMLNO+5Saaz2oo+mV3gTwbbUCHZ0UBLEY1yg=;
	b=IThgwc1L9iYFv1D6RnzVeih21h9KGvHh1du24gubcyvbwRnHHanTzCYlTOXmD4YG7kH88X
	1CZiwDhLUx6Z7bIVGHz2WRpAmb3T2xuK8YR8qSRk/sFZIkNwZT1IldDYWeR2xqUPh6WTo4
	W+7SB86V8zScSVl/8/R1yDWQfBkeaR/clhhHzNDulAzaz/cCBylwiSQlbl1SBc+Vwdlwic
	4g0KhTCXQhm0qL3POJWgJ6Ao4LOOd0h6xupk0TPXp9C7UNQyqXWS2kbDmydT7yn/e8N2ba
	5qtSlcWV+q+A9JfuiIvn8vdsGL5d0RAH9JX+lGeWPl/6mmuqddXIilLFaatEuQ==
Received: by freefall.freebsd.org (Postfix, from userid 1033)
	id 518D8145F1; Sun, 27 Mar 2022 01:12:50 +0000 (UTC)
Date: Sun, 27 Mar 2022 01:12:50 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Joseph Mingrone <jrm@freebsd.org>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,
	dev-commits-ports-main@freebsd.org
Subject: Re: git: 2b7653e70047 - main - x11-fm/polo: new port had been added
 (+)
Message-ID: <Yj+6Er4vFWKgE0Dd@FreeBSD.org>
References: <202203260111.22Q1B6Km060141@gitrepo.freebsd.org>
 <86fsn46dv6.fsf@phe.ftfl.ca>
List-Id: Commit messages for all branches of the ports repository <dev-commits-ports-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all
List-Help: <mailto:dev-commits-ports-all+help@freebsd.org>
List-Post: <mailto:dev-commits-ports-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-ports-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-ports-all+unsubscribe@freebsd.org>
Sender: owner-dev-commits-ports-all@freebsd.org
X-BeenThere: dev-commits-ports-all@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <86fsn46dv6.fsf@phe.ftfl.ca>
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
	s=dkim; t=1648343570;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=+F624UHTMLNO+5Saaz2oo+mV3gTwbbUCHZ0UBLEY1yg=;
	b=TGK9EuKUUcv3Sk8apHlU6n2+PMtrU+qyJQxoKJzdSEzNFxvK6TyuLTd9uZqCqm8AQm7BIv
	uVPtfkrRCz2aOrn5g0uIp85FsAGk+Y+3d3SQXBjDyKUS1Jcec/UZY7VrUFhUtXMdwn+KYo
	yhAxMwPJQ+b+TZGMf4QZa2P1eDyiVyDTMdP4Z7ejs8SX+tZIc0wCwXzRC49E/XcP7015Mp
	FuigEumb5gssGuSoiz3ZoWWdw1bLXvpE5NjzQkUQaq/g341r2wJEq+656WUhH8bM2/8oDE
	irtVHxuIdZTZIPMBzXRcZPEOquGwS13w0MYsPexNz39yFriQ6JC60rvu81r8uA==
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1648343570; a=rsa-sha256; cv=none;
	b=NWEY33EmF2xPXplaZeWn2DAZbqNlKD50/iC3wZglhQv9RAPmzBPEFRDYMyq3jpXLKIBYMP
	pb+3fiQRyBo1LHiLzd+oxE4ZtPJXZ9q4JLvWowwL6rZmzi99Rigumbq8ukSiWwJtqh4d52
	wwlX8hmSN7DCgv0DkGLZlurxgBhBAYgLKEyJZXQtRbEycfOrG0fa24rm9X4FZB6unDuLzM
	hR7PHGcV+jodjtEPwQrmwpZtCGpq6/3yH/7Ss0ji4VAEasWPpWRUtaRZgGaLVoztSNm8Ei
	lDiX7jWtNYu+4vaQhVa4HB1sTSrTt8kt3/F7GWDVp9v/M4T1WA6qHKD9sANaHw==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
X-ThisMailContainsUnwantedMimeParts: N

On Sat, Mar 26, 2022 at 10:29:49AM -0300, Joseph Mingrone wrote:
> Is there a good reason to install the binaries unstripped?

No, can't think of one.

> > +-if (($gtk_minor == 14)) || (($gtk_minor == 16)) || (($gtk_minor == 18)) || (($gtk_minor == 20)) || (($gtk_minor == 22)); then
> > ++if [ $gtk_minor = 14 -o $gtk_minor = 16 -o $gtk_minor = 18 -o $gtk_minor = 20 -o $gtk_minor = 22 ]; then
> 
> [ .. ] || [ .. ] || .. is a better choice than -o within [ .. ].  See
> the BUGS section of TEST(1) and
> https://github.com/koalaman/shellcheck/wiki/SC2166.

Interesting.  Basically, it says "-a and -o are not well defined and can
cause incorrect results when arguments start with dashes or contain !".
Unfortunately it does not provide example of such breakage.  Personally
I like -o better than chainin of several test(1) calls, and since there
are definitely no dashes or !'s involved here we should be fine.

./danfe