From nobody Thu Jun 02 20:39:05 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1A82E1B5D370; Thu, 2 Jun 2022 20:44:40 +0000 (UTC) (envelope-from martymac@freebsd.org) Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4LDdKy6JhPz4bJ9; Thu, 2 Jun 2022 20:44:38 +0000 (UTC) (envelope-from martymac@freebsd.org) Received: from relay4-d.mail.gandi.net (unknown [217.70.183.196]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 9F78ACA14A; Thu, 2 Jun 2022 20:39:29 +0000 (UTC) Received: (Authenticated sender: ganael.laplanche@martymac.org) by mail.gandi.net (Postfix) with ESMTPSA id 114D4E0007; Thu, 2 Jun 2022 20:39:08 +0000 (UTC) From: Ganael Laplanche To: Baptiste Daroussin , Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 7ca4bf132765 - main - devel/ncurses: Do not strip libraries when DEBUG option is set Date: Thu, 02 Jun 2022 22:39:05 +0200 Message-ID: <7804319.bYQgcRI8ro@home.martymac.org> In-Reply-To: <20220602133801.ihk5oiz7t54un5wy@aniel.nours.eu> References: <202206021021.252ALr89052824@gitrepo.freebsd.org> <20220602133801.ihk5oiz7t54un5wy@aniel.nours.eu> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 4LDdKy6JhPz4bJ9 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=softfail (mx1.freebsd.org: 217.70.178.240 is neither permitted nor denied by domain of martymac@freebsd.org) smtp.mailfrom=martymac@freebsd.org X-Spamd-Result: default: False [-2.70 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FREEFALL_USER(0.00)[martymac]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; R_SPF_SOFTFAIL(0.00)[~all:c]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MLMMJ_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:29169, ipnet:217.70.176.0/20, country:FR]; RCVD_COUNT_TWO(0.00)[2]; CTE_CASE(0.50)[]; RCVD_IN_DNSWL_LOW(-0.10)[217.70.183.196:received] X-ThisMailContainsUnwantedMimeParts: N On Thursday, June 2, 2022 3:38:01 PM CEST Baptiste Daroussin wrote: Hello danfe, bapt, > First the debug option should exist in the first place here, > > second when WITH_DEBUG is set, then STRIP_CMD is set to /usr/bin/true so the > if it not useful. Thanks to both of you for your feedback! I've just pushed a fix to use WITH_DEBUG instead of DEBUG option. Cheers, -- Ganael LAPLANCHE http://www.martymac.org | http://contribs.martymac.org FreeBSD: martymac , http://www.FreeBSD.org