Re: git: 4671249405c0 - main - net/rubygem-omniauth-auth0: Fix build failure
- In reply to: Po-Chuan Hsieh : "Re: git: 4671249405c0 - main - net/rubygem-omniauth-auth0: Fix build failure"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 14 Jul 2022 05:35:07 UTC
Am 12.07.2022 um 00:37 schrieb Po-Chuan Hsieh: > OK, the failure is about gitlab-ce but the commit message looks like > it causes the build failure of net/rubygem-omniauth-auth0. > > Anyway, you could try this patch [1]. Then we could drop > confusing net/rubygem-omniauth-oauth2-v1. > > [1] https://people.freebsd.org/~sunpoet/patch/gitlab-ce.txt I do not have the test setup here to test such a modification. For this you must setup authentication with auth0 and test that the login afterwards continue to work. But as the new versions will switch the master lib from version 1 to version 2, there is a risk it breaks the authentication. If you tested this and it does not break anything, you have my approval to commit it. Thanks. Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook