Re: git: 191c27eadbff - main - x11-servers/xorg-server: fix build on risc64

From: Kyle Evans <kevans_at_freebsd.org>
Date: Tue, 18 Jan 2022 16:16:35 UTC 
On Mon, Jan 17, 2022 at 9:46 AM Piotr Kubaj <pkubaj@anongoth.pl> wrote:
> On 22-01-17 16:39:31, Emmanuel Vadot wrote:
> > On Mon, 17 Jan 2022 15:35:28 GMT
> > Piotr Kubaj <pkubaj@FreeBSD.org> wrote:
> >
> > > The branch main has been updated by pkubaj:
> > >
> > > URL: https://cgit.FreeBSD.org/ports/commit/?id=191c27eadbff1ca5e93b5fda4154f1182dea49ac
> > >
> > > commit 191c27eadbff1ca5e93b5fda4154f1182dea49ac
> > > Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
> > > AuthorDate: 2022-01-17 15:01:46 +0000
> > > Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
> > > CommitDate: 2022-01-17 15:03:03 +0000
> > >
> > >     x11-servers/xorg-server: fix build on risc64
> > >
> > >     Submitted by:   fuz@fuz.su
> > >     Approved by:    x11 (maintainer timeout)
> >
> >  It's not, Niclas approved this two days after the patch.
> >
>
> Yes, but the submitter is not a committer, so it's literally the same as not approving (since you didn't commit it).
>

That's not even remotely how this works. The maintainer being a
committer doesn't mean they need to commit it to be considered
approved, for any number of reasons that do not matter. It was clearly
approved (despite bugzilla metadata being horribly confusing).

Thanks,

Kyle Evans