From nobody Thu Dec 29 13:18:25 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NjTVW46j6z1Lh8M; Thu, 29 Dec 2022 13:18:43 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NjTVW3f8Nz41mQ; Thu, 29 Dec 2022 13:18:43 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672319923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9hQjW3AxQm8oSfp0pv5RJydZ2iBpN6SZ0ZFTIzSqqaA=; b=FKPBbVln/eaCnAiDH+5DfHYPw4RuVdU8rz+n3MAmaJepAEaryL6UAmyHuAV7gkX89CcY1y fIcyy/kBEb1+n2AoUeS9lbqYMuUNzWqOHiDtaxSP9AxwbZo48uqaqLQTq5De/NZH0kTuPZ 2IVyAxqwGMxvo398xZAj+vPHHtNgSCmyBQqw4iwRM57WkoQR12czv3+TNwnZ50MtgFt9ZL Wc+WBteBK0qmYxZdeYXn0nVbbn8zWqJM+01JqBEplH6VbcB6d6X7YBwuSBsvEK7rUFupcf WIRP4FUavFNVRXeqE4Pn7esLJyOzMKJlLe9ljSrwfvX+Lge8o8L2Xa2JodtG1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672319923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9hQjW3AxQm8oSfp0pv5RJydZ2iBpN6SZ0ZFTIzSqqaA=; b=EaP2juSkmXQapZr/R9vUFMKYHakI6ELsXZyYqVg65RcpGoqgwJcIFcqO0RZWOzaLLSEpZ+ Up96JtFjnoklrbF4YWb//rN4u1fVth8c/VOX79DhlyL3KoV1MujgTHY0gJzHiIH7GxFRNY vh06rdHXDUyrvFJgswnpXLgnPaMZZdLBzSGEiCs9WlAnux01PwqGcALNcJpQ4PY8tdMmWE scS4GjE04c7zcQ4GHdrw2eg5E/7mfpqil0cphSvhc+no+flbcS9D0/bMBTQilcRefBqPR7 Dgfonmv/Hk7rzQc3BnIscbNSOLhwaDTHNgZz/oQadBZz8be2vFtWEDPtgQVdcA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1672319923; a=rsa-sha256; cv=none; b=d6ZLmo1tntoc2eQE4xa2Jx+MEmsV+qsnXGhdpqDv1QsOKQT77qan3+WmsfN90ilfoMBUlK 276NHrUNvGCO+BJ/ijPmi8A022rRDggbg2bm91wkvC26czWQ13N/7OvlicQQyYlYUzpYEm lzjXy/nzuwGjhMR9BAyeudpPztFuoooDm2+hol/v1RTpXdKA8ikq8HjxFYC268ZDDMSVJR suI5Sekz+IC4HFBZPlGx1qEMUIgmDqdxtISVjR41VxXLSCNrhdHS9VIO1IvSzHs2YXWt62 wlXoCkaNaGt0f3UASvbWH7zRNtu4LAboEiiaF3pepIGVqmQ5IkXks+WWdURQ6w== Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NjTVW2kqzzt8J; Thu, 29 Dec 2022 13:18:43 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-vs1-f50.google.com with SMTP id s127so4410819vsb.5; Thu, 29 Dec 2022 05:18:43 -0800 (PST) X-Gm-Message-State: AFqh2krC1W/lhFLgWDO7nq+Xizz2CqZoQdC4pgrlmLf3Cd28LdTDsKka orYzhQOR43ji4J1hc7nAf58apMM2XduG3LLmPVo= X-Google-Smtp-Source: AMrXdXsR1xz01vP8nXOwYIUJx4ANZ5peM4Na4qduMmQO8eAov/yyUBKZyaOg0rCIz72GVT21B/jSWRyRDIHUIJ9EgrY= X-Received: by 2002:a67:ec8a:0:b0:3b7:c371:fa0b with SMTP id h10-20020a67ec8a000000b003b7c371fa0bmr3298820vsp.58.1672319922773; Thu, 29 Dec 2022 05:18:42 -0800 (PST) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> In-Reply-To: From: Nuno Teixeira Date: Thu, 29 Dec 2022 13:18:25 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0 To: Piotr Kubaj Cc: Gerald Pfeifer , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000f2a5ea05f0f75297" X-ThisMailContainsUnwantedMimeParts: N --000000000000f2a5ea05f0f75297 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable OK, thanks a lot for explanation! Cheers Piotr Kubaj escreveu no dia quinta, 29/12/2022 =C3=A0(= s) 13:10: > Nope. > > You can use the maintainer's version. If you append > USES=3Dcompiler:c++14-lang for everyone, then without omp.h there will be > USES=3Dcompiler:c++14-lang compiler:gcc-c++11-lib (two compiler > parameters). > > I have tried that in the past and it doesn't work, only the first one > will be used. > > On 22-12-29 09:31:44, Nuno Teixeira wrote: > >maintainer is trying to "force" me to use: > > > >--- > >.if !exists(/usr/include/omp.h) > >USES+=3D gcc-c++11-lib > >.else > >USES+=3D compiler:c++14-lang > >.endif > >--- > > > >But I think we can avoid .else statement and use compiler:c++14-lang on > >"normal" USES since compiler will be overrided by the .if condition. > >Am I correct? > > > >Piotr Kubaj escreveu no dia quinta, 29/12/2022 =C3= =A0(s) > >01:52: > > > >> Yes, that is ok. > >> > >> On 22-12-29 00:26:01, Nuno Teixeira wrote: > >> >(...) > >> > > >> >Got confused with that commit that have some months old. > >> > > >> >Current Makefile has: > >> >--- > >> >.if !exists(/usr/include/omp.h) > >> >USES+=3D compiler:c++14-lang > >> >USE_GCC=3D yes > >> >.else > >> >USES+=3D compiler:c++14-lang > >> >.endif > >> >--- > >> >And it should be corrected to: > >> >--- > >> >.if !exists(/usr/include/omp.h) > >> >USES+=3D compiler:gcc-c++11-lib > >> >.endif > >> >--- > >> > > >> >Is that ok? > >> >Sorry because I've got confused > >> > > >> >Nuno Teixeira escreveu no dia quarta, 28/12/202= 2 > >> =C3=A0(s) > >> >23:59: > >> > > >> >> You have fixed it in > >> >> > >> > https://cgit.freebsd.org/ports/commit/?id=3Db02f812b43870dc615b6fc713121a= 2e745ed4293 > >> >> > >> >> I think I understand it better now > >> >> > >> >> Thanks > >> >> > >> >> Piotr Kubaj escreveu no dia quarta, 28/12/2022 > >> =C3=A0(s) > >> >> 13:43: > >> >> > >> >>> It would and I was against removal of USES=3Dcompiler:openmp but i= t > was > >> >>> done anyway without any regard for architectures that don't have > >> libomp. > >> >>> > >> >>> On 22-12-28 14:15:44, Thierry Thomas wrote: > >> >>> >Le mer. 28 d=C3=A9c. 22 =C3=A0 13:47:02 +0100, Piotr Kubaj < > pkubaj@anongoth.pl> > >> >>> =C3=A9crivait : > >> >>> > > >> >>> >> If OpenMP is still necessary, then the best way would be: > >> >>> >> .if !exists(/usr/include/omp.h) > >> >>> >> USES+=3D compiler:gcc-c++11-lib > >> >>> >> .else > >> >>> >> USES+=3D compiler:c++14-lang > >> >>> >> .endif > >> >>> > > >> >>> >It would be great to re-add an argument "openmp" in Mk/Uses/ > >> compiler.mk > >> >>> >to put this kind of code at a central place. > >> >>> >-- > >> >>> >Th. Thomas. > >> >>> > >> >> > >> >> > >> >> -- > >> >> Nuno Teixeira > >> >> FreeBSD Committer (ports) > >> >> > >> > > >> > > >> >-- > >> >Nuno Teixeira > >> >FreeBSD Committer (ports) > >> > > > > > >-- > >Nuno Teixeira > >FreeBSD Committer (ports) > --=20 Nuno Teixeira FreeBSD Committer (ports) --000000000000f2a5ea05f0f75297 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
OK, thanks a lot for explanation!

Cheers

Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia quinta, 29/12/2022 =C3=A0(s) 13= :10:
Nope.

You can use the maintainer's version. If you append
USES=3Dcompiler:c++14-lang for everyone, then without omp.h there will be USES=3Dcompiler:c++14-lang compiler:gcc-c++11-lib (two compiler
parameters).

I have tried that in the past and it doesn't work, only the first one will be used.

On 22-12-29 09:31:44, Nuno Teixeira wrote:
>maintainer is trying to "force" me to use:
>
>---
>.if !exists(/usr/include/omp.h)
>USES+=3D gcc-c++11-lib
>.else
>USES+=3D compiler:c++14-lang
>.endif
>---
>
>But I think we can avoid .else statement and use compiler:c++14-lang on=
>"normal" USES since compiler will be overrided by the .if con= dition.
>Am I correct?
>
>Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia quinta, 29/12/2022 =C3=A0(s) >01:52:
>
>> Yes, that is ok.
>>
>> On 22-12-29 00:26:01, Nuno Teixeira wrote:
>> >(...)
>> >
>> >Got confused with that commit that have some months old.
>> >
>> >Current Makefile has:
>> >---
>> >.if !exists(/usr/include/omp.h)
>> >USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler:c++14-lang=
>> >USE_GCC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 yes
>> >.else
>> >USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler:c++14-lang=
>> >.endif
>> >---
>> >And it should be corrected to:
>> >---
>> >.if !exists(/usr/include/omp.h)
>> >USES+=3D=C2=A0 compiler:gcc-c++11-lib
>> >.endif
>> >---
>> >
>> >Is that ok?
>> >Sorry because I've got confused
>> >
>> >Nuno Teixeira <eduardo@freebsd.org> escreveu no dia quarta, 28/12/2022=
>> =C3=A0(s)
>> >23:59:
>> >
>> >> You have fixed it in
>> >>
>> https:/= /cgit.freebsd.org/ports/commit/?id=3Db02f812b43870dc615b6fc713121a2e745ed42= 93
>> >>
>> >> I think I understand it better now
>> >>
>> >> Thanks
>> >>
>> >> Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia quarta, 28/12/202= 2
>> =C3=A0(s)
>> >> 13:43:
>> >>
>> >>> It would and I was against removal of USES=3Dcompiler= :openmp but it was
>> >>> done anyway without any regard for architectures that= don't have
>> libomp.
>> >>>
>> >>> On 22-12-28 14:15:44, Thierry Thomas wrote:
>> >>> >Le mer. 28 d=C3=A9c. 22 =C3=A0 13:47:02 +0100, Pi= otr Kubaj <pkuba= j@anongoth.pl>
>> >>> =C3=A9crivait :
>> >>> >
>> >>> >> If OpenMP is still necessary, then the best = way would be:
>> >>> >> .if !exists(/usr/include/omp.h)
>> >>> >> USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0compiler:= gcc-c++11-lib
>> >>> >> .else
>> >>> >> USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0compiler:= c++14-lang
>> >>> >> .endif
>> >>> >
>> >>> >It would be great to re-add an argument "ope= nmp" in Mk/Uses/
>> compiler.mk
>> >>> >to put this kind of code at a central place.
>> >>> >--
>> >>> >Th. Thomas.
>> >>>
>> >>
>> >>
>> >> --
>> >> Nuno Teixeira
>> >> FreeBSD Committer (ports)
>> >>
>> >
>> >
>> >--
>> >Nuno Teixeira
>> >FreeBSD Committer (ports)
>>
>
>
>--
>Nuno Teixeira
>FreeBSD Committer (ports)


--
Nun= o Teixeira
FreeBSD Committer (ports)
--000000000000f2a5ea05f0f75297--