From nobody Mon Dec 26 22:29:49 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ngst76pjKz1J9fX; Mon, 26 Dec 2022 22:30:07 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X448 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ngst729tyz4L30; Mon, 26 Dec 2022 22:30:07 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Authentication-Results: mx1.freebsd.org; none Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id F25141C60AB; Mon, 26 Dec 2022 23:29:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=anongoth.pl; s=ANONGOTH; t=1672093792; bh=PUWapihcRE7LIyVfnI01LmL+gfOFNJv2OpBxyg9TZB4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=m+gon1I65iyne46XGPf8LjxoRzXX0foTczyyDGpuxET92LEq93pTt5m55suYRIkyc ah2c7SYhDpy2MaF11MJOGcibH8GeujLnoGJMBh9INSsAQf6G00tbwpk1yVwyT8eicQ r2llkHWhGOxuRdgNA3TZqVgZXYFlve31I9nLvO1M6RbZakGpzLbATnpSN/Fgd1swfM NSm6gLPlEaZXud30WynAvkj+9Njt3uftUdxKeI1CkkJUuFpB0qM9dgcd/p+iSh+RBd 2U8x3NhMxY9pWiR483+lKpkEmLXiAnWQsJfqmna+Y/HiVrcbhq+AjT2y3Jjk813rAW nDyvXvOLqzUCw== Date: Mon, 26 Dec 2022 23:29:49 +0100 From: Piotr Kubaj To: Gerald Pfeifer Cc: Nuno Teixeira , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0 Message-ID: References: <202212260526.2BQ5QNkY028999@gitrepo.freebsd.org> <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2bCIM1jBFcEimUZT" Content-Disposition: inline In-Reply-To: <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> X-Rspamd-Queue-Id: 4Ngst729tyz4L30 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --2bCIM1jBFcEimUZT Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline On 22-12-26 23:22:49, Gerald Pfeifer wrote: >On Mon, 26 Dec 2022, Nuno Teixeira wrote: >> .if !exists(/usr/include/omp.h) >> -USES+= compiler:gcc-c++11-lib >> +USES+= compiler:c++14-lang >> +USE_GCC= yes >> .else >> -USES+= compiler:c++11-lang >> +USES+= compiler:c++14-lang >> .endif > >This sets > USES+= compiler:c++14-lang >in both the if-arm and the else-arm. > >Why not set this unconditionally then? > >And combining compiler:c++14-lang and USE_GCC=yes is odd; I don't think >that really works. > >Are you sure this entire block is still necessary at all? Where would it >make a difference? > >Gerald Gerald is right. Moreover, USE_GCC=yes forces linking on libstdc++ which might cause runtime issues. --2bCIM1jBFcEimUZT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJkBAABCgBOFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmOqIF0wFIAAAAAAFQAS cGthLWFkZHJlc3NAZ251cGcub3JncGt1YmFqQGFub25nb3RoLnBsAAoJEHpZm4Ug g5ydUrUQAMY/9WmPqFIZpsjSytl5kggLbPvqAUk8JBg7G+JErKqw2qE8XszfMPyK t6vopBvUiRih5WSw3JKthoTVvmym7WwfG0/rzxhhd6IvYmklJxgUAuptTxJ/93Ua CXqTQNjS960CgqVolIWCxoMyoEsiN6pLjrCanhGHP3GWsRtT/Hh8nEw3AGKqCVg5 tnmhTM7QyDorTJ/PMMvAs2tNiBuqBIWGeLMkgEUoH2O0cBBYgJAXDEz2S+Ca2CDK +BHKo2ZUTVxigyV/F3nsSNTg685T4ZCM1D9803n9HEwHpPR5/T714h4bhICCQYDK vdmP8ig5Wn5Mq6qQZ+Cq7IqlC9K3is/6RLdtEkMaMPmxeCL6GaJlG/zU7TZWw/2V 5v+sHgl+YGrj12mQAdO69lKEwYC7TmQY3CaTP3KzSbnM38vFh6S5S7SJi8QzE9dR aFya3wJgWlRuQ8ZE2undHJlh3X+QzoGflvVaxGN+92GiE00Qdt45BMDyeQKdN1S5 XuvAEEUkuY4OB88aGIfJpTmqhdWV40itl75YMwJhrasfPqlqDq2YqY2ZgerB8OIA 0eaimjZcg35NTqttf2AyF212ksuZDz6RnyBbGNvdZwfFM5iRKoEvr3D/NeTvCxct riFaNOlEwM3sumzHQNv17yaZdIJkwiJXLY2RddXtGmx1NoaoCMqQ =vKkG -----END PGP SIGNATURE----- --2bCIM1jBFcEimUZT--