git: 7eda11c87c30 - main - astro/cfitsio: fix build with clang 15
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 18 Dec 2022 17:43:48 UTC
The branch main has been updated by dim (src committer): URL: https://cgit.FreeBSD.org/ports/commit/?id=7eda11c87c30c735058e9393d54b631a74cf566a commit 7eda11c87c30c735058e9393d54b631a74cf566a Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2022-12-10 18:03:37 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2022-12-18 17:32:40 +0000 astro/cfitsio: fix build with clang 15 During an exp-run for llvm 15 (see bug 265425), it turned out that astro/cfitsio failed to build with clang 15: drvrnet.c:3887:23: warning: call to undeclared function 'gethostbyname'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] hostent = gethostbyname(localhost); ^ drvrnet.c:3887:21: error: incompatible integer to pointer conversion assigning to 'struct hostent *' from 'int' [-Wint-conversion] hostent = gethostbyname(localhost); ^ ~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning and 1 error generated. This is because the configure script defines _XOPEN_SOURCE=700, for unclear reasons, and this hides the gethostbyname() declaration in /usr/include/netdb.h. Fix it by removing the line that adds the define. PR: 268302 Approved by: portmgr (tcberner) MFH: 2022Q4 --- astro/cfitsio/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/astro/cfitsio/Makefile b/astro/cfitsio/Makefile index f2ad34c31b6d..988bdbf15325 100644 --- a/astro/cfitsio/Makefile +++ b/astro/cfitsio/Makefile @@ -30,6 +30,7 @@ OPTIONS_DEFINE= DOCS post-patch: @${REINPLACE_CMD} -e 's|<malloc.h>|<stdlib.h>|' ${WRKSRC}/*.[chl] + @${REINPLACE_CMD} -e '/#define _XOPEN_SOURCE 700/d' ${WRKSRC}/configure do-install: cd ${WRKSRC}/ && ${INSTALL_DATA} drvrsmem.h fitsio.h fitsio2.h longnam.h ${STAGEDIR}${PREFIX}/include/