From nobody Mon Dec 05 13:35:00 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NQlBG4qPnz4jlc9; Mon, 5 Dec 2022 13:43:34 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from sprint-2.amdmi3.ru (sprint-2.amdmi3.ru [185.185.68.145]) by mx1.freebsd.org (Postfix) with ESMTP id 4NQlBF3HD4z3MQS; Mon, 5 Dec 2022 13:43:33 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of amdmi3@amdmi3.ru has no SPF policy when checking 185.185.68.145) smtp.mailfrom=amdmi3@amdmi3.ru; dmarc=none Received: from amdmi3.ru (localhost [127.0.0.1]) by sprint-2.amdmi3.ru (Postfix) with SMTP id 57F92188E49; Mon, 5 Dec 2022 16:46:37 +0300 (MSK) Received: by amdmi3.ru (nbSMTP-1.00) for uid 1000 amdmi3@amdmi3.ru; Mon, 5 Dec 2022 16:46:37 +0300 (MSK) Date: Mon, 5 Dec 2022 16:35:00 +0300 From: Dmitry Marakasov To: Emmanuel Vadot Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 3f78a234e458 - main - graphics/gpu-firmware-kmod: optionize firmware vendors Message-ID: References: <202211291718.2ATHISXL015063@gitrepo.freebsd.org> <20221130111151.bbdc3e3b221207cb541daccd@bidouilliste.com> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221130111151.bbdc3e3b221207cb541daccd@bidouilliste.com> X-Spamd-Result: default: False [-1.96 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.96)[-0.961]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; R_SPF_NA(0.00)[no SPF record]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[amdmi3]; RCVD_COUNT_THREE(0.00)[3]; RCPT_COUNT_THREE(0.00)[4]; DMARC_NA(0.00)[amdmi3.ru]; TO_DN_SOME(0.00)[]; ASN(0.00)[asn:35278, ipnet:185.185.68.0/22, country:RU] X-Rspamd-Queue-Id: 4NQlBF3HD4z3MQS X-Spamd-Bar: - X-ThisMailContainsUnwantedMimeParts: N * Emmanuel Vadot (manu@bidouilliste.com) wrote: > > The branch main has been updated by amdmi3: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3f78a234e45851fc57d23bd86b6362671244ecc6 > > > > commit 3f78a234e45851fc57d23bd86b6362671244ecc6 > > Author: Dmitry Marakasov > > AuthorDate: 2022-11-15 20:18:39 +0000 > > Commit: Dmitry Marakasov > > CommitDate: 2022-11-29 17:18:21 +0000 > > > > graphics/gpu-firmware-kmod: optionize firmware vendors > > > > PR: 267796 > > Approved by: maintainer timeout (x11, 2 weeks) > > --- > > graphics/gpu-firmware-kmod/Makefile | 34 ++++++++++++++++++++++++---------- > > 1 file changed, 24 insertions(+), 10 deletions(-) > > > > Sorry, I've missed this PR. > I don't really understand the point of this. > This is a meta port that should always build everything, it's mostly > made for the end package users so every package is available You don't need to include a package into a metapackage to make it available ) > and also so > user who doesn't know which firmware they needs can just pkg install > this package. If you already know which firmware you need you can just > pkg install it (or just build it from ports/poudriere). This is not true because drm-kmod unconditionally pulls gpu-firmware-kmod which unconditionally pulls all the firmwares. > It's a bit unlikely that one user will need only all > the radeon/amd/intel firmwares. Well in fact there should be an option for each individual firmware, but I was lazy. Another valid case is that I have no idea which specific intel firmware I need, I just don't want nvidia/amd garbage. -- Dmitry Marakasov . amdmi3@amdmi3.ru ..: https://github.com/AMDmi3 https://amdmi3.ru/