From nobody Sun Aug 28 17:37:22 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MG13q2Cftz4b2hb; Sun, 28 Aug 2022 17:37:27 +0000 (UTC) (envelope-from se@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MG13q1ltCz3Smg; Sun, 28 Aug 2022 17:37:27 +0000 (UTC) (envelope-from se@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661708247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wNz8NIsRjU9sZIyWonVmIDDxFaJ3LZbZQM6xFHR+xNQ=; b=mISgaYzCxW7C/l6Zmo1mGV1PPyj683c1EM0iZrpNypBLspjRrGBRV0nqCSfiNDq2T5BtZB QEW5FFeIXaYRRVJ2FkPQ4tFk8x3LTAq83eFpt9d1DZRhY/vXEgkOC966Wkw0jdbgJzq5lD vF4SHrYwU/D4hovfzNRlrZ8SKXmL7eHE13KXKsW4mMxxviWxnnsjvUITIzcb+5jBpelVHN D6oBnqR5PIAo/fNE6A5lCIuQFN+K8qnZ8nHMR3epQGK3MZ4l7X9U6axTqlTewSWaFDzptQ pH4xWnRS7lnu/ZFugGVilsLsIuORGO3RaMF7eoip49zX10/Ng7dhc0mgeOiVpA== Received: from [IPV6:2003:cd:5f1a:d200:7186:a7d5:f7d7:e13e] (p200300cd5f1ad2007186a7d5f7d7e13e.dip0.t-ipconnect.de [IPv6:2003:cd:5f1a:d200:7186:a7d5:f7d7:e13e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MG13p2tMCz1DP4; Sun, 28 Aug 2022 17:37:26 +0000 (UTC) (envelope-from se@freebsd.org) Message-ID: Date: Sun, 28 Aug 2022 19:37:22 +0200 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 From: =?UTF-8?Q?Stefan_E=c3=9fer?= Subject: Re: git: 3d41392b6e04 - main - java/openjdk11: fix build on 13.1 and -CURRENT Content-Language: de-DE, en-US To: Christoph Moench-Tegeder Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202208281455.27SEtOqd062640@gitrepo.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661708247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wNz8NIsRjU9sZIyWonVmIDDxFaJ3LZbZQM6xFHR+xNQ=; b=KGKH2F16l2Pa0HtDqqwxk5cg2OvnQwMx7GRlDFDYI2qTCFKMz5bAYSN5S407esG1cERlON 52tXx+fu/A3Agi9lRI+qZ/2tOhkkAzm36ARF5yqzS8R0tWzh2C6CPViJFOVHniF2GmkZTj VeH9y5zh+ufP+eDNYhtKb0RSPEib0oSQgW1KOqtYr0lBZdszoPlwNsK6Gak5z3uy4ZfbHT qLEyOBuv0iKqhdvrgkkJ+FsHFMP8S9BYKlGpyvwaza9WDherisbvpOxIioTtYOXK8SfLNi C/byKXBetplyf5wR5/oCV+SFAl6t6ZUOssrX5mOLxrBz7G17jwU9CjZVTSy2mg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1661708247; a=rsa-sha256; cv=none; b=Tg4zEv8ny4cMmKE5OjyrM7TUKSVBoeSdapPShUJGYOh7CSrUTivKYknnRVtnivozoJA+oS dw1IcBye7A570ujRAh3M5yum/QGO/Acmrf8fbzOQRbYyfLKivK+GOcKkM9C7Bd3+ErsmGe +DvjE75T31I0avRenYFsKm9tJWiuGJgh51UQT0UaIPn3bkHu4OH1m3NxytSlzufuBIdFtC fMbr4l7Rdl8u7fxWaTYfgLtSnyjYOsXS1NTz4ZtLC3CoqZk9HJoRujvclQGHO443SX8Gw2 DfPvfMIrxTun2or40oXaoe4iPHOJvZhB4LyA/6CZh8QZ/CtRQXxaBqpvALQHog== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Am 28.08.22 um 18:47 schrieb Christoph Moench-Tegeder: > ## Stefan Eßer (se@FreeBSD.org): > >> This breaks the build on 13.1 and -CURRENT when building with LLVM-13 >> or newer due to the -Werror option being passed to the compiler. > > Is there a log of a failing build? openjdk11 built perfectly fine here, > like: > =>> Building java/openjdk11 > build started at Sat Aug 27 19:22:58 CEST 2022 > Poudriere version: 3.3.7_1 > Host OSVERSION: 1301000 > Jail OSVERSION: 1301000 > * C Compiler: Version 13.0.0 (at /usr/bin/cc) > * C++ Compiler: Version 13.0.0 (at /usr/bin/c++) > > and that's before your fix. Immediately before the commit I have tested whether the fix was still required on -CURRENT: In file included from src/java.desktop/share/native/libharfbuzz/hb-aat-layout.cc:35: In file included from /src/java.desktop/share/native/libharfbuzz/hb-aat-layout-kerx-table.hh:31: In file included from src/java.desktop/share/native/libharfbuzz/hb-kern.hh:32: src/java.desktop/share/native/libharfbuzz/hb-ot-layout-gpos-table.hh:1131:11: error: use of bitwise '|' with boolean operands [-Werror,-Wbitwise-instead-of-logical] if (valueFormats[0].apply_value (c, this, &record->values[0], buffer->cur_pos()) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ || src/java.desktop/share/native/libharfbuzz/hb-ot-layout-gpos-table.hh:1131:11: note: cast one or both operands to int to silence this warning src/java.desktop/share/native/libharfbuzz/hb-ot-layout-gpos-table.hh:1417:9: error: use of bitwise '|' with boolean operands [-Werror,-Wbitwise-instead-of-logical] if (valueFormat1.apply_value (c, this, v, buffer->cur_pos()) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ || src/java.desktop/share/native/libharfbuzz/hb-ot-layout-gpos-table.hh:1417:9: note: cast one or both operands to int to silence this warning (Slightly redacted for readability) Since these operations are included into multiple source files, the error is reported for more C++ source files. See also comment 1 and 2 in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265687 The compilation would have failed for any system that uses LLVM-13 or later and -Werror -Wbitwise-instead-of-logical to build this port.