From nobody Wed Apr 20 19:55:35 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4A5F911DD1D1; Wed, 20 Apr 2022 19:57:40 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from sprint-2.amdmi3.ru (sprint-2.amdmi3.ru [185.185.68.145]) by mx1.freebsd.org (Postfix) with ESMTP id 4KkBKZ74KFz3By8; Wed, 20 Apr 2022 19:57:38 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from amdmi3.ru (localhost [IPv6:::1]) by sprint-2.amdmi3.ru (Postfix) with SMTP id 872F4187EEF; Wed, 20 Apr 2022 22:57:30 +0300 (MSK) Received: by amdmi3.ru (nbSMTP-1.00) for uid 1000 amdmi3@amdmi3.ru; Wed, 20 Apr 2022 22:57:30 +0300 (MSK) Date: Wed, 20 Apr 2022 22:55:35 +0300 From: Dmitry Marakasov To: Charlie Li Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 39df21b6f9be - main - devel/sdl20: mark two options BROKEN when disabled Message-ID: References: <202204201057.23KAv8s9028336@gitrepo.freebsd.org> <2d723c61-0194-4fe8-9b84-511d9d2f2b46@freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2d723c61-0194-4fe8-9b84-511d9d2f2b46@freebsd.org> X-Rspamd-Queue-Id: 4KkBKZ74KFz3By8 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of amdmi3@amdmi3.ru has no SPF policy when checking 185.185.68.145) smtp.mailfrom=amdmi3@amdmi3.ru X-Spamd-Result: default: False [-1.69 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.998]; FREEFALL_USER(0.00)[amdmi3]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[amdmi3.ru]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.69)[-0.693]; MLMMJ_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main]; R_SPF_NA(0.00)[no SPF record]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:35278, ipnet:185.185.68.0/22, country:RU]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N * Charlie Li (vishwin@freebsd.org) wrote: > > The branch main has been updated by amdmi3: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=39df21b6f9becc547762032aab1720edfb6c4fc2 > > > > commit 39df21b6f9becc547762032aab1720edfb6c4fc2 > > Author: Dmitry Marakasov > > AuthorDate: 2022-04-20 10:54:54 +0000 > > Commit: Dmitry Marakasov > > CommitDate: 2022-04-20 10:55:07 +0000 > > > > devel/sdl20: mark two options BROKEN when disabled > > > > Reported by: reprise > > --- > > devel/sdl20/Makefile | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/devel/sdl20/Makefile b/devel/sdl20/Makefile > > index 72f2a1d771b5..751b5df1d444 100644 > > --- a/devel/sdl20/Makefile > > +++ b/devel/sdl20/Makefile > > @@ -126,11 +126,13 @@ SDL_ATOMIC_CONFIGURE_ENABLE= atomic gcc-atomics > > SDL_AUDIO_CONFIGURE_ENABLE= audio > > SDL_CPUINFO_CONFIGURE_ENABLE= cpuinfo > > SDL_EVENTS_CONFIGURE_ENABLE= events > > +SDL_EVENTS_BROKEN_OFF= does not build: error: use of undeclared identifier 'event_type' > > SDL_FILE_CONFIGURE_ENABLE= filesystem > > SDL_HAPTIC_CONFIGURE_ENABLE= haptic > > SDL_JOYSTICK_CONFIGURE_ENABLE= joystick > > SDL_JOYSTICK_BUILD_DEPENDS= ${LOCALBASE}/include/linux/input.h:devel/evdev-proto > > SDL_JOYSTICK_LIB_DEPENDS= libinotify.so:devel/libinotify > > +SDL_JOYSTICK_BROKEN_OFF= does not build: ld: error: undefined symbol: test_bit > > SDL_LOADSO_CONFIGURE_ENABLE= loadso > > SDL_POWER_CONFIGURE_ENABLE= power > > SDL_RENDER_CONFIGURE_ENABLE= render > On what architectures are these broken when disabled? I have JOYSTICK > disabled on amd64 and it had always built successfully. These are unlikely architecture dependent, but I'm testing on amd64 too. These are reproducible in poudirere, reprise and locally. Also the option is named SDL_JOYSTICK. -- Dmitry Marakasov . amdmi3@amdmi3.ru ..: https://github.com/AMDmi3 https://amdmi3.ru/