From nobody Wed Nov 10 23:15:03 2021 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 6D4671857C8A; Wed, 10 Nov 2021 23:15:09 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HqLKn2g4Vz3kcX; Wed, 10 Nov 2021 23:15:09 +0000 (UTC) (envelope-from jbeich@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1636586109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lMLti/uFJ9aMjeAXbWNUm0F0y1c/rGRIBgBMrK1iJ8s=; b=amIj+RJ/CIx+0Ah5SBGjz2g05bpRuRXew+o8ZzHzdszHCA2llHl0okhpuUiOgioebf+Unc 81CNBd4RvfaVLYQF3cs0Jdh45c96SNNc+7eplMXYm0E7CM7NdO92jOLyaLL9MQ3mf24++n CCUpgInhXYm++goGIy/ntZANBDcEm1gbIStLwXi48JgMZHg3+nWxvO1pwlbEkcluBx2u9X 0EkW6OQvTfSxOgkYB3W+Mr7ope1VLlwMAxXoZ7UfJJ4WCxu6wTJFfWQnfW4gFFFwxVTgSE 2r2xO/cX4MrWXEsBCZ4GX+HTs9z3LM1p5baQtO+jZP0wgOeHClmb2Sq8vmCk/w== Received: by freefall.freebsd.org (Postfix, from userid 1354) id 4C9FD3D18; Wed, 10 Nov 2021 23:15:09 +0000 (UTC) From: Jan Beich To: Fernando =?utf-8?Q?Apestegu=C3=ADa?= Cc: Baptiste Daroussin , "ports-committers@FreeBSD.org" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b68bef1f6425 - main - x11-wm/kwinft: unbreak build after 5d998836b36f References: <202111101058.1AAAwkpv046598@gitrepo.freebsd.org> <20211110111807.godb2dxxsdjlv7wk@aniel.nours.eu> Date: Thu, 11 Nov 2021 00:15:03 +0100 In-Reply-To: ("Fernando =?utf-8?Q?Apestegu=C3=ADa=22's?= message of "Wed, 10 Nov 2021 15:22:03 +0100") Message-ID: List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1636586109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lMLti/uFJ9aMjeAXbWNUm0F0y1c/rGRIBgBMrK1iJ8s=; b=NXBDtvFi44HhabVG9T2UICqHqbA2ECeilkKmeR3dUMy7V9gggV5cFoO0ZHhNVwY4IZ+8I6 LgcQtSchx6jjYIlUuRSGrc7Bd0xH09QRX4fzRJTckb44kyfMVRBcPj1ydUmBjmrr3IDpSm ohtItCp+I0suajLEufo8pn3rITpzYjhizfbs1BC1RS+vmDG4BHK5s+TSp1TDmT85IgpiYV 7mMgtSfp2cVyPxK2vRfF8cyhhPW2T1g9Dabis2Dx2JglQI7s1EPdg79jTKku9pu7c9F/l/ qj53CCgYIBeE0j0tinHgpRk9xE3HXCz2LVlij9byJEg9jd+wsrePC6W0FSaIxQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1636586109; a=rsa-sha256; cv=none; b=EAqq5/RTSQj6aNGW8y0glW0dJHIiPQ6Rf0kxcI8jBLlxUQywaPwLe55mOKQ8R6OBCC4SLj sJEIEuDO97PZa6klecYgjzRvl+KLiU6KBscnDCnvKFtlavsJZT0J6KflsHs/FgYRYNgJAM WBzT8iWlegB+pq2RgVHHKlcI18Saj9zrV+ds+TnbqIX84G/FtA6+NqsA0/jQio4VRp9AlT PszVx4AC7XRVwgf93uC9m9lScO5wH5wypQ/YHs361qthWNW3bwGynNJA6fVJa6iUlkos7h zwdHqD/pPky9PslXgXCoND+CXkowHq5XTBoWlxT0GsDTDKEojvUFba8IIBoxYw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Fernando Apestegu=C3=ADa writes: > On Wed, Nov 10, 2021 at 1:41 PM Jan Beich wrote: > >> >> Baptiste Daroussin writes: >> >> > On Wed, Nov 10, 2021 at 10:58:46AM +0000, Jan Beich wrote: >> > >> >> The branch main has been updated by jbeich: >> >> >> >> URL: https://cgit.FreeBSD.org/ports/commit/?id=3Db68bef1f6425117cd0d0= d95626178db4c4fb3073 >> >> >> >> commit b68bef1f6425117cd0d0d95626178db4c4fb3073 >> >> Author: Jan Beich >> >> AuthorDate: 2021-11-10 09:24:08 +0000 >> >> Commit: Jan Beich >> >> CommitDate: 2021-11-10 10:58:09 +0000 >> >> >> >> x11-wm/kwinft: unbreak build after 5d998836b36f >> >> >> >> input/filters/window_selector.cpp:19:10: fatal error: 'linux/inpu= t.h' file not found >> >> #include >> >> ^~~~~~~~~~~~~~~ >> >> >> >> Pointy hat to: manu >> > >> > To be honnest I am puzzled about this pointy hat, while manu should ha= ve tested the >> > reverse dependencies of mtdev to make sure noone wrongly took its run >> > dependencies as granted as its own build dependencies and fix them upf= ront, >> > On the otherside, all the ports should be explicit about ALL their dir= ect build >> > dependencies, and not expect another port to provide them. >> >> According to FreshPorts devel/libmtdev has 3 consumers: >> >> - x11/libinput has 22 consumers >> - x11-drivers/xf86-input-evdev has 1 consumer >> - x11-toolkits/qt5-gui has 1033 consumers >> >> Testing all qt5-gui consumers locally is challenging. Some of those may >> have consumers of their own. >> >> > Meaning the said ports were buggy in the first place. >> >> It was unexpected/disrupting. And without exp-run it's unknown how many >> more ports may need to be fixed (I only regularly test mine). Besides, >> destabilizing the tree too much degrades the quality of exp-runs that >> maybe ongoing in parallel for unrelated changes. >> >> > >> > This is one of the reason the Pointy hat culture has been removed from= the ports >> > land in general in favor or at best only accepting self pointy hatting. >> > >> > So as a community if we could avoid finger pointing at others. >> >> Agree, pointy hats can discourage new contributors, drive away existing >> ones due to exhausting negativity or attract trolls. This was mostly a >> silly/petty attempt to grab (mainly manu's) attention. > > In order to do that, we could use the Fixed: field in the commit > template. After all, that is what it is for. > Extra bonus if there is a hook that sends a private mail to the > committer whose commit is being fixed. I've been using "after " for ~6 years, since e771b80b60f2. "Fixes" field is harder to notice when visually scanning new email, "git log --oneline" or through GitHub/GitLab/Gitea web frontend. Regression fixes are similar to security fixes, so quickly finding candidates for "git cherry-pick" helps. See also https://www.conventionalcommits.org/ for an idea how to encode more information into Summary. Unfortunately, it doesn't standardize types of fixes (security, regression, crash, data corruption).