From nobody Wed Nov 10 12:41:25 2021 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D4321185A06C; Wed, 10 Nov 2021 12:41:30 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hq4Gf4KF2z4l21; Wed, 10 Nov 2021 12:41:30 +0000 (UTC) (envelope-from jbeich@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1636548090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=eJvppN1GcQDZXp1c4YZHz84FIl7399pGxqxbHxEGAXw=; b=gs0JwZNUc+uxdNS98GKAvXXr+5NS9qH1ojLWLGtcWjWvuaxfawrXOiZnqjCWx14fRl8CGj XGoJvvMioMsYKuLbAITYwLH186lLvqMOnSkYe3aFjsTWQU36ZsJEC6D5KN69251gHn76Rv AlMM8WI+ZOE23PPFmytnftwfVdReQ+v0Yg0h2u4K12gckz3bqWFNsZbxOQtIkphz32Yqdi FiBUqUugfZag2ZcyHUcNnq3ZWG/E1IyAlK7dE6yXVNE24igDpyPK1KVqyU5bw3OuMcIaoK xVq2jn1GkSdPg4bIaCq5fgs2Upoxni27uvE+cXPhfktBXg9OeLLZgaUttpndgQ== Received: by freefall.freebsd.org (Postfix, from userid 1354) id 84494EBF; Wed, 10 Nov 2021 12:41:30 +0000 (UTC) From: Jan Beich To: Baptiste Daroussin Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: b68bef1f6425 - main - x11-wm/kwinft: unbreak build after 5d998836b36f References: <202111101058.1AAAwkpv046598@gitrepo.freebsd.org> <20211110111807.godb2dxxsdjlv7wk@aniel.nours.eu> Date: Wed, 10 Nov 2021 13:41:25 +0100 Message-ID: List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1636548090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=eJvppN1GcQDZXp1c4YZHz84FIl7399pGxqxbHxEGAXw=; b=aXoCtxatS/tt+9DYwzEFIEriOKMJWJO8iRKN3Jgx7KoyFZQSvYCiNL6VfQkv1HosWRV/Nn 7AEIRlU5h4/jtQxM6LivvlO3fu3gpvhh5AHptc3u3yxCEK7f5y4SaZOYwnxF79Y90LA6hU HyOyvGxwm42G4NiOVIgoh7mHJduFVtkNY/BVa++aHd545wzdJq3JFpYmMo5r8cl25LNNxb XBg2IYcNCYy2zh/aY9cNrEmeXeGMiwph+UUmBalQp3JKVh9U1hrFUZi+iKPsNMb+qBzmUG WwJ2KWBee3LWpZAA6AZJ3/C1vD+SWWYlTQ/ytUlyZA6l8SdE2vNZBMXMY1PiZA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1636548090; a=rsa-sha256; cv=none; b=xLlXicFsqHf9itHNC2xZFcEj+dfOD9/gqrYh7dB7qJDYhpw9ft1+tHjBWlAl8EBQN0xEqY 60lf7G6HegJePqfx2yozfw5IvfKjzVAwWE1XY6UChDp0vRVuDvDz4nK/z0UeIZ/84oHlp2 u6ge++O/KPbjg6YZDm8gDk5N86T7uSbn9W6kAXtvFqOaYsiFlfTUUw9lpclrNl+AvBwYJ2 H5dUyaxchWTNVXYBILPTBLJoyn7iJkTBxqBmLfEUoAPxUecjsNWfPt5/4jXqB+lU9rpHz6 4QsPthsEcFUTWc6GMRPFYzu8C19Vp+f8UUA4kdTtZA24te7Nl98fZoTCpOz0vA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Baptiste Daroussin writes: > On Wed, Nov 10, 2021 at 10:58:46AM +0000, Jan Beich wrote: > >> The branch main has been updated by jbeich: >> >> URL: https://cgit.FreeBSD.org/ports/commit/?id=b68bef1f6425117cd0d0d95626178db4c4fb3073 >> >> commit b68bef1f6425117cd0d0d95626178db4c4fb3073 >> Author: Jan Beich >> AuthorDate: 2021-11-10 09:24:08 +0000 >> Commit: Jan Beich >> CommitDate: 2021-11-10 10:58:09 +0000 >> >> x11-wm/kwinft: unbreak build after 5d998836b36f >> >> input/filters/window_selector.cpp:19:10: fatal error: 'linux/input.h' file not found >> #include >> ^~~~~~~~~~~~~~~ >> >> Pointy hat to: manu > > To be honnest I am puzzled about this pointy hat, while manu should have tested the > reverse dependencies of mtdev to make sure noone wrongly took its run > dependencies as granted as its own build dependencies and fix them upfront, > On the otherside, all the ports should be explicit about ALL their direct build > dependencies, and not expect another port to provide them. According to FreshPorts devel/libmtdev has 3 consumers: - x11/libinput has 22 consumers - x11-drivers/xf86-input-evdev has 1 consumer - x11-toolkits/qt5-gui has 1033 consumers Testing all qt5-gui consumers locally is challenging. Some of those may have consumers of their own. > Meaning the said ports were buggy in the first place. It was unexpected/disrupting. And without exp-run it's unknown how many more ports may need to be fixed (I only regularly test mine). Besides, destabilizing the tree too much degrades the quality of exp-runs that maybe ongoing in parallel for unrelated changes. > > This is one of the reason the Pointy hat culture has been removed from the ports > land in general in favor or at best only accepting self pointy hatting. > > So as a community if we could avoid finger pointing at others. Agree, pointy hats can discourage new contributors, drive away existing ones due to exhausting negativity or attract trolls. This was mostly a silly/petty attempt to grab (mainly manu's) attention.