From nobody Mon May 08 10:12:28 2023 X-Original-To: dev-commits-doc-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QFHCc4mqQz49jZH for ; Mon, 8 May 2023 10:12:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QFHCc4KXnz41cV; Mon, 8 May 2023 10:12:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683540748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EaCI5dNr4BXYQsoTRmOqeONikxhCUutB3M5J5Su3cSY=; b=Zyk1j4W8CTQ1lWmy1El0hEUPmv2ZEhzGKMdKMqfJwg5ZBiytWiN6ldNyYRbkO9bt4VxRzT /8gAiwXcnW+m2vaad7J2uONRYboCxKq3P1lJQeLyeWQ+SuX43bgLR7em/Vo4HKm7gVH+S+ Q/lJfzpuyaWKdCZlLsw6UIF6EmDrYAXgPuGHRWdgKLXjnGL7cx0XD7mhYNoyjmzHnQuMd5 AWgAG/sGEKtGaDYzPn4Jhec2Rp/BF5P5N0b9ttZerrjHDkcQnJW3JTCd59NuVYj9cBp+zc 9Goyg/41Us7CQsfOQLcyfiw8juwyf8tPRJI1IUbf/fAQK9ig8XnvsVzpvMesqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683540748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EaCI5dNr4BXYQsoTRmOqeONikxhCUutB3M5J5Su3cSY=; b=aBSohXsMlQoFV3bm5HxEfusjc6S6i3x2sGTh9Bp9PTBC/Nrv3ARMQ6naxEkgmqJPTFQcUB Dktlgw7mRJ+sG+/5YRU1heKcWb5TiMa6WJD2yhIeQgEwxT/g0NtqlLY1YiXNt/dh0bE2uX NIjlqYbsexhOBVkmoGDVwb3Yc0wATTJAYgvxDhJFXt2a0vbk/eIpRSPyPkIKj6jtS12pZu 4BFXtQ9olnrjh+Yz8mu4XQy24LfUvSiRgmpFkB7LJIDYC4/Dy+JdqOs57K0xXb7C4BdQvO mxUgIY2pNDOo+eG8O6XJxgj8WetPvtKEXiBK1VL5A1UcSEMckttOfyLWV1rhfA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683540748; a=rsa-sha256; cv=none; b=OIjyTbDFA3DBHJyjqCP9/DotOBj83rvDBE6DNbl/m2E9oKzdu1J4xXw/mQkmOy6Tmb/U7v zw3csZ8QdpF+mwQrGCXoJlQp38lj2AwKeyYQVsCo/iJvTcdKzuUDDjdX3RLFGH0/7rHaAs R/7505rAyPBM8zHjMcOhyFU+Y4oxKkq/2xvx68CqyjNxn+OsVP3NCd9q25TaXBEf03vnNp fmPAC185D9xn1IesPeQeG8DW55HREiO5SqsQGKFK1BgCmD+Po51uH1Bwyc443TKC3FA56X d3lCXl/WhC9tg49dl9hln0LA/nlmH6ujiuJwcDuivj15npWRWrnyibQ/RHDuWQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QFHCc3Pl3zwcg; Mon, 8 May 2023 10:12:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 348ACSPE032074; Mon, 8 May 2023 10:12:28 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 348ACSHu032073; Mon, 8 May 2023 10:12:28 GMT (envelope-from git) Date: Mon, 8 May 2023 10:12:28 GMT Message-Id: <202305081012.348ACSHu032073@gitrepo.freebsd.org> To: doc-committers@FreeBSD.org, dev-commits-doc-all@FreeBSD.org From: =?utf-8?Q?Fernando=20Apestegu=C3=ADa?= Subject: git: 6c87ece22b - main - [phb]: Changes to MAINTAINER require bump of PORTREVISION List-Id: Commit messages for all branches of the doc repository List-Archive: https://lists.freebsd.org/archives/dev-commits-doc-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-doc-all@freebsd.org X-BeenThere: dev-commits-doc-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: fernape X-Git-Repository: doc X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6c87ece22b65be5419040deb58f578dbc39ffe6b Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by fernape: URL: https://cgit.FreeBSD.org/doc/commit/?id=6c87ece22b65be5419040deb58f578dbc39ffe6b commit 6c87ece22b65be5419040deb58f578dbc39ffe6b Author: Fernando ApesteguĂ­a AuthorDate: 2023-05-04 14:23:02 +0000 Commit: Fernando ApesteguĂ­a CommitDate: 2023-05-08 10:07:02 +0000 [phb]: Changes to MAINTAINER require bump of PORTREVISION As discussed in the mail list since users would like to know who to contact in case of problems. It also helps in reproducible builds. Reviewed by: manu@ Differential Revision: https://reviews.freebsd.org/D39957 --- documentation/content/en/books/porters-handbook/makefiles/_index.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/documentation/content/en/books/porters-handbook/makefiles/_index.adoc b/documentation/content/en/books/porters-handbook/makefiles/_index.adoc index 4424c368d0..ac8a9a5f51 100644 --- a/documentation/content/en/books/porters-handbook/makefiles/_index.adoc +++ b/documentation/content/en/books/porters-handbook/makefiles/_index.adoc @@ -299,6 +299,7 @@ Examples of when `PORTREVISION` must be bumped: * Changes in the packing list or the install-time behavior of the package. For example, a change to a script which generates initial data for the package, like man:ssh[1] host keys. * Version bump of a port's shared library dependency (in this case, someone trying to install the old package after installing a newer version of the dependency will fail since it will look for the old libfoo.x instead of libfoo.(x+1)). * Silent changes to the port distfile which have significant functional differences. For example, changes to the distfile requiring a correction to [.filename]#distinfo# with no corresponding change to `DISTVERSION`, where a `diff -ru` of the old and new versions shows non-trivial changes to the code. +* Changes to `MAINTAINER`. Examples of changes which do not require a `PORTREVISION` bump: @@ -306,7 +307,6 @@ Examples of changes which do not require a `PORTREVISION` bump: * Changes to `MASTER_SITES` or other functional changes to the port which do not affect the resulting package. * Trivial patches to the distfile such as correction of typos, which are not important enough that users of the package have to go to the trouble of upgrading. * Build fixes which cause a package to become compilable where it was previously failing. As long as the changes do not introduce any functional change on any other platforms on which the port did previously build. Since `PORTREVISION` reflects the content of the package, if the package was not previously buildable then there is no need to increase `PORTREVISION` to mark a change. -* Changes to `MAINTAINER`. A rule of thumb is to decide whether a change committed to a port is something which _some_ people would benefit from having. Either because of an enhancement, fix, or by virtue that the new package will actually work at all.