From nobody Wed Apr 13 17:37:31 2022 X-Original-To: dev-commits-doc-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A08C91B37E7A for ; Wed, 13 Apr 2022 17:37:33 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail.karels.net (mail.karels.net [216.160.39.52]) by mx1.freebsd.org (Postfix) with ESMTP id 4KdqY826tlz54VY; Wed, 13 Apr 2022 17:37:32 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail.karels.net (localhost [127.0.0.1]) by mail.karels.net (8.16.1/8.16.1) with ESMTP id 23DHbVN4006524; Wed, 13 Apr 2022 12:37:31 -0500 (CDT) (envelope-from mike@karels.net) Received: from [10.0.2.130] ([10.0.1.1]) by mail.karels.net with ESMTPSA id v5jyIVsKV2J6GQAA4+wvSQ (envelope-from ); Wed, 13 Apr 2022 12:37:31 -0500 From: Mike Karels To: Glen Barber Cc: John Baldwin , Mike Karels , doc-committers@freebsd.org, dev-commits-doc-all@freebsd.org Subject: Re: git: c4e48b65b7 - main - 13.1 relnotes: Change previous entries to avoid imperative. Date: Wed, 13 Apr 2022 12:37:31 -0500 X-Mailer: MailMate (1.14r5818) Message-ID: In-Reply-To: <20220413171237.GN28996@FreeBSD.org> References: <202204130133.23D1X0Hx031524@gitrepo.freebsd.org> <36b6607e-6a32-cfb0-06fc-ccafeb00409f@FreeBSD.org> <20220413171237.GN28996@FreeBSD.org> List-Id: Commit messages for all branches of the doc repository List-Archive: https://lists.freebsd.org/archives/dev-commits-doc-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-doc-all@freebsd.org X-BeenThere: dev-commits-doc-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4KdqY826tlz54VY X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mike@karels.net designates 216.160.39.52 as permitted sender) smtp.mailfrom=mike@karels.net X-Spamd-Result: default: False [-2.78 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[mike]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:216.160.39.52]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[karels.net]; NEURAL_HAM_LONG(-1.00)[-0.999]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_MEDIUM(-0.94)[-0.935]; NEURAL_HAM_SHORT(-0.64)[-0.644]; MLMMJ_DEST(0.00)[dev-commits-doc-all]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:209, ipnet:216.160.36.0/22, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 13 Apr 2022, at 12:12, Glen Barber wrote: > On Wed, Apr 13, 2022 at 10:09:53AM -0700, John Baldwin wrote: >> On 4/12/22 6:33 PM, Mike Karels wrote: >>> The branch main has been updated by karels (src committer): >>> >>> URL: https://cgit.FreeBSD.org/doc/commit/?id=3Dc4e48b65b76ff0ae15de17= 969d152233eeac83c4 >>> >>> commit c4e48b65b76ff0ae15de17969d152233eeac83c4 >>> Author: Mike Karels >>> AuthorDate: 2022-04-12 21:40:17 +0000 >>> Commit: Mike Karels >>> CommitDate: 2022-04-13 01:32:44 +0000 >>> >>> 13.1 relnotes: Change previous entries to avoid imperative. >>> Change previous entries from "Add ..." to "... has been added", >>> etc, for consistency. >>> Reviewed by: pauamma_gundo.com >>> Differential Revision: https://reviews.freebsd.org/D34892 >> >> Hmm, for 13.0 we explicitly used active voice rather than passive. I = don't know >> that we have a definitive style guide for release notes though. >> > > For the past few releases, I have been using "... had been added." > I personally have no complaint against using "... has been added." > > I do not think we have a strict rule on this, one way or the other. I checked the 13.0 version, and a lot of the entries are missing a subjec= t, e.g. =E2=80=9CAdded ...=E2=80=9D and =E2=80=9CRemoved ...=E2=80=9D, which= are not really sentences. Some of the 13.1 entries could be changed to active voice, but I=E2=80=99m not= sure what to use for a subject for =E2=80=9Chas been fixed=E2=80=9D. I=E2=80=99m willing to make another pass if there is consensus. Mike > Glen