maintainer-feedback requested: [Bug 265378] x11/xfce4-goodies can depend on sysutils/xfce4-battery-plugin when battery-plugin is unbuildable

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 22 Jul 2022 11:33:25 UTC
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-xfce (Nobody)
<xfce@FreeBSD.org> for maintainer-feedback:
Bug 265378: x11/xfce4-goodies can depend on sysutils/xfce4-battery-plugin when
battery-plugin is unbuildable
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265378



--- Description ---
Hi,

x11/xfce4-goodies can depend on sysutils/xfce4-battery-plugin, and does so by
default.

sysutils/xfce4-battery-plugin is 'ONLY_FOR_ARCHS= amd64 i386'.

This means that building x11/xfce4-goodies on aarch64 (and probably others)
fails without some fiddling.

I think you can be cunning with various OPTIONS_ settings to make it so that
the BATTERY option is only available on amd64 and i386, and only set by default
on those arches... but the following patch follows the powerpc example for the
arch I found the problem on (it misses out armv6, armv7, risc64, and risc64sf
and possibly more). 

index fb2e9437b7b5..840c34cb8510 100644
--- a/x11/xfce4-goodies/Makefile
+++ b/x11/xfce4-goodies/Makefile
@@ -23,6 +23,7 @@ OPTIONS_EXCLUDE_powerpc=	BATTERY
 OPTIONS_EXCLUDE_powerpc64=	BATTERY
 OPTIONS_EXCLUDE_powerpc64le=	BATTERY
 OPTIONS_EXCLUDE_powerpcspe=	BATTERY
+OPTIONS_EXCLUDE_aarch64=	BATTERY

 OPTIONS_GROUP= APPLICATIONS PANELPLUGINS THUNARPLUGINS UNOFFICIAL