Re: libX changed its libnameA.h to libnameB.h

Yes, a new api for sure. Replacing .h file:

../src/backend_libnsgif.c:17:3: error: unknown type name 'gif_animation'
   17 |   gif_animation gif;
      |   ^
../src/backend_libnsgif.c:55:8: error: unknown type name
'gif_bitmap_callback_vt'
   55 | static gif_bitmap_callback_vt bitmap_callbacks = {
      |        ^
../src/backend_libnsgif.c:72:3: warning: call to undeclared function
'gif_finalise'; ISO C99 and later do not support implicit function
declarations [-Wimplicit-function-declaration]
   72 |   gif_finalise(&private->gif);
      |   ^
../src/backend_libnsgif.c:100:3: error: use of undeclared identifier
'gif_result'
  100 |   gif_result code = gif_decode_frame(&private->gif,
private->current_frame);
      |   ^
../src/backend_libnsgif.c:101:7: error: use of undeclared identifier
'code'; did you mean 'close'?
  101 |   if (code != GIF_OK) {
      |       ^~~~
      |       close
/usr/include/unistd.h:324:6: note: 'close' declared here
  324 | int      close(int);
      |          ^
../src/backend_libnsgif.c:101:15: error: use of undeclared identifier
'GIF_OK'; did you mean 'NSGIF_OK'?
  101 |   if (code != GIF_OK) {
      |               ^~~~~~
      |               NSGIF_OK


I will see if lib have some kind of compability with old version and
if not I will disable this port option and put it as broken.

Moin Rahman <bofh@freebsd.org> escreveu (sábado, 17/02/2024 à(s) 08:46):
>
>
>
> > On Feb 17, 2024, at 9:43 AM, Nuno Teixeira <eduardo@freebsd.org> wrote:
> >
> > Hello Moin!
> >
> > I will try rename on src code and check if functionality is ok.
> >
> > Just a question: is it normal a lib do such changes?
> Not at all.
>
> > Taking a look at changelog I can't see nothing related:
> > https://www.mail-archive.com/netsurf-commits@netsurf-browser.org/msg17336.html
> >
> > It smells like new API... In that case, consumers should change to support it.
> In that case you have run out of luck. :D
>
> > Cheers,
> >
> >
> > Moin Rahman <bofh@freebsd.org> escreveu (sábado, 17/02/2024 à(s) 08:11):
> >>
> >>
> >>
> >>> On Feb 17, 2024, at 9:08 AM, Nuno Teixeira <eduardo@freebsd.org> wrote:
> >>>
> >>> Hello all,
> >>>
> >>> I'm facing a build error causes from graphics/libnsgif that changed
> >>> from 0.2.1 to 1.0.0:
> >>> -include/libnsgif.h
> >>> +include/nsgif.h
> >>>
> >>> Now graphics/imv complains:
> >>>
> >>> ./src/backend_libnsgif.c:9:10: fatal error: 'libnsgif.h' file not found
> >>>   9 | #include <libnsgif.h>
> >>>     |          ^~~~~~~~~~~~
> >>> 1 error generated.
> >>>
> >>> While I'm looking from upstream recomendation on fix, how do I quick fix it?
> >>> Is it possible to rename libnsgif.h -> nsgif.h in source code?
> >>>
> >>> Also googling about this issue didn't get results since most img pkgs
> >>> do not have this lib default on.
> >>>
> >>> Thanks,
> >>>
> >>> --
> >>> Nuno Teixeira
> >>> FreeBSD Committer (ports)
> >>>
> >>
> >> Depends. If the function names and arguments are also same you can just
> >> rename in the source code.
> >>
> >>
> >
> >
> > --
> > Nuno Teixeira
> > FreeBSD Committer (ports)
>


-- 
Nuno Teixeira
FreeBSD Committer (ports)