[Bug 272054] [NEW PORT] sysutils/gh-md-toc: Easy TOC creation for GitHub README.md

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272054

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org

--- Comment #1 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your submission.  Here are some comments:

 - does this script run with /bin/sh?  If yes, we could eliminate the bash
dependency.
 - could you patch the script to use fetch(1) instead of wget(1) or curl(1)?
   This would permit elimination of these dependencies.
 - please only use ${PORTNAME} if the makefile would still work was PORTNAME
   changed.  In this case, if the port is renamed, the do-install target no
   longer works, so perhaps you shouldn't use PORTNAME there.
 - using ${PORTDOCS[0]} to get the name of a known file is fragile programming
   style.  What if PORTDOCS has multiple entries and someone sorts it so README
   is no longer the first entry?  Try to avoid such dependencies on element
order
   in lists.  Just hardcode README as the file you want to install.
 - WWW does not need a trailing slash.

Will proceed with a build test once these issues have been addressed.

-- 
You are receiving this mail because:
You are the assignee for the bug.