[Bug 266384] port games/openarena crashes when autodownloads maps from the server

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266384

            Bug ID: 266384
           Summary: port games/openarena crashes when autodownloads maps
                    from the server
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: kaminar@seznam.cz

Dear Maintainers,

there is a bug in the games/openarena port that causes a crash of the OpenArena
when it autodownloads maps from the game server. The FreeBSD forum discussion
on this topic is here:

https://forums.FreeBSD.org/threads/autodownloading-failure-in-openarena.86313/

Steps to reproduce:

1. Start the OpenArena game.
2. Enable autodownloding: Setup / Game Options / Automatic Downloading -> on.
3. Run the multiplayer.
4. Change the option "Servers" to "Internet".
5. Select a server with custom maps, e.g. ":F CTF FOR GENIUSES".
6. Enter the arena with the "fight" button.

The bug was probably introduced in the commit:
https://cgit.freebsd.org/ports/commit/games/openarena?id=75eb5eba72912f15b677cf6b386089c894eff11e

We investigated that the bug is caused by line 94 in the file
ports/games/openarena/files/patch-code_qcommon_files.c in the hunk
@@ -754,7 +760,11 @@ void FS_SV_Rename( const char *from, con

+       FS_CheckFilenameIsMutable( to_ospath, __func__ ); <-- *BUG*
+
+       if ( safe ) {
+               FS_CheckFilenameIsMutable( to_ospath, __func__ );
+       }

The function call marked *BUG* needs to be deleted.

After removing the function call on line 94, the autodownloading works again.


Regards
Kaminar

-- 
You are receiving this mail because:
You are the assignee for the bug.