[Bug 265651] [NEW PORT] archivers/zpaqfranz: versioned/snapshot archive

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265651

--- Comment #2 from Franco Corbelli <franco@francocorbelli.com> ---
Thank for you comments


"* Never set WRKSRC to WRKDIR. Instead, for an upstream distfile that doesn't
create a subdir itself, set NO_WRKSUBDIR=yes."
It is my very first port, I have "cloned" some other, I'll check



"* Never define do-build and do-install targes if upstream already provides a
build system that can do them (which is the case here)."

You can find here why there are "two" Makefiles
https://forums.freebsd.org/threads/makefile-s-for-a-non-intel-only-port.86073/

One (the "inside .tar.gz") is, in fact, a Linux/FreeBSD/Solaris Makefile
The second ("the port") is the FreeBSD specific, checking for "Intel" CPU and
"others" (defining -DNOJIT in the compiling phase)

Basically you need a conditional compilation (by activating -DNOJIT) on non-x86
machines.
Maybe you can suggest me the best way


* Similar for CPU features, you're checking for SSE2 on the building machine,
but if the executing machine doesn't have it, it will fail. In general, you
can't assume SSE2 on i386.

It is true, but I do not know how to write a "multiple case" (yet)


"* The upstream Makefile installs the same binary twice. Remove one of them. If
the second name is really strictly needed, replace it with a symlink."
The second name is really needed, because if the executable is named "dir" ...
works just like Windows' dir :-)
In fact two programs in one executable

-- 
You are receiving this mail because:
You are the assignee for the bug.