[Bug 259259] Mk/Uses/emacs.mk: Remove Emacs major version from EMACS_PKGNAMESUFFIX

From: <bugzilla-noreply_at_freebsd.org>
Date: Thu, 21 Oct 2021 04:53:31 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259259

Joseph Mingrone <jrm@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jrm@freebsd.org

--- Comment #3 from Joseph Mingrone <jrm@freebsd.org> ---
Are you using the official repository?  I may be misremembering, but I didn't
think that I experienced any problems with this major bump, i.e., pkg upgrade
went through an extra step to confirm that I wanted to delete pdf-tools-emacs28
and install pdf-tools-emacs29.

When the Emacs ports were being flavorized, I recall the deliberating about
whether the major version should be included in the package names.  I don't
recall details, but it might have been to account for the possibility that we
would have more than two emacs ports in the tree in the future.

I don't have a problem with this idea in principal, but there are some hurdles
before we can proceed.

1. The other Emacs maintainer has to agree
2. It looks like the transition won't be smooth.  This doesn't happen without
the patch.  Maybe we just need to bump PORTVERSION?  Could you check this?

jrm@ser /usr/ports [emacs-flavor-names|✔] % git apply
~/diffs/emacs-flavor-names.diff
jrm@ser /usr/ports [emacs-flavor-names|✚1] % s poudriere bulk -C -t -j 13amd64
devel/magit-devel@all
[00:00:00] Creating the reference jail... done
[00:00:00] Mounting system devices for 13amd64-default
[00:00:00] Stashing existing package repository
[00:00:00] Mounting ccache from: /usr/local/poudriere/ccache/13amd64
[00:00:00] Mounting ports from: /usr/ports
[00:00:00] Mounting packages from:
/usr/local/poudriere/data/packages/13amd64-default
[00:00:00] Mounting distfiles from: /usr/ports/distfiles
[00:00:00] Copying /var/db/ports from:
/usr/local/etc/poudriere.d/13amd64-options
[00:00:00] Appending to make.conf: /usr/local/etc/poudriere.d/make.conf
/etc/resolv.conf ->
/usr/local/poudriere/data/.m/13amd64-default/ref/etc/resolv.conf
[00:00:00] Starting jail 13amd64-default
[00:00:00] Will build as nobody:nobody (65534:65534)
[00:00:01] Logs:
/usr/local/poudriere/data/logs/bulk/13amd64-default/2021-10-21_01h18m26s
[00:00:01] WWW:
http://pkg.ftfl.ca/build.html?mastername=13amd64-default&build=2021-10-21_01h18m26s
[00:00:01] Loading MOVED for
/usr/local/poudriere/data/.m/13amd64-default/ref/usr/ports
[00:00:01] Ports supports: FLAVORS SELECTED_OPTIONS
[00:00:01] Inspecting ports tree for modifications to git checkout... yes
[00:00:01] Ports top-level git hash: f99dd971a4d9 (dirty)
[00:00:01] Gathering ports metadata
[00:00:03] Calculating ports order and dependencies
[00:00:04] -C specified, cleaning listed packages
[00:00:04] (-C) Flushing package deletions
[00:00:04] Trimming IGNORED and blacklisted ports
[00:00:04] Sanity checking the repository
[00:00:04] Checking packages for incremental rebuild needs
[00:00:04] Deleting dash.el-emacs27_nox-2.19.1_1.pkg: package name changed to
'dash.el-emacs-nox'
[00:00:04] Deleting dash.el-emacs27_canna-2.19.1_1.pkg: package name changed to
'dash.el-emacs-canna'
[00:00:04] Deleting dash.el-emacs29-2.19.1_1.pkg: package name changed to
'dash.el-emacs-devel'
[00:00:04] Deleting dash.el-emacs29_nox-2.19.1_1.pkg: package name changed to
'dash.el-emacs-devel-nox'
[00:00:05] Deleting magit-devel-emacs27_canna-3.2.1.76.pkg: package name
changed to 'magit-devel-emacs-canna'
[00:00:05] Deleting magit-devel-emacs27_nox-3.2.1.76.pkg: package name changed
to 'magit-devel-emacs-nox'
[00:00:05] Deleting magit-devel-emacs29-3.2.1.76.pkg: package name changed to
'magit-devel-emacs-devel'
[00:00:05] Deleting magit-devel-emacs29_nox-3.2.1.76.pkg: package name changed
to 'magit-devel-emacs-devel-nox'
[00:00:05] Deleting transient-emacs27_canna-0.3.6_1.pkg: package name changed
to 'transient-emacs-canna'
[00:00:05] Deleting transient-emacs27_nox-0.3.6_1.pkg: package name changed to
'transient-emacs-nox'
[00:00:05] Deleting transient-emacs29_nox-0.3.6_1.pkg: package name changed to
'transient-emacs-devel-nox'
[00:00:05] Deleting transient-emacs29-0.3.6_1.pkg: package name changed to
'transient-emacs-devel'
[00:00:05] Deleting with-editor-emacs27_canna-3.0.5.pkg: package name changed
to 'with-editor-emacs-canna'
[00:00:05] Deleting with-editor-emacs27_nox-3.0.5.pkg: package name changed to
'with-editor-emacs-nox'
[00:00:05] Deleting with-editor-emacs29-3.0.5.pkg: package name changed to
'with-editor-emacs-devel'
[00:00:05] Deleting with-editor-emacs29_nox-3.0.5.pkg: package name changed to
'with-editor-emacs-devel-nox'
[00:00:05] Deleting stale symlinks... done
[00:00:05] Deleting empty directories... done
[00:00:05] Unqueueing existing packages
[00:00:05] Unqueueing orphaned build dependencies
[00:00:05] Sanity checking build queue
[00:00:05] Error: Packages stuck in queue (depended on but not in queue):
ccache-3.7.12_2
emacs-27.2,3
git-2.33.0
gmake-4.3_2
indexinfo-0.3.1
pkg-1.17.3
texinfo-6.8,1
[13amd64-default] [2021-10-21_01h18m26s] [crashed:] Queued: 20 Built: 0 
Failed: 0  Skipped: 0  Ignored: 0  Fetched: 0  Tobuild: 20  Time: 00:00:05
[00:00:05] Logs:
/usr/local/poudriere/data/logs/bulk/13amd64-default/2021-10-21_01h18m26s
[00:00:05] WWW:
http://pkg.ftfl.ca/build.html?mastername=13amd64-default&build=2021-10-21_01h18m26s
[00:00:05] Cleaning up
[00:00:05] Unmounting file systems

3. Could we replace some '-' with '_' like the old package names, so it's
easier to determine what part of the package name is the flavor?

--------------------------------------------------------------------------------------------------------------------------------------------------
|port@flavor                  | Current Package Name               | Currently
Proposed Package Name      | Suggested Package Name               |
|-----------------------------|------------------------------------|--------------------------------------|--------------------------------------|
|devel/magit@full             | magit-emacs27-3.3.0                |
magit-emacs-3.3.0                    | magit-emacs-3.3.0                    |
|devel/magit@nox              | magit-emacs27_nox-3.3.0            |
magit-emacs-nox-3.3.0                | magit-emacs_nox-3.3.0                |
|devel/magit@canna            | magit-emacs27_canna-3.3.0          |
magit-emacs-canna-3.3.0              | magit-emacs_canna-3.3.0              |
|                             |                                    |           
                          |                                      |
|devel/magit@devel_nox        | magit-emacs29_nox-3.3.0            |
magit-emacs-devel-nox-3.3.0          | magit-emacs_devel_nox-3.3.0          |
|devel/magit@devel_full       | magit-emacs29-3.3.0                |
magit-emacs-devel-3.3.0              | magit-emacs_devel-3.3.0              |
|                             |                                    |           
                          |                                      |
|devel/magit-devel@full       | magit-devel-emacs27-3.2.1.76       |
magit-devel-emacs-3.2.1.76           | magit-devel-emacs-3.2.1.76           |
|devel/magit-devel@nox        | magit-devel-emacs27_nox-3.2.1.76   |
magit-devel-emacs-nox-3.2.1.76       | magit-devel-emacs_nox-3.2.1.76       |
|devel/magit-devel@canna      | magit-devel-emacs27_canna-3.2.1.76 |
magit-devel-emacs-canna-3.2.1.76     | magit-devel-emacs_canna-3.2.1.76     |
|                             |                                    |           
                          |                                      |
|devel/magit-devel@devel_nox  | magit-devel-emacs29_nox-3.2.1.76   |
magit-devel-emacs-devel-nox-3.2.1.76 | magit-devel-emacs_devel_nox-3.2.1.76 |
|devel/magit-devel@devel_full | magit-devel-emacs29-3.2.1          |
magit-devel-emacs-devel-3.2.1.76     | magit-devel-emacs_devel-3.2.1.76     |
--------------------------------------------------------------------------------------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.