[Bug 259953] net/minidnla rescan support/fix

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259953

            Bug ID: 259953
           Summary: net/minidnla rescan support/fix
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: gerrit@weinberg2.de

minidlna comes with a "rescan" command for rc.d. However, this reads

rescan_cmd="$command -R -u $minidlna_uid -f /usr/local/etc/minidlna.conf"

This is in line with the manpage, but obviously wrong when comparing to the
commandline help (minidlnad -h):

        -r forces a rescan
        -R forces a rebuild

So "-R" forces a rebuild of the database while a rescan uses "-r". I verified
that this is what is actually happening by checking the database file and the
time each command takes (rescan is fast and just adds new stuff, rebuild takes
much longer and also removed outdated entries). Thus I propose to change the
rc.d script to contain

extra_commands="rescan rebuild"
rescan_cmd="$command -r -u $minidlna_uid -f /usr/local/etc/minidlna.conf"
rebuild_cmd="$command -R -u $minidlna_uid -f /usr/local/etc/minidlna.conf"

Furthermore, as this is not handled via signals on the running process, it
might be useful to force a stop command before doing either rescan or rebuild.

-- 
You are receiving this mail because:
You are the assignee for the bug.