[Bug 262008] editors/libreoffice failed to build

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262008

--- Comment #43 from Guido Falsi <madpilot@FreeBSD.org> ---
(In reply to Tomoaki AOKI from comment #41)

> Unfortunately, no commit messages on bumps mention about the commits I've mentioned.
> This would make future developers confuse because of unsane traceability.

In the ports tree we are often grabbing __FreeBSD_version values near the
affected commits, because often one exactly at the affected commit is often
missing. Also quite often the commit actually bumping __FreeBSD_version happens
a few commits after the fact, so even when there is an actual specific bump it
is not exactly matching the event in the history.

So this objection is moot in practice, just grab the nearest bump, that is good
enough, especially since we are talking about head and stable, people will
anyway upgrade past the event at some point. Chances of people falling in one
of the commits in between is really low.

> Moreover, if further MFC to stable/12 is planned, depending on __FreeBSD_version (OSVERSION on ports) should force another update.
> As editors/libreoffice is a giant, requiring several hours to build, this would be a pain.

This depends on the nature of the fix. As far as I can understand this is a
build fix, while already built binaries keep working (except ones built using
hacks to try to work around the issue, but that's user action that they will
need to fix themselves), so we simply need to change the conditional, no
PORTREVISION bump is required for build fixes.

If I'm wrong and this is a runtime also issue and thus need to force package
being rebuilt you get a point here, but a minor one. If the package is broken
there is no alternative than rebuilding it to fix it.

-- 
You are receiving this mail because:
You are the assignee for the bug.