Re: mlx5 fails to attach after STABLE-14 source upgrade

On Mon, Dec 04, 2023 at 09:37:24AM +0800, Zhenlei Huang wrote:
> 
> 
> > On Dec 2, 2023, at 3:29 AM, Dries Michiels <driesm@freebsd.org> wrote:
> > 
> > <image.png>
> > 
> > After updating my STABLE-14 machine from somewhere quite recently (my old kernel that boots without error is from 14-n265716-bd7dceb27c08 somewhere previous saturday).
> > The new kernel that didn't boot was from Commit 24cd42aeb6232b4678f45dc6d242e8982dbea8e6 (HEAD -> stable/14, origin/stable/14) checked out.
> > 
> > Could someone take a look at this?
> > 
> > Regards
> > Dries
> 
> 
> Hi Dries,
> 
> The commit 24cd42aeb6232b4678f45dc6d242e8982dbea8e6 is for crypto/ossl , that should
> not affect mlx5.
> 
> There're some changes since bd7dceb27c08,
> ```
> git log --format=oneline bd7dceb27c08..24cd42aeb623 -- sys/dev/mlx5
> 
> ac83e415ef083da400509c6fa434ee59cfe9668f mlx5_core: fix deadlock when using RXTLS
> 8377dd1c9aeb7f4e42ec2679bb8913379d9c77e7 mlx5core: add linux/bitops.h include for mlx5_ifc.h use of BIT()
> 588203bfbdc46073dc8b4515d31a6a9efe3d9a3c mlx5: Introduce new destination type TABLE_TYPE
> d82618894153d0f53b272a0c76fd180658efbb41 mlx5ib: adjust for the mlx5_create_auto_grouped_flow_table() interface change
> e073fccf14569f61b312078d0cee9a6f6eb17a37 mlx5: add ability to attach flow counter to steering rule
> 52164cb3bd38ef23c108149e4a91042da204a2f3 mlx5: add fs_counters
> 5a2ff1f03ad245577498bcbc3907f4ae336fd9e8 mlx5: Add a no-append flow insertion mode
> 67a9c8868af371f3e0b96a18d1f9d54fd2be4b1a net/mlx5: Allow creating autogroups with reserved entries
> 4c6a46cea41b236f9b06e702e8491055dddc7d4c net/mlx5: Fix auto group size calculation
> 0759f76e579d61e4609b05ea0efcc2d1a63d2679 mlx5: Use software enum in APIs instead of PRM
> 6fb2eebf6471ee08949dd027a6beffdbf78d8bb1 mlx5: Add packet reformat support to flow rules
> 8895a0509698f29bb234a186590e3f08970a34d9 mlx5: Add modify header support to flow rules
> 08e7b322db02329516e5d8adcec9df3c7b20774c mlx5: Refactor flow actions into a struct
> 87d86f3733a4cdfb5777bc2b28bd11db93c7ab97 mlx5: Add packet reformat allocation support
> 2b729c222d4821069c817c853f56826d065f7ac7 mlx5: Add modify header support
> ```
> 
> You may want to revert part(s) of them to check which one is to be blamed.
> You can build the driver module only, that should be quite fast.

The commit 0cd90ee598cef68cef72db8b912241868d1067d0 most likely fixes the
problem.  I will merge it to stable/14 shortly.