maintainer-feedback requested: [Bug 267934] www/webkit2-gtk4: fails to build in poudriere with no OPTIONS set

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 22 Nov 2022 20:48:55 UTC
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-gnome (Nobody)
<gnome@FreeBSD.org> for maintainer-feedback:
Bug 267934: www/webkit2-gtk4: fails to build in poudriere with no OPTIONS set
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267934



--- Description ---
www/webkit2-gtk4 fails to build in poudriere ('poudriere testport' to be
exact).

Relevant configuration details:

port directory: /usr/ports/www/webkit2-gtk4
package name: webkit2-gtk4-2.34.6_1
building for: FreeBSD 131Ramd64-ports_wip 13.1-RELEASE-p2 FreeBSD
13.1-RELEASE-p2 amd64
maintained by: gnome@FreeBSD.org
Makefile datestamp: -rw-r--r--	1 1001	staff  3734 Oct 24 15:46
/usr/ports/www/webkit2-gtk4/Makefile
Poudriere version: poudriere-git-3.3.99.20220831
Host OSVERSION: 1301507
Jail OSVERSION: 1301000


---Begin OPTIONS List---
===> The following configuration options are available for
webkit2-gtk4-2.34.6_1:
     DEBUG=off: Build with debugging support
     GEOIP=off: GeoIP IP location support
     GSTREAMER=off: Multimedia support via GStreamer
     WAYLAND=off: Wayland (graphics) support
===> Use 'make config' to modify these settings
---End OPTIONS List---


This seems to be the culprit:
----8<----
In file included from
/wrkdirs/usr/ports/www/webkit2-gtk4/work/webkitgtk-2.34.6/Source/WebKit/UIProce
ss/gtk/ClipboardGtk4.cpp:31:
In file included from
/wrkdirs/usr/ports/www/webkit2-gtk4/work/webkitgtk-2.34.6/Source/WebKit/UIProce
ss/WebPasteboardProxy.h:28:
In file included from
/wrkdirs/usr/ports/www/webkit2-gtk4/work/webkitgtk-2.34.6/Source/WebKit/Platfor
m/IPC/MessageReceiver.h:29:
In file included from
/wrkdirs/usr/ports/www/webkit2-gtk4/work/.build/WTF/Headers/wtf/WeakPtr.h:30:
In file included from
/wrkdirs/usr/ports/www/webkit2-gtk4/work/.build/WTF/Headers/wtf/Threading.h:39:
In file included from
/wrkdirs/usr/ports/www/webkit2-gtk4/work/.build/WTF/Headers/wtf/HashMap.h:25:
/wrkdirs/usr/ports/www/webkit2-gtk4/work/.build/WTF/Headers/wtf/HashTable.h:156
9:109:
warning: 'iterator<std::forward_iterator_tag, WebCore::NativeImage::Observer *,
long, WebCore::NativeImage::Observer *const *, WebCore::NativeImage::Observer
*const &>' is depre
cated [-Wdeprecated-declarations]
    template<typename HashTableType, typename ValueType> struct
HashTableConstIteratorAdapter : public std::iterator<std::forward_iterator_tag,
ValueType, std::ptrdiff_t, const ValueType*, const ValueType&> {
									       
			    ^
/wrkdirs/usr/ports/www/webkit2-gtk4/work/.build/WebCore/PrivateHeaders/WebCore/
NativeImage.h:64:66:
note: in instantiation of template class
'WTF::HashTableConstIteratorAdapter<WTF::HashTable<WebCore::NativeImage::Observ
er
*, WebCore::NativeImage::Observer *, WTF
::IdentityExtractor, WTF::DefaultHash<WebCore::NativeImage::Observer *>,
WTF::HashTraits<WebCore::NativeImage::Observer *>,
WTF::HashTraits<WebCore::NativeImage::Observer *>>,
WebCore::NativeImage::Observer *>' requested here
    void removeObserver(Observer& observer) { m_observers.remove(&observer); }
								 ^
/usr/include/c++/v1/__iterator/iterator.h:27:29: note:
'iterator<std::forward_iterator_tag, WebCore::NativeImage::Observer *, long,
WebCore::NativeImage::Observer *const *, WebCore::NativeImage::Observer *const
&>' has been explicitly marked deprecated here
struct _LIBCPP_TEMPLATE_VIS _LIBCPP_DEPRECATED_IN_CXX17 iterator
			    ^
/usr/include/c++/v1/__config:1016:39: note: expanded from macro
'_LIBCPP_DEPRECATED_IN_CXX17'
#  define _LIBCPP_DEPRECATED_IN_CXX17 _LIBCPP_DEPRECATED
				      ^
/usr/include/c++/v1/__config:993:48: note: expanded from macro
'_LIBCPP_DEPRECATED'
#    define _LIBCPP_DEPRECATED __attribute__ ((deprecated))
					       ^
/wrkdirs/usr/ports/www/webkit2-gtk4/work/webkitgtk-2.34.6/Source/WebKit/UIProce
ss/gtk/ClipboardGtk4.cpp:83:25:
error: expected ';' after expression
	GUniquePtr<char>
text(gdk_clipboard_read_text_finish(GDK_CLIPBOARD(clipboard), result,
nullptr));
			^
			;
/wrkdirs/usr/ports/www/webkit2-gtk4/work/webkitgtk-2.34.6/Source/WebKit/UIProce
ss/gtk/ClipboardGtk4.cpp:83:9:
error: use of undeclared identifier 'GUniquePtr'
	GUniquePtr<char>
text(gdk_clipboard_read_text_finish(GDK_CLIPBOARD(clipboard), result,
nullptr));
	^
/wrkdirs/usr/ports/www/webkit2-gtk4/work/webkitgtk-2.34.6/Source/WebKit/UIProce
ss/gtk/ClipboardGtk4.cpp:83:26:
error: use of undeclared identifier 'text'
	GUniquePtr<char>
text(gdk_clipboard_read_text_finish(GDK_CLIPBOARD(clipboard), result,
nullptr));
			 ^
/wrkdirs/usr/ports/www/webkit2-gtk4/work/webkitgtk-2.34.6/Source/WebKit/UIProce
ss/gtk/ClipboardGtk4.cpp:84:50:
error: use of undeclared identifier 'text'
	data->completionHandler(String::fromUTF8(text.get()));
						 ^
/wrkdirs/usr/ports/www/webkit2-gtk4/work/webkitgtk-2.34.6/Source/WebKit/UIProce
ss/gtk/ClipboardGtk4.cpp:111:34:
error: expected ';' after expression
		GUniquePtr<gchar> filename(g_file_get_path(file));
				 ^
				 ;
/wrkdirs/usr/ports/www/webkit2-gtk4/work/webkitgtk-2.34.6/Source/WebKit/UIProce
ss/gtk/ClipboardGtk4.cpp:111:17:
error: use of undeclared identifier 'GUniquePtr'
		GUniquePtr<gchar> filename(g_file_get_path(file));
		^
/wrkdirs/usr/ports/www/webkit2-gtk4/work/webkitgtk-2.34.6/Source/WebKit/UIProce
ss/gtk/ClipboardGtk4.cpp:111:35:
error: use of undeclared identifier 'filename'
		GUniquePtr<gchar> filename(g_file_get_path(file));
				  ^
/wrkdirs/usr/ports/www/webkit2-gtk4/work/webkitgtk-2.34.6/Source/WebKit/UIProce
ss/gtk/ClipboardGtk4.cpp:112:21:
error: use of undeclared identifier 'filename'
		if (filename)
		    ^
/wrkdirs/usr/ports/www/webkit2-gtk4/work/webkitgtk-2.34.6/Source/WebKit/UIProce
ss/gtk/ClipboardGtk4.cpp:113:55:
error: use of undeclared identifier 'filename'
		    filePaths.append(String::fromUTF8(filename.get()));
						      ^
12 warnings and 9 errors generated.
---->8----

The complete logfile is available here:
http://philippost.de/tmp/ports/webkit2-gtk4-2.34.6_1.log.xz

The port also fails to build on bare metal with the same errors on at least two
independant machines (both running 13.1-STABLE, one from early October, the
other from early November; both amd64).