Re: Proposed Github Pull Request Policy

From: Brooks Davis <brooks_at_freebsd.org>
Date: Fri, 03 Feb 2023 16:42:25 UTC
On Thu, Feb 02, 2023 at 07:12:29PM -0700, Warner Losh wrote:
> Geetngs,
> 
> I'd like to put some parameters around the pull requests on github. To that
> end, I'd like us to consider the following policy:

This seems like a good start.

> Pull requests shouldn't expand in scope in response to feedback: If the
> feedback suggests a new series of changes, please create a new pull
> requests.

I think I'd prefer: "Pull requests shouldn't expand in scope once
created:...".

Some direction on using rebase and forced push when addressing feedback is
probably also in order.  If I'm taking a few minutes to look at a PR that
caught my eye I don't want to wade through a bunch of fixups.

-- Brooks