[Bug 264174] Use of redaction bookmarks or redacted datasets on a boot pool renders the pool unbootable

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 06 Jun 2022 15:42:03 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264174

Mark Johnston <markj@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open

--- Comment #1 from Mark Johnston <markj@FreeBSD.org> ---
I haven't yet attempted to reproduce this, but the described behaviour of
enabling a read-only-incompatible feature upon receiving a dataset sounds quite
wrong.

I do see the following in recv_begin_check_feature_flags_impl():

 543         /*
 544          * Receiving redacted streams requires that redacted datasets are
 545          * enabled.
 546          */
 547         if ((featureflags & DMU_BACKUP_FEATURE_REDACTED) &&
 548             !spa_feature_is_enabled(spa, SPA_FEATURE_REDACTED_DATASETS))
 549                 return (SET_ERROR(ENOTSUP));

so it seems that we are indeed checking this.  Perhaps that's not sufficient
somehow.

Of course, ideally we could handle these features in the loader.

-- 
You are receiving this mail because:
You are the assignee for the bug.