Re: git: 1fd880742ace - main - libsys: add a libsys.h

From: Brooks Davis <brooks_at_freebsd.org>
Date: Tue, 23 Apr 2024 20:06:18 UTC
On Tue, Apr 23, 2024 at 09:58:19PM +0200, Peter Holm wrote:
> On Tue, Apr 16, 2024 at 04:48:21PM +0000, Brooks Davis wrote:
> > The branch main has been updated by brooks:
> > 
> > URL: https://cgit.FreeBSD.org/src/commit/?id=1fd880742ace94e11fa60ee0b074f0b18e54c54f
> > 
> > commit 1fd880742ace94e11fa60ee0b074f0b18e54c54f
> > Author:     Brooks Davis <brooks@FreeBSD.org>
> > AuthorDate: 2024-04-16 16:48:07 +0000
> > Commit:     Brooks Davis <brooks@FreeBSD.org>
> > CommitDate: 2024-04-16 16:48:07 +0000
> > 
> >     libsys: add a libsys.h
> >     
> >     This declares an API for libsys which currently consists of
> >     __sys_<foo>() declarations for system call stubs and function pointer
> >     typedefs of the form __sys_<foo>_t.  The vast majority of the
> >     implementation resides in a generated _libsys.h which ensures that all
> >     system call stub declarations match syscalls.master.
> >     
> >     Reviewed by:    kib
> >     Differential Revision:  https://reviews.freebsd.org/D44387
> > ---
> >  lib/libsys/Makefile    |   2 +
> >  lib/libsys/_libsys.h   | 865 +++++++++++++++++++++++++++++++++++++++++++++++++
> >  lib/libsys/libsys.h    |  25 ++
> >  sys/kern/syscalls.conf |   1 +
> >  4 files changed, 893 insertions(+)
> > 
> 
> Shouldn't readv() and writev() return ssize_t?

Indeed.  This is a bug in syscalls.master from which this header is
generated.  I'll fix it.

Thanks,
Brooks