Re: git: 78ee8d1c4cda - main - qat: Import a new Intel (R) QAT driver

From: Konstantin Belousov <kostikbel_at_gmail.com>
Date: Thu, 28 Jul 2022 07:28:16 UTC
On Wed, Jul 27, 2022 at 03:14:05PM +0000, Mark Johnston wrote:
> The branch main has been updated by markj:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=78ee8d1c4cdad7a56dbf50f1c8ade75531ce620c
> 
> commit 78ee8d1c4cdad7a56dbf50f1c8ade75531ce620c
> Author:     Julian Grajkowski <julianx.grajkowski@intel.com>
> AuthorDate: 2022-07-19 08:15:34 +0000
> Commit:     Mark Johnston <markj@FreeBSD.org>
> CommitDate: 2022-07-27 15:12:35 +0000
> 
>     qat: Import a new Intel (R) QAT driver
>     
>     QAT in-tree driver ported from out-of-tree release available
>     from 01.org.
>     
>     The driver exposes complete cryptography and data compression
>     API in the kernel and integrates with Open Crypto Framework.
>     Details of supported operations, devices and usage can be found
>     in man and on 01.org.
>     
>     Patch co-authored by: Krzysztof Zdziarski <krzysztofx.zdziarski@intel.com>
>     Patch co-authored by: Michal Jaraczewski <michalx.jaraczewski@intel.com>
>     Patch co-authored by: Michal Gulbicki <michalx.gulbicki@intel.com>
>     Patch co-authored by: Julian Grajkowski <julianx.grajkowski@intel.com>
>     Patch co-authored by: Piotr Kasierski <piotrx.kasierski@intel.com>
>     Patch co-authored by: Adam Czupryna <adamx.czupryna@intel.com>
>     Patch co-authored by: Konrad Zelazny <konradx.zelazny@intel.com>
>     Patch co-authored by: Katarzyna Rucinska <katarzynax.kargol@intel.com>
>     Patch co-authored by: Lukasz Kolodzinski <lukaszx.kolodzinski@intel.com>
>     Patch co-authored by: Zbigniew Jedlinski <zbigniewx.jedlinski@intel.com>
>     
>     Reviewed by:    markj, jhb (OCF integration)
>     Reviewed by:    debdrup, pauamma (docs)
>     Sponsored by:   Intel Corporation
>     Differential Revision: https://reviews.freebsd.org/D34632

I believe that qat_c2xxx lacks required
MODULE_DEPEND(qat_c2xxx, firmware, ...)
dependency line.

I am not sure about qat since it depends on linuxkpi, but perhaps there
something similar is needed as well.