Re: git: b430a140c818 - main - net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple

20.01.24 17:15, Daniel Engberg:
> Please at least enable DEVELOPER=yes and fix any warnings


Why? How would that help anything?

> Use the standard definition for POSTGRES, PGSQL
> https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n410

Ok, I renamed the option. But the description is still port-specific...

> SQLITE option is broken
> "post-patch-SQLIT3-off"
Ah, thanks!
>
> Overall ordering in Makefile can be improved
portlint only mentions the patch being manually created...
> LDFLAGS can probably be replaced with USES= localbase:ldflags
Indeed!
>
> Configure logs suggests that USES= pkgconfig should be added
Neah. Upstream's cmake-file tries to use pkgconfig to find libpurple. 
But it does not work anyway -- and the port supplies definitions for all 
the of the relevant cmake variables.
>
> It also fails to build
>
> https://pdr2.bofh.network/data/140-diizzy/2024-01-20_15h50m31s/logs/errors/purple-gowhatsapp-1.13.0.log
>
So it does... But the failure is not due to anything you mentioned, but 
because of go's inability to download the additional modules, that the 
software wants:

    go: finding module for package go.mau.fi/whatsmeow/store
    github.com/hoehermann/purple-gowhatsapp/src/go imports
    	github.com/alfg/mp4: module github.com/alfg/mp4: Get"https://proxy.golang.org/github.com/alfg/mp4/@v/list": dial tcp: lookup proxy.golang.org on 199.115.205.169:53: write udp 127.0.0.1:54689->199.115.205.169:53: write: permission denied

Perhaps, that's because downloading during build is a no-no... I did 
e-mail maintainers of the Uses/go.mk last night seeking suggestions 
about this. There was no reply, so I decided to commit it -- and asked 
for help. Which helping would be easier, if the helper(s) could just 
commit an improvement...

> If you're unsure please consider to create a review / PR instead of 
> just committing.
Sorry, but what's the difference? Was Production Support woken up 
somewhere by a Level-1 alert due to the build-failure?
> Please back this out for now.

  The only good reason to back out a change is when it breaks something 
else. Which this one didn't...

  I'll try to fix it, of course -- and if someone can help me with 
predownloading the Go-modules, that'd be great (Maven-using ports must 
dealing with that somehow...)

But why would you want it backed out?!

    -mi