Re: git: 665b0219e541 - main - Mk/Uses: Fix feature checks after my previous {WITH,WITHOUT}_*_PORTS change

From: Mathieu Arnold <mat_at_freebsd.org>
Date: Thu, 11 Apr 2024 19:03:05 UTC
Hi,

I'm picking on one hunk but they all look similar.

On Thu, Apr 11, 2024 at 05:54:45PM +0000, Gleb Popov wrote:
> -.  if !defined(WITH_DEBUG)
> +.  if !defined(_WITH_DEBUG)

I don't really understand, is WITH_DEBUG gone ? Because that cannot be.
There are a gazillion of ports that do stuff when WITH_DEBUG.

If I set WITH_DEBUG_PORTS+=dns/bind918, and then I build dns/bind918, I
assume that WITH_DEBUG will be set in that port.


$ make -C dns/bind918 -V USE_PERL5

$ make -C dns/bind918 -V USE_PERL5 WITH_DEBUG=y
build
$ make -C dns/bind918 -V USE_PERL5 WITH_DEBUG_PORTS=dns/bind918


So, you broke WITH_DEBUG_PORTS :(

Can you please immediately revert this commit (665b0219e541) and the one
that broke it to begin with ?

-- 
Mathieu Arnold